From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 657D9CCA471 for ; Wed, 1 Jun 2022 14:11:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235811AbiFAOLr (ORCPT ); Wed, 1 Jun 2022 10:11:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354519AbiFAOJp (ORCPT ); Wed, 1 Jun 2022 10:09:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9272AE0C2; Wed, 1 Jun 2022 07:01:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2EA69615B9; Wed, 1 Jun 2022 14:01:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6E5CC3411E; Wed, 1 Jun 2022 14:01:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654092069; bh=lvbxb7mAlb7/kG5niCqFw2s1N/0n9eUI4WHhmjAKwLs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UoMyXqYrws9knblX7Q5cgD+Tmapuqvjh985E03Hd9q53OksrBeCwxAVKpoP7dq61I tVfo/6d/pgJwBg3hKXnJCl7u4BHknGL6LD+PfZbA4I3Jk6WumFjqXAzmpGSlLeYZt1 w7jYhAJW0tzscxb4u5OIm8toXK4KqqNL4qcmEbl5MUqWtrudlqrAl1iGGnMXuLlJov 1l7AX72r7a1LX+WGGo6F9KHuQffQzQr/bnOQDS66KImub0Qtx0SVuUwNTpHqZCtD28 dm4JI0SWQwxC3PbYfMOszaPdMY+0oqJa1NjQLaxPm38BPzYGaivxKexFvreQMxolcW gGQpMu8PowMfA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: OGAWA Hirofumi , qianfan , Andrew Morton , Sasha Levin Subject: [PATCH AUTOSEL 4.9 04/11] fat: add ratelimit to fat*_ent_bread() Date: Wed, 1 Jun 2022 10:00:53 -0400 Message-Id: <20220601140100.2005469-4-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220601140100.2005469-1-sashal@kernel.org> References: <20220601140100.2005469-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: OGAWA Hirofumi [ Upstream commit 183c3237c928109d2008c0456dff508baf692b20 ] fat*_ent_bread() can be the cause of too many report on I/O error path. So use fat_msg_ratelimit() instead. Link: https://lkml.kernel.org/r/87bkxogfeq.fsf@mail.parknet.co.jp Signed-off-by: OGAWA Hirofumi Reported-by: qianfan Tested-by: qianfan Signed-off-by: Andrew Morton Signed-off-by: Sasha Levin --- fs/fat/fatent.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fs/fat/fatent.c b/fs/fat/fatent.c index 0129d4d07a54..b0b1a71c07b7 100644 --- a/fs/fat/fatent.c +++ b/fs/fat/fatent.c @@ -92,7 +92,8 @@ static int fat12_ent_bread(struct super_block *sb, struct fat_entry *fatent, err_brelse: brelse(bhs[0]); err: - fat_msg(sb, KERN_ERR, "FAT read failed (blocknr %llu)", (llu)blocknr); + fat_msg_ratelimit(sb, KERN_ERR, "FAT read failed (blocknr %llu)", + (llu)blocknr); return -EIO; } @@ -105,8 +106,8 @@ static int fat_ent_bread(struct super_block *sb, struct fat_entry *fatent, fatent->fat_inode = MSDOS_SB(sb)->fat_inode; fatent->bhs[0] = sb_bread(sb, blocknr); if (!fatent->bhs[0]) { - fat_msg(sb, KERN_ERR, "FAT read failed (blocknr %llu)", - (llu)blocknr); + fat_msg_ratelimit(sb, KERN_ERR, "FAT read failed (blocknr %llu)", + (llu)blocknr); return -EIO; } fatent->nr_bhs = 1; -- 2.35.1