From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41CCDC43334 for ; Tue, 7 Jun 2022 19:02:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353342AbiFGTCB (ORCPT ); Tue, 7 Jun 2022 15:02:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354861AbiFGTB3 (ORCPT ); Tue, 7 Jun 2022 15:01:29 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59FA8152BB0; Tue, 7 Jun 2022 11:04:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 126A9B81F38; Tue, 7 Jun 2022 18:04:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E5C2C34115; Tue, 7 Jun 2022 18:04:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1654625091; bh=1dCLiXmDl2CygEcGAHLEhDctwJwsHtkve7vMV6l+/mg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=14q2Qm19elgdAqkOCXQDx/tlhk6uz3q98zPxq/RnIRkCZnVxZVsodXzEdbH3j6UCy G+XZFfEcKlOaoSpKjLEyrBVxuUv1UgtgA8apofcrhXdnCKzZMAPhBUjqgv664u/q6/ Ed12lxTXDzj4xc7QfwnrHRxTw76ARqYjpSBKDKe8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Alexander Aring , David Teigland Subject: [PATCH 5.15 562/667] dlm: uninitialized variable on error in dlm_listen_for_all() Date: Tue, 7 Jun 2022 19:03:47 +0200 Message-Id: <20220607164951.552022686@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220607164934.766888869@linuxfoundation.org> References: <20220607164934.766888869@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Dan Carpenter commit 1f4f10845e14690b02410de50d9ea9684625a4ae upstream. The "sock" variable is not initialized on this error path. Cc: stable@vger.kernel.org Fixes: 2dc6b1158c28 ("fs: dlm: introduce generic listen") Signed-off-by: Dan Carpenter Signed-off-by: Alexander Aring Signed-off-by: David Teigland Signed-off-by: Greg Kroah-Hartman --- fs/dlm/lowcomms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/dlm/lowcomms.c +++ b/fs/dlm/lowcomms.c @@ -1776,7 +1776,7 @@ static int dlm_listen_for_all(void) SOCK_STREAM, dlm_proto_ops->proto, &sock); if (result < 0) { log_print("Can't create comms socket, check SCTP is loaded"); - goto out; + return result; } sock_set_mark(sock->sk, dlm_config.ci_mark);