From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AC30C433EF for ; Tue, 21 Jun 2022 20:57:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355354AbiFUU5b (ORCPT ); Tue, 21 Jun 2022 16:57:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354880AbiFUU4m (ORCPT ); Tue, 21 Jun 2022 16:56:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BBE43192E; Tue, 21 Jun 2022 13:50:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B829B61881; Tue, 21 Jun 2022 20:50:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7BCC1C341CB; Tue, 21 Jun 2022 20:50:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655844624; bh=xPbzL0wDc6CwHXS68a6rilmIYemKUNjBohiq+mwTVsw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mcwytWdMJEalMs8e+43HgrXzYARYWTLQeSe6RFede4OarbbCMbjhI/308m0LPUup4 HjwDmK3z8/jj4k1KfuVNwlTDXc17wl5iqWVSnCcod1pFiQvoswIWgBrdzzU0MyvxMf C5EZxpSYJ/gbDqwL2D4/g8VmGA667duf5sXXFz6L7toO4P1ZdEcPJAFCxbfm9u0ARE 8byOB37jSB0JJZ8U3Dv/Zesxh8uWmnwvJuHjNlq0mwR+1IbdepGtGQ/nxlBE0mamR8 bdzt8qk27o6O63p9rrgdbVdrj9lX35VVf676dOKwLAaXhszaSFhHkQC2MwNJb+8U2l atgvgMpP4TGNg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Keith Busch , Chaitanya Kulkarni , Christoph Hellwig , Sasha Levin , axboe@fb.com, sagi@grimberg.me, linux-nvme@lists.infradead.org Subject: [PATCH AUTOSEL 5.17 06/20] nvme-pci: add trouble shooting steps for timeouts Date: Tue, 21 Jun 2022 16:49:56 -0400 Message-Id: <20220621205010.250185-6-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220621205010.250185-1-sashal@kernel.org> References: <20220621205010.250185-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Keith Busch [ Upstream commit 4641a8e6e145f595059e695f0f8dbbe608134086 ] Many users have encountered IO timeouts with a CSTS value of 0xffffffff, which indicates a failure to read the register. While there are various potential causes for this observation, faulty NVMe APST has been the culprit quite frequently. Add the recommended troubleshooting steps in the error output when this condition occurs. Signed-off-by: Keith Busch Reviewed-by: Chaitanya Kulkarni Signed-off-by: Christoph Hellwig Signed-off-by: Sasha Levin --- drivers/nvme/host/pci.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 823fa48fbfb0..f2d8d939cc2f 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -1332,6 +1332,14 @@ static void nvme_warn_reset(struct nvme_dev *dev, u32 csts) dev_warn(dev->ctrl.device, "controller is down; will reset: CSTS=0x%x, PCI_STATUS read failed (%d)\n", csts, result); + + if (csts != ~0) + return; + + dev_warn(dev->ctrl.device, + "Does your device have a faulty power saving mode enabled?\n"); + dev_warn(dev->ctrl.device, + "Try \"nvme_core.default_ps_max_latency_us=0 pcie_aspm=off\" and report a bug\n"); } static enum blk_eh_timer_return nvme_timeout(struct request *req, bool reserved) -- 2.35.1