From: Vladimir Oltean <olteanv@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: stable@vger.kernel.org, Doug Berger <opendmb@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sasha Levin <sashal@kernel.org>,
netdev@vger.kernel.org, andrew@lunn.ch
Subject: Re: [PATCH stable 4.9 v2] net: dsa: bcm_sf2: force pause link settings
Date: Fri, 8 Jul 2022 01:15:37 +0300 [thread overview]
Message-ID: <20220707221537.atc4b2k7fifhvaej@skbuf> (raw)
In-Reply-To: <b503199e-61d2-4d60-99dc-0f71616f7ec9@gmail.com>
On Thu, Jul 07, 2022 at 09:53:04AM -0700, Florian Fainelli wrote:
> > IEEE 802.3 says "The PAUSE function shall be enabled according to Table
> > 28B–3 only if the highest common denominator is a full duplex technology."
>
> Indeed, sorry about that, so I suppose the incremental patch would do, since
> we do not support changing pause frame auto-negotiation settings in 4.9:
>
> diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c
> index 562b5eb23d90..f3d61f2bb0f7 100644
> --- a/drivers/net/dsa/bcm_sf2.c
> +++ b/drivers/net/dsa/bcm_sf2.c
> @@ -669,15 +669,18 @@ static void bcm_sf2_sw_adjust_link(struct dsa_switch
> *ds, int port,
> break;
> }
>
> - if (phydev->pause)
> - rmt_adv = LPA_PAUSE_CAP;
> - if (phydev->asym_pause)
> - rmt_adv |= LPA_PAUSE_ASYM;
> - if (phydev->advertising & ADVERTISED_Pause)
> - lcl_adv = ADVERTISE_PAUSE_CAP;
> - if (phydev->advertising & ADVERTISED_Asym_Pause)
> - lcl_adv |= ADVERTISE_PAUSE_ASYM;
> - flowctrl = mii_resolve_flowctrl_fdx(lcl_adv, rmt_adv);
> + if (phydev->duplex == DUPLEX_FULL &&
> + phydev->autoneg == AUTONEG_ENABLE) {
> + if (phydev->pause)
> + rmt_adv = LPA_PAUSE_CAP;
> + if (phydev->asym_pause)
> + rmt_adv |= LPA_PAUSE_ASYM;
> + if (phydev->advertising & ADVERTISED_Pause)
> + lcl_adv = ADVERTISE_PAUSE_CAP;
> + if (phydev->advertising & ADVERTISED_Asym_Pause)
> + lcl_adv |= ADVERTISE_PAUSE_ASYM;
> + flowctrl = mii_resolve_flowctrl_fdx(lcl_adv, rmt_adv);
> + }
>
> if (phydev->link)
> reg |= LINK_STS;
Yes, this looks OK, thank you.
prev parent reply other threads:[~2022-07-07 22:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 19:24 [PATCH stable 4.9 v2] net: dsa: bcm_sf2: force pause link settings Florian Fainelli
2022-07-06 19:24 ` [PATCH stable 4.14 " Florian Fainelli
2022-07-06 20:31 ` [PATCH stable 4.9 " Vladimir Oltean
2022-07-07 16:53 ` Florian Fainelli
2022-07-07 22:15 ` Vladimir Oltean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220707221537.atc4b2k7fifhvaej@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox