From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Borislav Petkov <bp@suse.de>,
Thadeu Lima de Souza Cascardo <cascardo@canonical.com>,
Ben Hutchings <ben@decadent.org.uk>
Subject: [PATCH 5.10 125/148] x86/retbleed: Add fine grained Kconfig knobs
Date: Sat, 23 Jul 2022 11:55:37 +0200 [thread overview]
Message-ID: <20220723095259.304261366@linuxfoundation.org> (raw)
In-Reply-To: <20220723095224.302504400@linuxfoundation.org>
From: Peter Zijlstra <peterz@infradead.org>
commit f43b9876e857c739d407bc56df288b0ebe1a9164 upstream.
Do fine-grained Kconfig for all the various retbleed parts.
NOTE: if your compiler doesn't support return thunks this will
silently 'upgrade' your mitigation to IBPB, you might not like this.
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Borislav Petkov <bp@suse.de>
[cascardo: there is no CONFIG_OBJTOOL]
[cascardo: objtool calling and option parsing has changed]
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
[bwh: Backported to 5.10:
- In scripts/Makefile.build, add the objtool option with an ifdef
block, same as for other options
- Adjust filename, context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
Makefile | 8 +-
arch/x86/Kconfig | 106 +++++++++++++++++++++++--------
arch/x86/entry/calling.h | 4 +
arch/x86/include/asm/disabled-features.h | 18 ++++-
arch/x86/include/asm/linkage.h | 4 -
arch/x86/include/asm/nospec-branch.h | 10 ++
arch/x86/include/asm/static_call.h | 2
arch/x86/kernel/alternative.c | 5 +
arch/x86/kernel/cpu/amd.c | 2
arch/x86/kernel/cpu/bugs.c | 42 +++++++-----
arch/x86/kernel/static_call.c | 2
arch/x86/kvm/emulate.c | 4 -
arch/x86/lib/retpoline.S | 4 +
scripts/Makefile.build | 3
scripts/link-vmlinux.sh | 2
security/Kconfig | 11 ---
tools/objtool/builtin-check.c | 3
tools/objtool/builtin.h | 2
tools/objtool/check.c | 9 ++
19 files changed, 172 insertions(+), 69 deletions(-)
--- a/Makefile
+++ b/Makefile
@@ -672,14 +672,18 @@ endif
ifdef CONFIG_CC_IS_GCC
RETPOLINE_CFLAGS := $(call cc-option,-mindirect-branch=thunk-extern -mindirect-branch-register)
-RETPOLINE_CFLAGS += $(call cc-option,-mfunction-return=thunk-extern)
RETPOLINE_VDSO_CFLAGS := $(call cc-option,-mindirect-branch=thunk-inline -mindirect-branch-register)
endif
ifdef CONFIG_CC_IS_CLANG
RETPOLINE_CFLAGS := -mretpoline-external-thunk
RETPOLINE_VDSO_CFLAGS := -mretpoline
-RETPOLINE_CFLAGS += $(call cc-option,-mfunction-return=thunk-extern)
endif
+
+ifdef CONFIG_RETHUNK
+RETHUNK_CFLAGS := -mfunction-return=thunk-extern
+RETPOLINE_CFLAGS += $(RETHUNK_CFLAGS)
+endif
+
export RETPOLINE_CFLAGS
export RETPOLINE_VDSO_CFLAGS
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -453,30 +453,6 @@ config GOLDFISH
def_bool y
depends on X86_GOLDFISH
-config RETPOLINE
- bool "Avoid speculative indirect branches in kernel"
- default y
- help
- Compile kernel with the retpoline compiler options to guard against
- kernel-to-user data leaks by avoiding speculative indirect
- branches. Requires a compiler with -mindirect-branch=thunk-extern
- support for full protection. The kernel may run slower.
-
-config CC_HAS_SLS
- def_bool $(cc-option,-mharden-sls=all)
-
-config CC_HAS_RETURN_THUNK
- def_bool $(cc-option,-mfunction-return=thunk-extern)
-
-config SLS
- bool "Mitigate Straight-Line-Speculation"
- depends on CC_HAS_SLS && X86_64
- default n
- help
- Compile the kernel with straight-line-speculation options to guard
- against straight line speculation. The kernel image might be slightly
- larger.
-
config X86_CPU_RESCTRL
bool "x86 CPU resource control support"
depends on X86 && (CPU_SUP_INTEL || CPU_SUP_AMD)
@@ -2430,6 +2406,88 @@ source "kernel/livepatch/Kconfig"
endmenu
+config CC_HAS_SLS
+ def_bool $(cc-option,-mharden-sls=all)
+
+config CC_HAS_RETURN_THUNK
+ def_bool $(cc-option,-mfunction-return=thunk-extern)
+
+menuconfig SPECULATION_MITIGATIONS
+ bool "Mitigations for speculative execution vulnerabilities"
+ default y
+ help
+ Say Y here to enable options which enable mitigations for
+ speculative execution hardware vulnerabilities.
+
+ If you say N, all mitigations will be disabled. You really
+ should know what you are doing to say so.
+
+if SPECULATION_MITIGATIONS
+
+config PAGE_TABLE_ISOLATION
+ bool "Remove the kernel mapping in user mode"
+ default y
+ depends on (X86_64 || X86_PAE)
+ help
+ This feature reduces the number of hardware side channels by
+ ensuring that the majority of kernel addresses are not mapped
+ into userspace.
+
+ See Documentation/x86/pti.rst for more details.
+
+config RETPOLINE
+ bool "Avoid speculative indirect branches in kernel"
+ default y
+ help
+ Compile kernel with the retpoline compiler options to guard against
+ kernel-to-user data leaks by avoiding speculative indirect
+ branches. Requires a compiler with -mindirect-branch=thunk-extern
+ support for full protection. The kernel may run slower.
+
+config RETHUNK
+ bool "Enable return-thunks"
+ depends on RETPOLINE && CC_HAS_RETURN_THUNK
+ default y
+ help
+ Compile the kernel with the return-thunks compiler option to guard
+ against kernel-to-user data leaks by avoiding return speculation.
+ Requires a compiler with -mfunction-return=thunk-extern
+ support for full protection. The kernel may run slower.
+
+config CPU_UNRET_ENTRY
+ bool "Enable UNRET on kernel entry"
+ depends on CPU_SUP_AMD && RETHUNK
+ default y
+ help
+ Compile the kernel with support for the retbleed=unret mitigation.
+
+config CPU_IBPB_ENTRY
+ bool "Enable IBPB on kernel entry"
+ depends on CPU_SUP_AMD
+ default y
+ help
+ Compile the kernel with support for the retbleed=ibpb mitigation.
+
+config CPU_IBRS_ENTRY
+ bool "Enable IBRS on kernel entry"
+ depends on CPU_SUP_INTEL
+ default y
+ help
+ Compile the kernel with support for the spectre_v2=ibrs mitigation.
+ This mitigates both spectre_v2 and retbleed at great cost to
+ performance.
+
+config SLS
+ bool "Mitigate Straight-Line-Speculation"
+ depends on CC_HAS_SLS && X86_64
+ default n
+ help
+ Compile the kernel with straight-line-speculation options to guard
+ against straight line speculation. The kernel image might be slightly
+ larger.
+
+endif
+
config ARCH_HAS_ADD_PAGES
def_bool y
depends on X86_64 && ARCH_ENABLE_MEMORY_HOTPLUG
--- a/arch/x86/entry/calling.h
+++ b/arch/x86/entry/calling.h
@@ -323,6 +323,7 @@ For 32-bit we have the following convent
* Assumes x86_spec_ctrl_{base,current} to have SPEC_CTRL_IBRS set.
*/
.macro IBRS_ENTER save_reg
+#ifdef CONFIG_CPU_IBRS_ENTRY
ALTERNATIVE "jmp .Lend_\@", "", X86_FEATURE_KERNEL_IBRS
movl $MSR_IA32_SPEC_CTRL, %ecx
@@ -343,6 +344,7 @@ For 32-bit we have the following convent
shr $32, %rdx
wrmsr
.Lend_\@:
+#endif
.endm
/*
@@ -350,6 +352,7 @@ For 32-bit we have the following convent
* regs. Must be called after the last RET.
*/
.macro IBRS_EXIT save_reg
+#ifdef CONFIG_CPU_IBRS_ENTRY
ALTERNATIVE "jmp .Lend_\@", "", X86_FEATURE_KERNEL_IBRS
movl $MSR_IA32_SPEC_CTRL, %ecx
@@ -364,6 +367,7 @@ For 32-bit we have the following convent
shr $32, %rdx
wrmsr
.Lend_\@:
+#endif
.endm
/*
--- a/arch/x86/include/asm/disabled-features.h
+++ b/arch/x86/include/asm/disabled-features.h
@@ -60,9 +60,19 @@
# define DISABLE_RETPOLINE 0
#else
# define DISABLE_RETPOLINE ((1 << (X86_FEATURE_RETPOLINE & 31)) | \
- (1 << (X86_FEATURE_RETPOLINE_LFENCE & 31)) | \
- (1 << (X86_FEATURE_RETHUNK & 31)) | \
- (1 << (X86_FEATURE_UNRET & 31)))
+ (1 << (X86_FEATURE_RETPOLINE_LFENCE & 31)))
+#endif
+
+#ifdef CONFIG_RETHUNK
+# define DISABLE_RETHUNK 0
+#else
+# define DISABLE_RETHUNK (1 << (X86_FEATURE_RETHUNK & 31))
+#endif
+
+#ifdef CONFIG_CPU_UNRET_ENTRY
+# define DISABLE_UNRET 0
+#else
+# define DISABLE_UNRET (1 << (X86_FEATURE_UNRET & 31))
#endif
/* Force disable because it's broken beyond repair */
@@ -82,7 +92,7 @@
#define DISABLED_MASK8 0
#define DISABLED_MASK9 (DISABLE_SMAP)
#define DISABLED_MASK10 0
-#define DISABLED_MASK11 (DISABLE_RETPOLINE)
+#define DISABLED_MASK11 (DISABLE_RETPOLINE|DISABLE_RETHUNK|DISABLE_UNRET)
#define DISABLED_MASK12 0
#define DISABLED_MASK13 0
#define DISABLED_MASK14 0
--- a/arch/x86/include/asm/linkage.h
+++ b/arch/x86/include/asm/linkage.h
@@ -18,7 +18,7 @@
#define __ALIGN_STR __stringify(__ALIGN)
#endif
-#if defined(CONFIG_RETPOLINE) && !defined(__DISABLE_EXPORTS) && !defined(BUILD_VDSO)
+#if defined(CONFIG_RETHUNK) && !defined(__DISABLE_EXPORTS) && !defined(BUILD_VDSO)
#define RET jmp __x86_return_thunk
#else /* CONFIG_RETPOLINE */
#ifdef CONFIG_SLS
@@ -30,7 +30,7 @@
#else /* __ASSEMBLY__ */
-#if defined(CONFIG_RETPOLINE) && !defined(__DISABLE_EXPORTS) && !defined(BUILD_VDSO)
+#if defined(CONFIG_RETHUNK) && !defined(__DISABLE_EXPORTS) && !defined(BUILD_VDSO)
#define ASM_RET "jmp __x86_return_thunk\n\t"
#else /* CONFIG_RETPOLINE */
#ifdef CONFIG_SLS
--- a/arch/x86/include/asm/nospec-branch.h
+++ b/arch/x86/include/asm/nospec-branch.h
@@ -127,6 +127,12 @@
.Lskip_rsb_\@:
.endm
+#ifdef CONFIG_CPU_UNRET_ENTRY
+#define CALL_ZEN_UNTRAIN_RET "call zen_untrain_ret"
+#else
+#define CALL_ZEN_UNTRAIN_RET ""
+#endif
+
/*
* Mitigate RETBleed for AMD/Hygon Zen uarch. Requires KERNEL CR3 because the
* return thunk isn't mapped into the userspace tables (then again, AMD
@@ -139,10 +145,10 @@
* where we have a stack but before any RET instruction.
*/
.macro UNTRAIN_RET
-#ifdef CONFIG_RETPOLINE
+#if defined(CONFIG_CPU_UNRET_ENTRY) || defined(CONFIG_CPU_IBPB_ENTRY)
ANNOTATE_UNRET_END
ALTERNATIVE_2 "", \
- "call zen_untrain_ret", X86_FEATURE_UNRET, \
+ CALL_ZEN_UNTRAIN_RET, X86_FEATURE_UNRET, \
"call entry_ibpb", X86_FEATURE_ENTRY_IBPB
#endif
.endm
--- a/arch/x86/include/asm/static_call.h
+++ b/arch/x86/include/asm/static_call.h
@@ -44,7 +44,7 @@
#define ARCH_DEFINE_STATIC_CALL_TRAMP(name, func) \
__ARCH_DEFINE_STATIC_CALL_TRAMP(name, ".byte 0xe9; .long " #func " - (. + 4)")
-#ifdef CONFIG_RETPOLINE
+#ifdef CONFIG_RETHUNK
#define ARCH_DEFINE_STATIC_CALL_NULL_TRAMP(name) \
__ARCH_DEFINE_STATIC_CALL_TRAMP(name, "jmp __x86_return_thunk")
#else
--- a/arch/x86/kernel/alternative.c
+++ b/arch/x86/kernel/alternative.c
@@ -662,6 +662,7 @@ void __init_or_module noinline apply_ret
}
}
+#ifdef CONFIG_RETHUNK
/*
* Rewrite the compiler generated return thunk tail-calls.
*
@@ -723,6 +724,10 @@ void __init_or_module noinline apply_ret
}
}
}
+#else
+void __init_or_module noinline apply_returns(s32 *start, s32 *end) { }
+#endif /* CONFIG_RETHUNK */
+
#else /* !RETPOLINES || !CONFIG_STACK_VALIDATION */
void __init_or_module noinline apply_retpolines(s32 *start, s32 *end) { }
--- a/arch/x86/kernel/cpu/amd.c
+++ b/arch/x86/kernel/cpu/amd.c
@@ -916,6 +916,7 @@ static void init_amd_bd(struct cpuinfo_x
void init_spectral_chicken(struct cpuinfo_x86 *c)
{
+#ifdef CONFIG_CPU_UNRET_ENTRY
u64 value;
/*
@@ -932,6 +933,7 @@ void init_spectral_chicken(struct cpuinf
wrmsrl_safe(MSR_ZEN2_SPECTRAL_CHICKEN, value);
}
}
+#endif
}
static void init_amd_zn(struct cpuinfo_x86 *c)
--- a/arch/x86/kernel/cpu/bugs.c
+++ b/arch/x86/kernel/cpu/bugs.c
@@ -798,7 +798,6 @@ static int __init retbleed_parse_cmdline
early_param("retbleed", retbleed_parse_cmdline);
#define RETBLEED_UNTRAIN_MSG "WARNING: BTB untrained return thunk mitigation is only effective on AMD/Hygon!\n"
-#define RETBLEED_COMPILER_MSG "WARNING: kernel not compiled with RETPOLINE or -mfunction-return capable compiler; falling back to IBPB!\n"
#define RETBLEED_INTEL_MSG "WARNING: Spectre v2 mitigation leaves CPU vulnerable to RETBleed attacks, data leaks possible!\n"
static void __init retbleed_select_mitigation(void)
@@ -813,18 +812,33 @@ static void __init retbleed_select_mitig
return;
case RETBLEED_CMD_UNRET:
- retbleed_mitigation = RETBLEED_MITIGATION_UNRET;
+ if (IS_ENABLED(CONFIG_CPU_UNRET_ENTRY)) {
+ retbleed_mitigation = RETBLEED_MITIGATION_UNRET;
+ } else {
+ pr_err("WARNING: kernel not compiled with CPU_UNRET_ENTRY.\n");
+ goto do_cmd_auto;
+ }
break;
case RETBLEED_CMD_IBPB:
- retbleed_mitigation = RETBLEED_MITIGATION_IBPB;
+ if (IS_ENABLED(CONFIG_CPU_IBPB_ENTRY)) {
+ retbleed_mitigation = RETBLEED_MITIGATION_IBPB;
+ } else {
+ pr_err("WARNING: kernel not compiled with CPU_IBPB_ENTRY.\n");
+ goto do_cmd_auto;
+ }
break;
+do_cmd_auto:
case RETBLEED_CMD_AUTO:
default:
if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD ||
- boot_cpu_data.x86_vendor == X86_VENDOR_HYGON)
- retbleed_mitigation = RETBLEED_MITIGATION_UNRET;
+ boot_cpu_data.x86_vendor == X86_VENDOR_HYGON) {
+ if (IS_ENABLED(CONFIG_CPU_UNRET_ENTRY))
+ retbleed_mitigation = RETBLEED_MITIGATION_UNRET;
+ else if (IS_ENABLED(CONFIG_CPU_IBPB_ENTRY))
+ retbleed_mitigation = RETBLEED_MITIGATION_IBPB;
+ }
/*
* The Intel mitigation (IBRS or eIBRS) was already selected in
@@ -837,14 +851,6 @@ static void __init retbleed_select_mitig
switch (retbleed_mitigation) {
case RETBLEED_MITIGATION_UNRET:
-
- if (!IS_ENABLED(CONFIG_RETPOLINE) ||
- !IS_ENABLED(CONFIG_CC_HAS_RETURN_THUNK)) {
- pr_err(RETBLEED_COMPILER_MSG);
- retbleed_mitigation = RETBLEED_MITIGATION_IBPB;
- goto retbleed_force_ibpb;
- }
-
setup_force_cpu_cap(X86_FEATURE_RETHUNK);
setup_force_cpu_cap(X86_FEATURE_UNRET);
@@ -856,7 +862,6 @@ static void __init retbleed_select_mitig
break;
case RETBLEED_MITIGATION_IBPB:
-retbleed_force_ibpb:
setup_force_cpu_cap(X86_FEATURE_ENTRY_IBPB);
mitigate_smt = true;
break;
@@ -1227,6 +1232,12 @@ static enum spectre_v2_mitigation_cmd __
return SPECTRE_V2_CMD_AUTO;
}
+ if (cmd == SPECTRE_V2_CMD_IBRS && !IS_ENABLED(CONFIG_CPU_IBRS_ENTRY)) {
+ pr_err("%s selected but not compiled in. Switching to AUTO select\n",
+ mitigation_options[i].option);
+ return SPECTRE_V2_CMD_AUTO;
+ }
+
if (cmd == SPECTRE_V2_CMD_IBRS && boot_cpu_data.x86_vendor != X86_VENDOR_INTEL) {
pr_err("%s selected but not Intel CPU. Switching to AUTO select\n",
mitigation_options[i].option);
@@ -1284,7 +1295,8 @@ static void __init spectre_v2_select_mit
break;
}
- if (boot_cpu_has_bug(X86_BUG_RETBLEED) &&
+ if (IS_ENABLED(CONFIG_CPU_IBRS_ENTRY) &&
+ boot_cpu_has_bug(X86_BUG_RETBLEED) &&
retbleed_cmd != RETBLEED_CMD_OFF &&
boot_cpu_has(X86_FEATURE_IBRS) &&
boot_cpu_data.x86_vendor == X86_VENDOR_INTEL) {
--- a/arch/x86/kernel/static_call.c
+++ b/arch/x86/kernel/static_call.c
@@ -108,7 +108,7 @@ void arch_static_call_transform(void *si
}
EXPORT_SYMBOL_GPL(arch_static_call_transform);
-#ifdef CONFIG_RETPOLINE
+#ifdef CONFIG_RETHUNK
/*
* This is called by apply_returns() to fix up static call trampolines,
* specifically ARCH_DEFINE_STATIC_CALL_NULL_TRAMP which is recorded as
--- a/arch/x86/kvm/emulate.c
+++ b/arch/x86/kvm/emulate.c
@@ -435,10 +435,10 @@ static int fastop(struct x86_emulate_ctx
* Depending on .config the SETcc functions look like:
*
* SETcc %al [3 bytes]
- * RET | JMP __x86_return_thunk [1,5 bytes; CONFIG_RETPOLINE]
+ * RET | JMP __x86_return_thunk [1,5 bytes; CONFIG_RETHUNK]
* INT3 [1 byte; CONFIG_SLS]
*/
-#define RET_LENGTH (1 + (4 * IS_ENABLED(CONFIG_RETPOLINE)) + \
+#define RET_LENGTH (1 + (4 * IS_ENABLED(CONFIG_RETHUNK)) + \
IS_ENABLED(CONFIG_SLS))
#define SETCC_LENGTH (3 + RET_LENGTH)
#define SETCC_ALIGN (4 << ((SETCC_LENGTH > 4) & 1) << ((SETCC_LENGTH > 8) & 1))
--- a/arch/x86/lib/retpoline.S
+++ b/arch/x86/lib/retpoline.S
@@ -71,6 +71,8 @@ SYM_CODE_END(__x86_indirect_thunk_array)
* This function name is magical and is used by -mfunction-return=thunk-extern
* for the compiler to generate JMPs to it.
*/
+#ifdef CONFIG_RETHUNK
+
.section .text.__x86.return_thunk
/*
@@ -135,3 +137,5 @@ SYM_FUNC_END(zen_untrain_ret)
__EXPORT_THUNK(zen_untrain_ret)
EXPORT_SYMBOL(__x86_return_thunk)
+
+#endif /* CONFIG_RETHUNK */
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -227,6 +227,9 @@ endif
ifdef CONFIG_RETPOLINE
objtool_args += --retpoline
endif
+ifdef CONFIG_RETHUNK
+ objtool_args += --rethunk
+endif
ifdef CONFIG_X86_SMAP
objtool_args += --uaccess
endif
--- a/scripts/link-vmlinux.sh
+++ b/scripts/link-vmlinux.sh
@@ -65,7 +65,7 @@ objtool_link()
if [ -n "${CONFIG_VMLINUX_VALIDATION}" ]; then
objtoolopt="check"
- if [ -n "${CONFIG_RETPOLINE}" ]; then
+ if [ -n "${CONFIG_CPU_UNRET_ENTRY}" ]; then
objtoolopt="${objtoolopt} --unret"
fi
if [ -z "${CONFIG_FRAME_POINTER}" ]; then
--- a/security/Kconfig
+++ b/security/Kconfig
@@ -54,17 +54,6 @@ config SECURITY_NETWORK
implement socket and networking access controls.
If you are unsure how to answer this question, answer N.
-config PAGE_TABLE_ISOLATION
- bool "Remove the kernel mapping in user mode"
- default y
- depends on (X86_64 || X86_PAE) && !UML
- help
- This feature reduces the number of hardware side channels by
- ensuring that the majority of kernel addresses are not mapped
- into userspace.
-
- See Documentation/x86/pti.rst for more details.
-
config SECURITY_INFINIBAND
bool "Infiniband Security Hooks"
depends on SECURITY && INFINIBAND
--- a/tools/objtool/builtin-check.c
+++ b/tools/objtool/builtin-check.c
@@ -19,7 +19,7 @@
#include "objtool.h"
bool no_fp, no_unreachable, retpoline, module, backtrace, uaccess, stats,
- validate_dup, vmlinux, sls, unret;
+ validate_dup, vmlinux, sls, unret, rethunk;
static const char * const check_usage[] = {
"objtool check [<options>] file.o",
@@ -30,6 +30,7 @@ const struct option check_options[] = {
OPT_BOOLEAN('f', "no-fp", &no_fp, "Skip frame pointer validation"),
OPT_BOOLEAN('u', "no-unreachable", &no_unreachable, "Skip 'unreachable instruction' warnings"),
OPT_BOOLEAN('r', "retpoline", &retpoline, "Validate retpoline assumptions"),
+ OPT_BOOLEAN(0, "rethunk", &rethunk, "validate and annotate rethunk usage"),
OPT_BOOLEAN(0, "unret", &unret, "validate entry unret placement"),
OPT_BOOLEAN('m', "module", &module, "Indicates the object will be part of a kernel module"),
OPT_BOOLEAN('b', "backtrace", &backtrace, "unwind on error"),
--- a/tools/objtool/builtin.h
+++ b/tools/objtool/builtin.h
@@ -9,7 +9,7 @@
extern const struct option check_options[];
extern bool no_fp, no_unreachable, retpoline, module, backtrace, uaccess, stats,
- validate_dup, vmlinux, sls, unret;
+ validate_dup, vmlinux, sls, unret, rethunk;
extern int cmd_check(int argc, const char **argv);
extern int cmd_orc(int argc, const char **argv);
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -3262,8 +3262,11 @@ static int validate_retpoline(struct obj
continue;
if (insn->type == INSN_RETURN) {
- WARN_FUNC("'naked' return found in RETPOLINE build",
- insn->sec, insn->offset);
+ if (rethunk) {
+ WARN_FUNC("'naked' return found in RETHUNK build",
+ insn->sec, insn->offset);
+ } else
+ continue;
} else {
WARN_FUNC("indirect %s found in RETPOLINE build",
insn->sec, insn->offset,
@@ -3533,7 +3536,9 @@ int check(struct objtool_file *file)
if (ret < 0)
goto out;
warnings += ret;
+ }
+ if (rethunk) {
ret = create_return_sites_sections(file);
if (ret < 0)
goto out;
next prev parent reply other threads:[~2022-07-23 10:10 UTC|newest]
Thread overview: 156+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-23 9:53 [PATCH 5.10 000/148] 5.10.133-rc1 review Greg Kroah-Hartman
2022-07-23 9:53 ` [PATCH 5.10 001/148] KVM/VMX: Use TEST %REG,%REG instead of CMP $0,%REG in vmenter.S Greg Kroah-Hartman
2022-07-23 9:53 ` [PATCH 5.10 002/148] KVM/nVMX: Use __vmx_vcpu_run in nested_vmx_check_vmentry_hw Greg Kroah-Hartman
2022-07-23 9:53 ` [PATCH 5.10 003/148] objtool: Refactor ORC section generation Greg Kroah-Hartman
2022-07-23 9:53 ` [PATCH 5.10 004/148] objtool: Add alt_group struct Greg Kroah-Hartman
2022-07-23 9:53 ` [PATCH 5.10 005/148] objtool: Support stack layout changes in alternatives Greg Kroah-Hartman
2022-07-23 9:53 ` [PATCH 5.10 006/148] objtool: Support retpoline jump detection for vmlinux.o Greg Kroah-Hartman
2022-07-23 9:53 ` [PATCH 5.10 007/148] objtool: Assume only ELF functions do sibling calls Greg Kroah-Hartman
2022-07-23 9:53 ` [PATCH 5.10 008/148] objtool: Combine UNWIND_HINT_RET_OFFSET and UNWIND_HINT_FUNC Greg Kroah-Hartman
2022-07-23 9:53 ` [PATCH 5.10 009/148] x86/xen: Support objtool validation in xen-asm.S Greg Kroah-Hartman
2022-07-23 9:53 ` [PATCH 5.10 010/148] x86/xen: Support objtool vmlinux.o validation in xen-head.S Greg Kroah-Hartman
2022-07-23 9:53 ` [PATCH 5.10 011/148] x86/alternative: Merge include files Greg Kroah-Hartman
2022-07-23 9:53 ` [PATCH 5.10 012/148] x86/alternative: Support not-feature Greg Kroah-Hartman
2022-07-23 9:53 ` [PATCH 5.10 013/148] x86/alternative: Support ALTERNATIVE_TERNARY Greg Kroah-Hartman
2022-07-23 9:53 ` [PATCH 5.10 014/148] x86/alternative: Use ALTERNATIVE_TERNARY() in _static_cpu_has() Greg Kroah-Hartman
2022-07-23 9:53 ` [PATCH 5.10 015/148] x86/insn: Rename insn_decode() to insn_decode_from_regs() Greg Kroah-Hartman
2022-07-23 9:53 ` [PATCH 5.10 016/148] x86/insn: Add a __ignore_sync_check__ marker Greg Kroah-Hartman
2022-07-23 9:53 ` [PATCH 5.10 017/148] x86/insn: Add an insn_decode() API Greg Kroah-Hartman
2022-07-23 9:53 ` [PATCH 5.10 018/148] x86/insn-eval: Handle return values from the decoder Greg Kroah-Hartman
2022-07-23 9:53 ` [PATCH 5.10 019/148] x86/alternative: Use insn_decode() Greg Kroah-Hartman
2022-07-23 9:53 ` [PATCH 5.10 020/148] x86: Add insn_decode_kernel() Greg Kroah-Hartman
2022-07-23 9:53 ` [PATCH 5.10 021/148] x86/alternatives: Optimize optimize_nops() Greg Kroah-Hartman
2022-07-23 9:53 ` [PATCH 5.10 022/148] x86/retpoline: Simplify retpolines Greg Kroah-Hartman
2022-07-23 9:53 ` [PATCH 5.10 023/148] objtool: Correctly handle retpoline thunk calls Greg Kroah-Hartman
2022-07-23 9:53 ` [PATCH 5.10 024/148] objtool: Handle per arch retpoline naming Greg Kroah-Hartman
2022-07-23 9:53 ` [PATCH 5.10 025/148] objtool: Rework the elf_rebuild_reloc_section() logic Greg Kroah-Hartman
2022-07-23 9:53 ` [PATCH 5.10 026/148] objtool: Add elf_create_reloc() helper Greg Kroah-Hartman
2022-07-23 9:53 ` [PATCH 5.10 027/148] objtool: Create reloc sections implicitly Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 028/148] objtool: Extract elf_strtab_concat() Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 029/148] objtool: Extract elf_symbol_add() Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 030/148] objtool: Add elf_create_undef_symbol() Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 031/148] objtool: Keep track of retpoline call sites Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 032/148] objtool: Cache instruction relocs Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 033/148] objtool: Skip magical retpoline .altinstr_replacement Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 034/148] objtool/x86: Rewrite retpoline thunk calls Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 035/148] objtool: Support asm jump tables Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 036/148] x86/alternative: Optimize single-byte NOPs at an arbitrary position Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 037/148] objtool: Fix .symtab_shndx handling for elf_create_undef_symbol() Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 038/148] objtool: Only rewrite unconditional retpoline thunk calls Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 039/148] objtool/x86: Ignore __x86_indirect_alt_* symbols Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 040/148] objtool: Dont make .altinstructions writable Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 041/148] objtool: Teach get_alt_entry() about more relocation types Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 042/148] objtool: print out the symbol type when complaining about it Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 043/148] objtool: Remove reloc symbol type checks in get_alt_entry() Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 044/148] objtool: Make .altinstructions section entry size consistent Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 045/148] objtool: Introduce CFI hash Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 046/148] objtool: Handle __sanitize_cov*() tail calls Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 047/148] objtool: Classify symbols Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 048/148] objtool: Explicitly avoid self modifying code in .altinstr_replacement Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 049/148] objtool,x86: Replace alternatives with .retpoline_sites Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 050/148] x86/retpoline: Remove unused replacement symbols Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 051/148] x86/asm: Fix register order Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 052/148] x86/asm: Fixup odd GEN-for-each-reg.h usage Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 053/148] x86/retpoline: Move the retpoline thunk declarations to nospec-branch.h Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 054/148] x86/retpoline: Create a retpoline thunk array Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 055/148] x86/alternative: Implement .retpoline_sites support Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 056/148] x86/alternative: Handle Jcc __x86_indirect_thunk_\reg Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 057/148] x86/alternative: Try inline spectre_v2=retpoline,amd Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 058/148] x86/alternative: Add debug prints to apply_retpolines() Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 059/148] bpf,x86: Simplify computing label offsets Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 060/148] bpf,x86: Respect X86_FEATURE_RETPOLINE* Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 061/148] x86/lib/atomic64_386_32: Rename things Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 062/148] x86: Prepare asm files for straight-line-speculation Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 063/148] x86: Prepare inline-asm " Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 064/148] x86/alternative: Relax text_poke_bp() constraint Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 065/148] objtool: Add straight-line-speculation validation Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 066/148] x86: Add straight-line-speculation mitigation Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 067/148] tools arch: Update arch/x86/lib/mem{cpy,set}_64.S copies used in perf bench mem memcpy Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 068/148] kvm/emulate: Fix SETcc emulation function offsets with SLS Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 069/148] objtool: Default ignore INT3 for unreachable Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 070/148] crypto: x86/poly1305 - Fixup SLS Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 071/148] objtool: Fix SLS validation for kcov tail-call replacement Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 072/148] objtool: Fix code relocs vs weak symbols Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 073/148] objtool: Fix type of reloc::addend Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 074/148] objtool: Fix symbol creation Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 075/148] x86/entry: Remove skip_r11rcx Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 076/148] objtool: Fix objtool regression on x32 systems Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 077/148] x86/realmode: build with -D__DISABLE_EXPORTS Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 078/148] x86/kvm/vmx: Make noinstr clean Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 079/148] x86/cpufeatures: Move RETPOLINE flags to word 11 Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 080/148] x86/retpoline: Cleanup some #ifdefery Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 081/148] x86/retpoline: Swizzle retpoline thunk Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 082/148] Makefile: Set retpoline cflags based on CONFIG_CC_IS_{CLANG,GCC} Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 083/148] x86/retpoline: Use -mfunction-return Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 084/148] x86: Undo return-thunk damage Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 085/148] x86,objtool: Create .return_sites Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 086/148] objtool: skip non-text sections when adding return-thunk sites Greg Kroah-Hartman
2022-07-23 9:54 ` [PATCH 5.10 087/148] x86,static_call: Use alternative RET encoding Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 088/148] x86/ftrace: " Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 089/148] x86/bpf: " Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 090/148] x86/kvm: Fix SETcc emulation for return thunks Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 091/148] x86/vsyscall_emu/64: Dont use RET in vsyscall emulation Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 092/148] x86/sev: Avoid using __x86_return_thunk Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 093/148] x86: Use return-thunk in asm code Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 094/148] objtool: Treat .text.__x86.* as noinstr Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 095/148] x86: Add magic AMD return-thunk Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 096/148] x86/bugs: Report AMD retbleed vulnerability Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 097/148] x86/bugs: Add AMD retbleed= boot parameter Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 098/148] x86/bugs: Enable STIBP for JMP2RET Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 099/148] x86/bugs: Keep a per-CPU IA32_SPEC_CTRL value Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 100/148] x86/entry: Add kernel IBRS implementation Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 101/148] x86/bugs: Optimize SPEC_CTRL MSR writes Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 102/148] x86/speculation: Add spectre_v2=ibrs option to support Kernel IBRS Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 103/148] x86/bugs: Split spectre_v2_select_mitigation() and spectre_v2_user_select_mitigation() Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 104/148] x86/bugs: Report Intel retbleed vulnerability Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 105/148] intel_idle: Disable IBRS during long idle Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 106/148] objtool: Update Retpoline validation Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 107/148] x86/xen: Rename SYS* entry points Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 108/148] x86/bugs: Add retbleed=ibpb Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 109/148] x86/bugs: Do IBPB fallback check only once Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 110/148] objtool: Add entry UNRET validation Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 111/148] x86/cpu/amd: Add Spectral Chicken Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 112/148] x86/speculation: Fix RSB filling with CONFIG_RETPOLINE=n Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 113/148] x86/speculation: Fix firmware entry SPEC_CTRL handling Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 114/148] x86/speculation: Fix SPEC_CTRL write on SMT state change Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 115/148] x86/speculation: Use cached host SPEC_CTRL value for guest entry/exit Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 116/148] x86/speculation: Remove x86_spec_ctrl_mask Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 117/148] objtool: Re-add UNWIND_HINT_{SAVE_RESTORE} Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 118/148] KVM: VMX: Flatten __vmx_vcpu_run() Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 119/148] KVM: VMX: Convert launched argument to flags Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 120/148] KVM: VMX: Prevent guest RSB poisoning attacks with eIBRS Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 121/148] KVM: VMX: Fix IBRS handling after vmexit Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 122/148] x86/speculation: Fill RSB on vmexit for IBRS Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 123/148] x86/common: Stamp out the stepping madness Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 124/148] x86/cpu/amd: Enumerate BTC_NO Greg Kroah-Hartman
2022-07-23 9:55 ` Greg Kroah-Hartman [this message]
2022-07-23 9:55 ` [PATCH 5.10 126/148] x86/bugs: Add Cannon lake to RETBleed affected CPU list Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 127/148] x86/bugs: Do not enable IBPB-on-entry when IBPB is not supported Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 128/148] x86/kexec: Disable RET on kexec Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 129/148] x86/speculation: Disable RRSBA behavior Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 130/148] x86/static_call: Serialize __static_call_fixup() properly Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 131/148] tools/insn: Restore the relative include paths for cross building Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 132/148] x86, kvm: use proper ASM macros for kvm_vcpu_is_preempted Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 133/148] x86/xen: Fix initialisation in hypercall_page after rethunk Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 134/148] x86/ftrace: Add UNWIND_HINT_FUNC annotation for ftrace_stub Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 135/148] x86/asm/32: Fix ANNOTATE_UNRET_SAFE use on 32-bit Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 136/148] x86/speculation: Use DECLARE_PER_CPU for x86_spec_ctrl_current Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 137/148] efi/x86: use naked RET on mixed mode call wrapper Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 138/148] x86/kvm: fix FASTOP_SIZE when return thunks are enabled Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 139/148] KVM: emulate: do not adjust size of fastop and setcc subroutines Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 140/148] tools arch x86: Sync the msr-index.h copy with the kernel sources Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 141/148] tools headers cpufeatures: Sync " Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 142/148] x86/bugs: Remove apostrophe typo Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 143/148] um: Add missing apply_returns() Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 144/148] x86: Use -mindirect-branch-cs-prefix for RETPOLINE builds Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 145/148] kvm: fix objtool relocation warning Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 146/148] objtool: Fix elf_create_undef_symbol() endianness Greg Kroah-Hartman
2022-07-23 9:55 ` [PATCH 5.10 147/148] tools arch: Update arch/x86/lib/mem{cpy,set}_64.S copies used in perf bench mem memcpy - again Greg Kroah-Hartman
2022-07-23 9:56 ` [PATCH 5.10 148/148] tools headers: Remove broken definition of __LITTLE_ENDIAN Greg Kroah-Hartman
2022-07-23 14:12 ` [PATCH 5.10 000/148] 5.10.133-rc1 review Guenter Roeck
2022-07-23 18:03 ` Daniel Díaz
2022-07-24 4:49 ` Rudi Heitbaum
2022-07-24 8:06 ` Sudip Mukherjee (Codethink)
2022-07-25 8:03 ` Jon Hunter
2022-07-25 10:19 ` Pavel Machek
2022-07-25 17:15 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220723095259.304261366@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=ben@decadent.org.uk \
--cc=bp@suse.de \
--cc=cascardo@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).