public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexander Grund <theflamefire89@gmail.com>
To: stable@vger.kernel.org
Cc: bauen1 <j2468h@googlemail.com>,
	Alexander Grund <theflamefire89@gmail.com>
Subject: [PATCH 4.9 1/1] selinux: allow dontauditx and auditallowx rules to take effect without allowx
Date: Mon,  8 Aug 2022 12:20:49 +0200	[thread overview]
Message-ID: <20220808102049.46386-2-theflamefire89@gmail.com> (raw)
In-Reply-To: <20220808102049.46386-1-theflamefire89@gmail.com>

From: bauen1 <j2468h@googlemail.com>

commit 44141f58e14317853698f994ca5c3785a0c230d0 upstream.

This allows for dontauditing very specific ioctls e.g. TCGETS without
dontauditing every ioctl or granting additional permissions.

Now either an allowx, dontauditx or auditallowx rules enables checking
for extended permissions.

Signed-off-by: Jonathan Hettwer <j2468h@gmail.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: Alexander Grund <theflamefire89@gmail.com>
---
 security/selinux/ss/services.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c
index 6ca297821d459..c27c3ce76abbc 100644
--- a/security/selinux/ss/services.c
+++ b/security/selinux/ss/services.c
@@ -610,9 +610,7 @@ void services_compute_xperms_drivers(
 					node->datum.u.xperms->driver);
 	}
 
-	/* If no ioctl commands are allowed, ignore auditallow and auditdeny */
-	if (node->key.specified & AVTAB_XPERMS_ALLOWED)
-		xperms->len = 1;
+	xperms->len = 1;
 }
 
 /*
-- 
2.25.1


  reply	other threads:[~2022-08-08 10:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-08 10:20 [PATCH 4.9 0/1] selinux: allow dontauditx and auditallowx rules to take effect without allowx Alexander Grund
2022-08-08 10:20 ` Alexander Grund [this message]
2022-08-08 13:30 ` Greg KH
2022-08-11  9:20   ` Alexander Grund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220808102049.46386-2-theflamefire89@gmail.com \
    --to=theflamefire89@gmail.com \
    --cc=j2468h@googlemail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox