public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Tzung-Bi Shih <tzungbi@kernel.org>,
	Guenter Roeck <groeck@chromium.org>,
	Sasha Levin <sashal@kernel.org>,
	bleung@chromium.org, chrome-platform@lists.linux.dev
Subject: [PATCH AUTOSEL 5.15 03/46] platform/chrome: cros_ec_proto: don't show MKBP version if unsupported
Date: Sun, 14 Aug 2022 11:32:04 -0400	[thread overview]
Message-ID: <20220814153247.2378312-3-sashal@kernel.org> (raw)
In-Reply-To: <20220814153247.2378312-1-sashal@kernel.org>

From: Tzung-Bi Shih <tzungbi@kernel.org>

[ Upstream commit b36f0643ff14a2fb281b105418e4e73c9d7c11d0 ]

It wrongly showed the following message when it doesn't support MKBP:
"MKBP support version 4294967295".

Fix it.

Reviewed-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
Link: https://lore.kernel.org/r/20220609084957.3684698-14-tzungbi@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/platform/chrome/cros_ec_proto.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c
index ed2b4807328d..1575d603d3ff 100644
--- a/drivers/platform/chrome/cros_ec_proto.c
+++ b/drivers/platform/chrome/cros_ec_proto.c
@@ -507,13 +507,13 @@ int cros_ec_query_all(struct cros_ec_device *ec_dev)
 	ret = cros_ec_get_host_command_version_mask(ec_dev,
 						    EC_CMD_GET_NEXT_EVENT,
 						    &ver_mask);
-	if (ret < 0 || ver_mask == 0)
+	if (ret < 0 || ver_mask == 0) {
 		ec_dev->mkbp_event_supported = 0;
-	else
+	} else {
 		ec_dev->mkbp_event_supported = fls(ver_mask);
 
-	dev_dbg(ec_dev->dev, "MKBP support version %u\n",
-		ec_dev->mkbp_event_supported - 1);
+		dev_dbg(ec_dev->dev, "MKBP support version %u\n", ec_dev->mkbp_event_supported - 1);
+	}
 
 	/* Probe if host sleep v1 is supported for S0ix failure detection. */
 	ret = cros_ec_get_host_command_version_mask(ec_dev,
-- 
2.35.1


  parent reply	other threads:[~2022-08-14 15:42 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-14 15:32 [PATCH AUTOSEL 5.15 01/46] HID: multitouch: new device class fix Lenovo X12 trackpad sticky Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 02/46] PCI: Add ACS quirk for Broadcom BCM5750x NICs Sasha Levin
2022-08-14 15:32 ` Sasha Levin [this message]
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 04/46] usb: cdns3 fix use-after-free at workaround 2 Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 05/46] usb: cdns3: fix random warning message when driver load Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 06/46] usb: gadget: uvc: calculate the number of request depending on framesize Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 07/46] usb: gadget: uvc: call uvc uvcg_warn on completed status instead of uvcg_info Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 08/46] PCI: aardvark: Fix reporting Slot capabilities on emulated bridge Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 09/46] irqchip/tegra: Fix overflow implicit truncation warnings Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 10/46] drm/meson: " Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 11/46] clk: ti: Stop using legacy clkctrl names for omap4 and 5 Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 12/46] scsi: ufs: ufs-mediatek: Fix the timing of configuring device regulators Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 13/46] usb: host: ohci-ppc-of: Fix refcount leak bug Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 14/46] usb: renesas: " Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 15/46] usb: dwc2: gadget: remove D+ pull-up while no vbus with usb-role-switch Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 16/46] vboxguest: Do not use devm for irq Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 17/46] clk: qcom: ipq8074: dont disable gcc_sleep_clk_src Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 18/46] uacce: Handle parent device removal or parent driver module rmmod Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 19/46] zram: do not lookup algorithm in backends table Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 20/46] clk: qcom: clk-alpha-pll: fix clk_trion_pll_configure description Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 21/46] scsi: lpfc: Prevent buffer overflow crashes in debugfs with malformed user input Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 22/46] scsi: lpfc: Fix possible memory leak when failing to issue CMF WQE Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 23/46] gadgetfs: ep_io - wait until IRQ finishes Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 24/46] coresight: etm4x: avoid build failure with unrolled loops Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 25/46] habanalabs/gaudi: fix shift out of bounds Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 26/46] habanalabs/gaudi: mask constant value before cast Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 27/46] mmc: tmio: avoid glitches when resetting Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 28/46] pinctrl: intel: Check against matching data instead of ACPI companion Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 29/46] cxl: Fix a memory leak in an error handling path Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 30/46] PCI/ACPI: Guard ARM64-specific mcfg_quirks Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 31/46] um: add "noreboot" command line option for PANIC_TIMEOUT=-1 setups Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 32/46] dmaengine: dw-axi-dmac: do not print NULL LLI during error Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 33/46] dmaengine: dw-axi-dmac: ignore interrupt if no descriptor Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 34/46] RDMA/rxe: Limit the number of calls to each tasklet Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 35/46] csky/kprobe: reclaim insn_slot on kprobe unregistration Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 36/46] selftests/kprobe: Do not test for GRP/ without event failures Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 37/46] dmaengine: sprd: Cleanup in .remove() after pm_runtime_get_sync() failed Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 38/46] ARM: 9202/1: kasan: support CONFIG_KASAN_VMALLOC Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 39/46] ARM: 9203/1: kconfig: fix MODULE_PLTS for KASAN with KASAN_VMALLOC Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 40/46] openrisc: io: Define iounmap argument as volatile Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 41/46] phy: samsung: phy-exynos-pcie: sanitize init/power_on callbacks Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 42/46] md: Notify sysfs sync_completed in md_reap_sync_thread() Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 43/46] nvmet-tcp: fix lockdep complaint on nvmet_tcp_wq flush during queue teardown Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 44/46] drivers:md:fix a potential use-after-free bug Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 45/46] ext4: avoid remove directory when directory is corrupted Sasha Levin
2022-08-14 15:32 ` [PATCH AUTOSEL 5.15 46/46] ext4: avoid resizing to a partial cluster size Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220814153247.2378312-3-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=groeck@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tzungbi@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox