From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Jozef Martiniak <jomajm@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sasha Levin <sashal@kernel.org>,
balbi@kernel.org, stern@rowland.harvard.edu, hbh25y@gmail.com,
axboe@kernel.dk, ira.weiny@intel.com, rdunlap@infradead.org,
mingo@kernel.org, linux-usb@vger.kernel.org
Subject: [PATCH AUTOSEL 5.10 17/31] gadgetfs: ep_io - wait until IRQ finishes
Date: Sun, 14 Aug 2022 11:34:17 -0400 [thread overview]
Message-ID: <20220814153431.2379231-17-sashal@kernel.org> (raw)
In-Reply-To: <20220814153431.2379231-1-sashal@kernel.org>
From: Jozef Martiniak <jomajm@gmail.com>
[ Upstream commit 04cb742d4d8f30dc2e83b46ac317eec09191c68e ]
after usb_ep_queue() if wait_for_completion_interruptible() is
interrupted we need to wait until IRQ gets finished.
Otherwise complete() from epio_complete() can corrupt stack.
Signed-off-by: Jozef Martiniak <jomajm@gmail.com>
Link: https://lore.kernel.org/r/20220708070645.6130-1-jomajm@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/usb/gadget/legacy/inode.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/legacy/inode.c b/drivers/usb/gadget/legacy/inode.c
index 454860d52ce7..cd097474b6c3 100644
--- a/drivers/usb/gadget/legacy/inode.c
+++ b/drivers/usb/gadget/legacy/inode.c
@@ -362,6 +362,7 @@ ep_io (struct ep_data *epdata, void *buf, unsigned len)
spin_unlock_irq (&epdata->dev->lock);
DBG (epdata->dev, "endpoint gone\n");
+ wait_for_completion(&done);
epdata->status = -ENODEV;
}
}
--
2.35.1
next prev parent reply other threads:[~2022-08-14 15:47 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-14 15:34 [PATCH AUTOSEL 5.10 01/31] PCI: Add ACS quirk for Broadcom BCM5750x NICs Sasha Levin
2022-08-14 15:34 ` [PATCH AUTOSEL 5.10 02/31] platform/chrome: cros_ec_proto: don't show MKBP version if unsupported Sasha Levin
2022-08-14 15:34 ` [PATCH AUTOSEL 5.10 03/31] usb: cdns3 fix use-after-free at workaround 2 Sasha Levin
2022-08-14 15:34 ` [PATCH AUTOSEL 5.10 04/31] usb: gadget: uvc: call uvc uvcg_warn on completed status instead of uvcg_info Sasha Levin
2022-08-14 15:34 ` [PATCH AUTOSEL 5.10 05/31] irqchip/tegra: Fix overflow implicit truncation warnings Sasha Levin
2022-08-14 15:34 ` [PATCH AUTOSEL 5.10 06/31] drm/meson: " Sasha Levin
2022-08-14 15:34 ` [PATCH AUTOSEL 5.10 07/31] clk: ti: Stop using legacy clkctrl names for omap4 and 5 Sasha Levin
2022-08-14 15:34 ` [PATCH AUTOSEL 5.10 08/31] usb: host: ohci-ppc-of: Fix refcount leak bug Sasha Levin
2022-08-14 15:34 ` [PATCH AUTOSEL 5.10 09/31] usb: renesas: " Sasha Levin
2022-08-14 15:34 ` [PATCH AUTOSEL 5.10 10/31] usb: dwc2: gadget: remove D+ pull-up while no vbus with usb-role-switch Sasha Levin
2022-08-14 15:34 ` [PATCH AUTOSEL 5.10 11/31] vboxguest: Do not use devm for irq Sasha Levin
2022-08-14 15:34 ` [PATCH AUTOSEL 5.10 12/31] clk: qcom: ipq8074: dont disable gcc_sleep_clk_src Sasha Levin
2022-08-14 15:34 ` [PATCH AUTOSEL 5.10 13/31] uacce: Handle parent device removal or parent driver module rmmod Sasha Levin
2022-08-14 15:34 ` [PATCH AUTOSEL 5.10 14/31] zram: do not lookup algorithm in backends table Sasha Levin
2022-08-14 15:34 ` [PATCH AUTOSEL 5.10 15/31] clk: qcom: clk-alpha-pll: fix clk_trion_pll_configure description Sasha Levin
2022-08-14 15:34 ` [PATCH AUTOSEL 5.10 16/31] scsi: lpfc: Prevent buffer overflow crashes in debugfs with malformed user input Sasha Levin
2022-08-14 15:34 ` Sasha Levin [this message]
2022-08-14 15:34 ` [PATCH AUTOSEL 5.10 18/31] pinctrl: intel: Check against matching data instead of ACPI companion Sasha Levin
2022-08-14 15:34 ` [PATCH AUTOSEL 5.10 19/31] cxl: Fix a memory leak in an error handling path Sasha Levin
2022-08-14 15:34 ` [PATCH AUTOSEL 5.10 20/31] PCI/ACPI: Guard ARM64-specific mcfg_quirks Sasha Levin
2022-08-14 15:34 ` [PATCH AUTOSEL 5.10 21/31] um: add "noreboot" command line option for PANIC_TIMEOUT=-1 setups Sasha Levin
2022-08-14 15:34 ` [PATCH AUTOSEL 5.10 22/31] RDMA/rxe: Limit the number of calls to each tasklet Sasha Levin
2022-08-14 15:34 ` [PATCH AUTOSEL 5.10 23/31] csky/kprobe: reclaim insn_slot on kprobe unregistration Sasha Levin
2022-08-14 15:34 ` [PATCH AUTOSEL 5.10 24/31] selftests/kprobe: Do not test for GRP/ without event failures Sasha Levin
2022-08-14 15:34 ` [PATCH AUTOSEL 5.10 25/31] dmaengine: sprd: Cleanup in .remove() after pm_runtime_get_sync() failed Sasha Levin
2022-08-14 15:34 ` [PATCH AUTOSEL 5.10 26/31] ARM: 9203/1: kconfig: fix MODULE_PLTS for KASAN with KASAN_VMALLOC Sasha Levin
2022-08-14 15:34 ` [PATCH AUTOSEL 5.10 27/31] md: Notify sysfs sync_completed in md_reap_sync_thread() Sasha Levin
2022-08-14 15:34 ` [PATCH AUTOSEL 5.10 28/31] nvmet-tcp: fix lockdep complaint on nvmet_tcp_wq flush during queue teardown Sasha Levin
2022-08-14 15:34 ` [PATCH AUTOSEL 5.10 29/31] drivers:md:fix a potential use-after-free bug Sasha Levin
2022-08-14 15:34 ` [PATCH AUTOSEL 5.10 30/31] ext4: avoid remove directory when directory is corrupted Sasha Levin
2022-08-14 15:34 ` [PATCH AUTOSEL 5.10 31/31] ext4: avoid resizing to a partial cluster size Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220814153431.2379231-17-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=axboe@kernel.dk \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hbh25y@gmail.com \
--cc=ira.weiny@intel.com \
--cc=jomajm@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rdunlap@infradead.org \
--cc=stable@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox