From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AB2AC28B2B for ; Sun, 14 Aug 2022 15:52:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242072AbiHNPwd (ORCPT ); Sun, 14 Aug 2022 11:52:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242039AbiHNPvF (ORCPT ); Sun, 14 Aug 2022 11:51:05 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B423317AB0; Sun, 14 Aug 2022 08:36:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4E4C4B80B56; Sun, 14 Aug 2022 15:36:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64526C43470; Sun, 14 Aug 2022 15:36:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660491402; bh=X32xtPBWcVE6Z6gxu3/jbMLK/pP7I1mcOKV4OxfaTWk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TBt1HThrz9JxiAAOe/IQBYrFVQTwjKS4GZt0ilyjIKRbXuG5moPVkZ5DIH1sElVR6 1wrXIGtMAIfr0psmvAL9stMM7tJSkHXKcZlDdWSLQeBHIRc85KBhLWakyw3wEJwdyo /TOTtukmUWkoRo9F0ki1rIrcWrYjS5LmVbV/ABKLaMe5LZHUgi6dNZdmQKNe+CWauI kJxVJD45fWj80QXNrWJibu1WpHuB83823yVJ4DRGed7jthpybjfa0W9mm2G1hH0lka 2cz9vr5cbdeVsLWYaLu7dStoGY04Hg0G4lnJLSLp+9TsOcgjKgP+wkf4t6br7fl3iE vvFkfqJlmLy+w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Liang He , Alan Stern , Greg Kroah-Hartman , Sasha Levin , linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 3/9] usb: host: ohci-ppc-of: Fix refcount leak bug Date: Sun, 14 Aug 2022 11:36:30 -0400 Message-Id: <20220814153637.2380406-3-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220814153637.2380406-1-sashal@kernel.org> References: <20220814153637.2380406-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Liang He [ Upstream commit 40a959d7042bb7711e404ad2318b30e9f92c6b9b ] In ohci_hcd_ppc_of_probe(), of_find_compatible_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore. Acked-by: Alan Stern Signed-off-by: Liang He Link: https://lore.kernel.org/r/20220617034637.4003115-1-windhl@126.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/host/ohci-ppc-of.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/ohci-ppc-of.c b/drivers/usb/host/ohci-ppc-of.c index 4f87a5c61b08..d22a70363fbf 100644 --- a/drivers/usb/host/ohci-ppc-of.c +++ b/drivers/usb/host/ohci-ppc-of.c @@ -168,6 +168,7 @@ static int ohci_hcd_ppc_of_probe(struct platform_device *op) release_mem_region(res.start, 0x4); } else pr_debug("%s: cannot get ehci offset from fdt\n", __FILE__); + of_node_put(np); } irq_dispose_mapping(irq); -- 2.35.1