From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43616C282E7 for ; Sun, 14 Aug 2022 15:52:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241762AbiHNPwN (ORCPT ); Sun, 14 Aug 2022 11:52:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242190AbiHNPvY (ORCPT ); Sun, 14 Aug 2022 11:51:24 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D1F71E3DE; Sun, 14 Aug 2022 08:37:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BD983B80B7C; Sun, 14 Aug 2022 15:37:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8FC7C433D6; Sun, 14 Aug 2022 15:37:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660491422; bh=WmoV+L1N+fDk24WcvLpFK8jLFwah7J6ezwwEFkIDOR4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rV7OGYV1T8SOVXFuz2ojBOan49Ul9U0jmjiPUYCeXsa0hc6Qa69UN5PsBz6BjJII7 /TGrp2gtnUPE5Lx8De+MnqQSQpnNnWS8CnzUNl5L5UewCPtnQ6W0dqOmgplZE4YG7X 4Csu6zlSJGlJ2Er21Iuhcx+mTgnyusZtNephuadyXXN4IVJx/LHy5IIlqM7bwgbxhR IgwDuZVeJMgr6nO6twpiBtwWmd/Oq8RRmgDtP9c4CmZORMxVCgqhp5eZpBScd+ec1W InugxWc4HcbUqwlOgEdC3oFCBCno+XIYqwExGRnr5MIXXysCnpSV82C4yG324MAmno 6yTUggomcrMTA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Wentao_Liang , Song Liu , Jens Axboe , Sasha Levin , linux-raid@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 5/7] drivers:md:fix a potential use-after-free bug Date: Sun, 14 Aug 2022 11:36:50 -0400 Message-Id: <20220814153652.2380549-5-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220814153652.2380549-1-sashal@kernel.org> References: <20220814153652.2380549-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Wentao_Liang [ Upstream commit 104212471b1c1817b311771d817fb692af983173 ] In line 2884, "raid5_release_stripe(sh);" drops the reference to sh and may cause sh to be released. However, sh is subsequently used in lines 2886 "if (sh->batch_head && sh != sh->batch_head)". This may result in an use-after-free bug. It can be fixed by moving "raid5_release_stripe(sh);" to the bottom of the function. Signed-off-by: Wentao_Liang Signed-off-by: Song Liu Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/md/raid5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index b396e78b1b6d..bea171a5e663 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c @@ -2513,10 +2513,10 @@ static void raid5_end_write_request(struct bio *bi) if (!test_and_clear_bit(R5_DOUBLE_LOCKED, &sh->dev[i].flags)) clear_bit(R5_LOCKED, &sh->dev[i].flags); set_bit(STRIPE_HANDLE, &sh->state); - raid5_release_stripe(sh); if (sh->batch_head && sh != sh->batch_head) raid5_release_stripe(sh->batch_head); + raid5_release_stripe(sh); } static void raid5_build_block(struct stripe_head *sh, int i, int previous) -- 2.35.1