From: Andrew Delgadilo <adelg@google.com>
To: Shuah Khan <shuah@kernel.org>, Andrew Delgadillo <adelg@google.com>
Cc: Christian Brauner <brauner@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: [PATCH] selftests: remove unused variable in close_range test
Date: Tue, 23 Aug 2022 22:48:11 +0000 [thread overview]
Message-ID: <20220823224811.12758-1-adelg@google.com> (raw)
From: Andrew Delgadillo <adelg@google.com>
commit 2c5db60e46ad ("tests: add close_range() tests") adds the
close_range test under the core namespace. In its current form, the
close_range test has an unused variable, namely, ret. For those building
with -Werror,-Wall, this breaks the build.
Without this patch:
$ make -C tools/testing/selftests/ TARGETS=core V=1 CFLAGS="-Werror -Wall"
> make: Entering directory '/.../kernel-src/tools/testing/selftests'
> make[1]: Entering directory '/.../kernel-src/tools/testing/selftests/core'
> gcc -Werror -Wall close_range_test.c -o /.../kernel-src/tools/testing/selftests/core/close_range_test
> close_range_test.c: In function 'core_close_range':
> close_range_test.c:55:16: error: unused variable 'ret' [-Werror=unused-variable]
> 55 | int i, ret;
> | ^~~
> cc1: all warnings being treated as errors
> make[1]: *** [../lib.mk:135: /.../kernel-src/tools/testing/selftests/core/close_range_test] Error 1
> make[1]: Leaving directory '/.../kernel-src/tools/testing/selftests/core'
> make: *** [Makefile:155: all] Error 2
> make: Leaving directory '/.../kernel-src/tools/testing/selftests'
With this patch:
$ make -C tools/testing/selftests/ TARGETS=core V=1 CFLAGS="-Werror -Wall"
> make: Entering directory '/.../kernel-src/tools/testing/selftests'
> make[1]: Entering directory '/.../kernel-src/tools/testing/selftests/core'
> gcc -Werror -Wall close_range_test.c -o /.../kernel-src/tools/testing/selftests/core/close_range_test
> make[1]: Leaving directory '/.../kernel-src/tools/testing/selftests/core'
> make: Leaving directory '/.../kernel-src/tools/testing/selftests'
Fixes: 2c5db60e46ad ("tests: add close_range() tests")
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Delgadillo <adelg@google.com>
---
tools/testing/selftests/core/close_range_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/core/close_range_test.c b/tools/testing/selftests/core/close_range_test.c
index 749239930ca83..17c76c6c13cb9 100644
--- a/tools/testing/selftests/core/close_range_test.c
+++ b/tools/testing/selftests/core/close_range_test.c
@@ -52,7 +52,7 @@ static inline int sys_close_range(unsigned int fd, unsigned int max_fd,
TEST(core_close_range)
{
- int i, ret;
+ int i;
int open_fds[101];
for (i = 0; i < ARRAY_SIZE(open_fds); i++) {
--
2.37.1.595.g718a3a8f04-goog
next reply other threads:[~2022-08-23 22:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 22:48 Andrew Delgadilo [this message]
2022-08-24 7:16 ` [PATCH] selftests: remove unused variable in close_range test Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220823224811.12758-1-adelg@google.com \
--to=adelg@google.com \
--cc=brauner@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox