[regression] build failure of smsc95xx since 5.15.61

[regression] build failure of smsc95xx since 5.15.61

[Urja Rannikko]

Hi,

Here's the relevant bit of the build log:
drivers/net/usb/smsc95xx.c: In function ‘smsc95xx_status’:
drivers/net/usb/smsc95xx.c:625:3: error: implicit declaration of
function ‘generic_handle_domain_irq’; did you mean
‘generic_handle_irq’? [-Werror
=implicit-function-declaration]
  625 |   generic_handle_domain_irq(pdata->irqdomain, PHY_HWIRQ);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~
      |   generic_handle_irq
drivers/net/usb/smsc95xx.c: In function ‘smsc95xx_bind’:
drivers/net/usb/smsc95xx.c:1136:21: error: implicit declaration of
function ‘irq_domain_alloc_named_fwnode’
[-Werror=implicit-function-declaration
]
 1136 |  pdata->irqfwnode = irq_domain_alloc_named_fwnode(usb_path);
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/usb/smsc95xx.c:1136:19: warning: assignment to ‘struct
fwnode_handle *’ from ‘int’ makes pointer from integer without a cast
[-Wint-co
nversion]
 1136 |  pdata->irqfwnode = irq_domain_alloc_named_fwnode(usb_path);
      |                   ^
drivers/net/usb/smsc95xx.c:1142:21: error: implicit declaration of
function ‘irq_domain_create_linear’
[-Werror=implicit-function-declaration]
 1142 |  pdata->irqdomain = irq_domain_create_linear(pdata->irqfwnode,
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/usb/smsc95xx.c:1144:12: error: ‘irq_domain_simple_ops’
undeclared (first use in this function); did you mean
‘irq_domain_ops’?
 1144 |           &irq_domain_simple_ops,
      |            ^~~~~~~~~~~~~~~~~~~~~
      |            irq_domain_ops
drivers/net/usb/smsc95xx.c:1144:12: note: each undeclared identifier
is reported only once for each function it appears in
drivers/net/usb/smsc95xx.c:1151:12: error: implicit declaration of
function ‘irq_create_mapping’; did you mean ‘irq_dispose_mapping’?
[-Werror=imp
licit-function-declaration]
 1151 |  phy_irq = irq_create_mapping(pdata->irqdomain, PHY_HWIRQ);
      |            ^~~~~~~~~~~~~~~~~~
      |            irq_dispose_mapping
drivers/net/usb/smsc95xx.c:1245:2: error: implicit declaration of
function ‘irq_domain_remove’ [-Werror=implicit-function-declaration]
 1245 |  irq_domain_remove(pdata->irqdomain);
      |  ^~~~~~~~~~~~~~~~~
drivers/net/usb/smsc95xx.c:1248:2: error: implicit declaration of
function ‘irq_domain_free_fwnode’; did you mean
‘irq_domain_get_of_node’? [-Werr
or=implicit-function-declaration]
 1248 |  irq_domain_free_fwnode(pdata->irqfwnode);
      |  ^~~~~~~~~~~~~~~~~~~~~~
      |  irq_domain_get_of_node
drivers/net/usb/smsc95xx.c: In function ‘smsc95xx_unbind’:
drivers/net/usb/smsc95xx.c:1262:22: error: implicit declaration of
function ‘irq_find_mapping’; did you mean ‘irq_dispose_mapping’?
[-Werror=impli
cit-function-declaration]
 1262 |  irq_dispose_mapping(irq_find_mapping(pdata->irqdomain, PHY_HWIRQ));
      |                      ^~~~~~~~~~~~~~~~
      |                      irq_dispose_mapping


The build is for 32-bit x86, the defconfig can be found here:
https://github.com/urjaman/i586con/blob/master/brext/board/linux.config

The build failure also happens with 5.15.62 and 63.

-- 
Urja Rannikko

Re: [regression] build failure of smsc95xx since 5.15.61

[Lukas Wunner]

On Fri, Aug 26, 2022 at 04:55:55PM +0300, Urja Rannikko wrote:
> Here's the relevant bit of the build log:
> drivers/net/usb/smsc95xx.c: In function "smsc95xx_status":
> drivers/net/usb/smsc95xx.c:625:3: error: implicit declaration of
> function "generic_handle_domain_irq"; did you mean
> "generic_handle_irq"? [-Werror=implicit-function-declaration]
[...]
> The build is for 32-bit x86, the defconfig can be found here:
> https://github.com/urjaman/i586con/blob/master/brext/board/linux.config
> 
> The build failure also happens with 5.15.62 and 63.

I've already asked Sasha & Greg for a revert today:

https://lore.kernel.org/netdev/20220826132137.GA24932@wunner.de

This was backported to stable kernels although it wasn't tagged
for stable.  You're the third person reporting breakage to me
because of it:

https://lore.kernel.org/all/YwaqZ1+zm78vl4L1@sirena.org.uk/
https://github.com/raspberrypi/linux/issues/5145

Thanks,

Lukas