From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A417ECAAD1 for ; Tue, 30 Aug 2022 17:22:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231264AbiH3RWy (ORCPT ); Tue, 30 Aug 2022 13:22:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229633AbiH3RWV (ORCPT ); Tue, 30 Aug 2022 13:22:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C893BE1A9A; Tue, 30 Aug 2022 10:20:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E10996177A; Tue, 30 Aug 2022 17:20:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03172C433C1; Tue, 30 Aug 2022 17:20:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661880039; bh=g+P08BfSsgdySgNRNWUPK6wH+vVCcn/SW9pXz0emGpk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OC8IVAxhsX8VT8xRBdeSFG1STEoO+rFiTq2UYdzRUTVoq2pqGj+H7xxMUx61IsOIY SLXTi8P6zwrluUJwmDgHZVEmnlWAExygR3PQVbeskHE104GWX+Axi0yZZoX5yAKmX6 Vru3HjO+50s0RWspL2tdlOJpaVM4uF8pL9V/8BNaG3OYMmIUsBzXynGXdXFi/S4bMt z6ZxdtoTqx1ah5jR+51LBvBrLmdQAPZVQZpf9di4VyKhDaHLvyNPWKpVY9AAPqJfpa SVok9aTxQu5ndDbNXx8jbrHfUXpw9dCePVuerC9khf50hnJTvbaqqBt7F39TkYNNhC 4RZFCHqUxYhqg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: lily , "David S . Miller" , Sasha Levin , edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, asml.silence@gmail.com, imagedong@tencent.com, luiz.von.dentz@intel.com, vasily.averin@linux.dev, jk@codeconstruct.com.au, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.19 25/33] net/core/skbuff: Check the return value of skb_copy_bits() Date: Tue, 30 Aug 2022 13:18:16 -0400 Message-Id: <20220830171825.580603-25-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220830171825.580603-1-sashal@kernel.org> References: <20220830171825.580603-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: lily [ Upstream commit c624c58e08b15105662b9ab9be23d14a6b945a49 ] skb_copy_bits() could fail, which requires a check on the return value. Signed-off-by: Li Zhong Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/core/skbuff.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 5b3559cb1d827..c4a1cd9861857 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -4179,9 +4179,8 @@ struct sk_buff *skb_segment(struct sk_buff *head_skb, SKB_GSO_CB(nskb)->csum_start = skb_headroom(nskb) + doffset; } else { - skb_copy_bits(head_skb, offset, - skb_put(nskb, len), - len); + if (skb_copy_bits(head_skb, offset, skb_put(nskb, len), len)) + goto err; } continue; } -- 2.35.1