From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A1AEC6FA82 for ; Fri, 2 Sep 2022 19:17:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229950AbiIBTRO (ORCPT ); Fri, 2 Sep 2022 15:17:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbiIBTRN (ORCPT ); Fri, 2 Sep 2022 15:17:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96B77F32D5; Fri, 2 Sep 2022 12:17:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C9462604EF; Fri, 2 Sep 2022 19:17:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16529C43144; Fri, 2 Sep 2022 19:17:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1662146230; bh=PAjZ4BFpG7czjR+byLH52PsXgEIKCoFIG2JPq8sXXTQ=; h=Date:To:From:Subject:From; b=ZhmkEVjY7I0WKUNZ+d6g+2NrY3vlnCTzI1uzH4++MhSGn3KgdWJscJjzQ7nvtVNu+ izj2oJPzpKp+sC2ra6ElDBOkV1KfYEY2eYguGFNv0a1/jHgaScJ627B5EUDHnzHmNv oeoIaTk+slOlTrvjA7X1qNULBxvLhWyvFzXt4QWQ= Date: Fri, 02 Sep 2022 12:17:09 -0700 To: mm-commits@vger.kernel.org, ying.huang@intel.com, willy@infradead.org, stable@vger.kernel.org, rcampbell@nvidia.com, peterx@redhat.com, paulus@ozlabs.org, nadav.amit@gmail.com, lyude@redhat.com, logang@deltatee.com, kherbst@redhat.com, jhubbard@nvidia.com, jgg@nvidia.com, huang.ying.caritas@gmail.com, Felix.Kuehling@amd.com, david@redhat.com, bskeggs@redhat.com, alex.sierra@amd.com, apopple@nvidia.com, akpm@linux-foundation.org From: Andrew Morton Subject: + mm-migrate_devicec-add-missing-flush_cache_page.patch added to mm-hotfixes-unstable branch Message-Id: <20220902191710.16529C43144@smtp.kernel.org> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org The patch titled Subject: mm/migrate_device.c: add missing flush_cache_page() has been added to the -mm mm-hotfixes-unstable branch. Its filename is mm-migrate_devicec-add-missing-flush_cache_page.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-migrate_devicec-add-missing-flush_cache_page.patch This patch will later appear in the mm-hotfixes-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Alistair Popple Subject: mm/migrate_device.c: add missing flush_cache_page() Date: Fri, 2 Sep 2022 10:35:52 +1000 Currently we only call flush_cache_page() for the anon_exclusive case, however in both cases we clear the pte so should flush the cache. Link: https://lkml.kernel.org/r/5676f30436ab71d1a587ac73f835ed8bd2113ff5.1662078528.git-series.apopple@nvidia.com Fixes: 8c3328f1f36a ("mm/migrate: migrate_vma() unmap page from vma while collecting pages") Signed-off-by: Alistair Popple Reviewed-by: David Hildenbrand Cc: Alex Sierra Cc: Ben Skeggs Cc: Felix Kuehling Cc: huang ying Cc: "Huang, Ying" Cc: Jason Gunthorpe Cc: John Hubbard Cc: Karol Herbst Cc: Logan Gunthorpe Cc: Lyude Paul Cc: Matthew Wilcox Cc: Nadav Amit Cc: Paul Mackerras Cc: Peter Xu Cc: Ralph Campbell Cc: Signed-off-by: Andrew Morton --- mm/migrate_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/migrate_device.c~mm-migrate_devicec-add-missing-flush_cache_page +++ a/mm/migrate_device.c @@ -193,9 +193,9 @@ again: bool anon_exclusive; pte_t swp_pte; + flush_cache_page(vma, addr, pte_pfn(*ptep)); anon_exclusive = PageAnon(page) && PageAnonExclusive(page); if (anon_exclusive) { - flush_cache_page(vma, addr, pte_pfn(*ptep)); ptep_clear_flush(vma, addr, ptep); if (page_try_share_anon_rmap(page)) { _ Patches currently in -mm which might be from apopple@nvidia.com are mm-migrate_devicec-flush-tlb-while-holding-ptl.patch mm-migrate_devicec-add-missing-flush_cache_page.patch mm-migrate_devicec-copy-pte-dirty-bit-to-page.patch mm-gupc-simplify-and-fix-check_and_migrate_movable_pages-return-codes.patch selftests-hmm-tests-add-test-for-dirty-bits.patch mm-gupc-dont-pass-gup_flags-to-check_and_migrate_movable_pages.patch mm-gupc-refactor-check_and_migrate_movable_pages.patch mm-migrate_devicec-fix-a-misleading-and-out-dated-comment.patch