From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB844C6FA8D for ; Sat, 3 Sep 2022 18:25:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230348AbiICSZw (ORCPT ); Sat, 3 Sep 2022 14:25:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233125AbiICSZt (ORCPT ); Sat, 3 Sep 2022 14:25:49 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14522419AB for ; Sat, 3 Sep 2022 11:25:48 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id bt10so7715955lfb.1 for ; Sat, 03 Sep 2022 11:25:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kvaser.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=ymLBBFuhOLsBRT4ErhQpDkzXlZDqKPHH8YS+qWCI4Xs=; b=dsR+TRqL0opNJH+i2+cEKuAz9gHHtEJYQ26UNcc3tjL0y0k8OdCba/+ok0M5gTurpL mEZHoBQsRo6aYjBygLVZ8Vfowg56JQoOPzRBcUOtF+alonpsZKYVPnITcdEHGmU1kk+h pOcJclsQ61bdvePMPMx1q8Q0ZEzM7yR0NW4j5JbGVqJe3fHfIPxbuRl7cIiqSYMoEgZk JmApCaThsOh4pBPgrAJyr+k/KonbvS/1NnwIYOXvqLrAqEDyK5E2y9dtBI8YWoFGSOz8 xDAq2GPTd4GW9Z5lVFGmB4MPefKrUVRjZowV6DG45IyMLuaBZd+99dNuoOi9/xggXXNk QTag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=ymLBBFuhOLsBRT4ErhQpDkzXlZDqKPHH8YS+qWCI4Xs=; b=u2NUFErbaThcm3dy31NsHe0GWPo42/cU0G2ldu214nAoiMH281wbzN2g7iF8OL4jcY YbIgW+9E7NlO6XaSei6gK+cZ9dokcUTRfueUEeQ2WSOx9wJvjqUD1iuQG1CfgKooPXWU ItnEsSv+09gVt38vORgVMOsYeAJiu71ct8L0aYdTN7rOm2UhWfTkzBP97okeA736ee3R NbFslranv4EQcPKfRLqTTD1qtmoYTPkJQ642FNM9HmX64lOPIf1tnXqWERzKdoQ3RzxU wl/8NQZ/03ssK8q1H36N+eA8WdLHEYe+JbS9cYVMBaekiI9/opPFuS/wLkZ8IvPgqpO2 /sng== X-Gm-Message-State: ACgBeo2HkjODcmXyTI83bturxizgtAX/fGFtGVQipZv1yPwB8ZiYSbtA zf2RkvmA1MKUvp5PvleDxu6mFA== X-Google-Smtp-Source: AA6agR5OurmJ8S4634DwFTpbuvP7Sx7DYISSZ/zFrkFvIZrE3GjgdAtjo/RCk+Yq7i+TaIjjKP9pww== X-Received: by 2002:a05:6512:2350:b0:494:9925:f734 with SMTP id p16-20020a056512235000b004949925f734mr4383276lfu.97.1662229547560; Sat, 03 Sep 2022 11:25:47 -0700 (PDT) Received: from f6a14fef6d45.. (h-155-4-68-234.A785.priv.bahnhof.se. [155.4.68.234]) by smtp.gmail.com with ESMTPSA id u18-20020ac24c32000000b00492f6ddba59sm658330lfq.75.2022.09.03.11.25.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Sep 2022 11:25:47 -0700 (PDT) From: Jimmy Assarsson To: linux-can@vger.kernel.org, Marc Kleine-Budde , Anssi Hannula Cc: Jimmy Assarsson , stable@vger.kernel.org, Jimmy Assarsson Subject: [PATCH v4 11/15] can: kvaser_usb_leaf: Fix wrong CAN state after stopping Date: Sat, 3 Sep 2022 20:25:55 +0200 Message-Id: <20220903182559.189-11-extja@kvaser.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220903182559.189-1-extja@kvaser.com> References: <20220903182559.189-1-extja@kvaser.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Anssi Hannula 0bfd:0124 Kvaser Mini PCI Express 2xHS FW 4.18.778 sends a CMD_CHIP_STATE_EVENT indicating bus-off after stopping the device, causing a stopped device to appear as CAN_STATE_BUS_OFF instead of CAN_STATE_STOPPED. Fix that by not handling error events on stopped devices. Cc: stable@vger.kernel.org Fixes: 080f40a6fa28 ("can: kvaser_usb: Add support for Kvaser CAN/USB devices") Tested-by: Jimmy Assarsson Signed-off-by: Anssi Hannula Signed-off-by: Jimmy Assarsson --- Changes in v4: - No changes Changes in v3: - Rebased on 1d5eeda23f36 ("can: kvaser_usb: advertise timestamping capabilities and add ioctl support") - Add stable to CC - Add S-o-b Changes in v2: - Rebased on b3b6df2c56d8 ("can: kvaser_usb: kvaser_usb_leaf: fix bittiming limits") drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c b/drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c index 993fcc19637d..4f9c76f4d0da 100644 --- a/drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c +++ b/drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c @@ -1045,6 +1045,10 @@ static void kvaser_usb_leaf_rx_error(const struct kvaser_usb *dev, leaf = priv->sub_priv; stats = &priv->netdev->stats; + /* Ignore e.g. state change to bus-off reported just after stopping */ + if (!netif_running(priv->netdev)) + return; + /* Update all of the CAN interface's state and error counters before * trying any memory allocation that can actually fail with -ENOMEM. * -- 2.37.3