From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50F7CC6FA82 for ; Sat, 10 Sep 2022 21:24:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230393AbiIJVYV (ORCPT ); Sat, 10 Sep 2022 17:24:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230183AbiIJVXa (ORCPT ); Sat, 10 Sep 2022 17:23:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C28F45208B; Sat, 10 Sep 2022 14:19:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7808960B4D; Sat, 10 Sep 2022 21:19:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3301EC433D7; Sat, 10 Sep 2022 21:19:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662844758; bh=oPZrZTAQIjQDJjJfYGVmJfuEiAnbcNj8vaUKQPAYhHU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OYaUjNBP7BkSsd/pZ98HVYl+e7opjSglBsZJ6ibm12grqXQmcaxf/YMewd6eYSgYS +cNC+8+EBqdxnBFFCQQ5T3Hl6Y1PdoQceRqIUz4lH21xoKfmHi0BMZSApehb8AU0DN c4Y/FK8XXCLG/6atVRv/vIWnkFFOJopDJB2N/TIxQ3nRxm/9jlOvnjTlYH/GFWfunt gtOPSXVxPsWNYMxbHl+yxgXTLtiI6gWIFfJ/Y7AmvHMexvMXHgX5PJE0dRoYcIRzRb +Bhylg264oYT+Ao+ZA5rcKOxHjXdbNb8ZlYuCppXPq3j+Wdp8A9bUQiv1lTGnmoUCu 0nedDIRLhdo0w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yu Zhe , Will Deacon , Sasha Levin , mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.4 08/10] perf/arm_pmu_platform: fix tests for platform_get_irq() failure Date: Sat, 10 Sep 2022 17:18:59 -0400 Message-Id: <20220910211901.70760-8-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220910211901.70760-1-sashal@kernel.org> References: <20220910211901.70760-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Yu Zhe [ Upstream commit 6bb0d64c100091e131cd16710b62fda3319cd0af ] The platform_get_irq() returns negative error codes. It can't actually return zero. Signed-off-by: Yu Zhe Link: https://lore.kernel.org/r/20220825011844.8536-1-yuzhe@nfschina.com Signed-off-by: Will Deacon Signed-off-by: Sasha Levin --- drivers/perf/arm_pmu_platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/perf/arm_pmu_platform.c b/drivers/perf/arm_pmu_platform.c index e35cb76c8d104..6eb077db7384d 100644 --- a/drivers/perf/arm_pmu_platform.c +++ b/drivers/perf/arm_pmu_platform.c @@ -118,7 +118,7 @@ static int pmu_parse_irqs(struct arm_pmu *pmu) if (num_irqs == 1) { int irq = platform_get_irq(pdev, 0); - if (irq && irq_is_percpu_devid(irq)) + if ((irq > 0) && irq_is_percpu_devid(irq)) return pmu_parse_percpu_irq(pmu, irq); } -- 2.35.1