From: Eddie James <eajames@linux.ibm.com>
To: jic23@kernel.org
Cc: lars@metafoo.de, linux-iio@vger.kernel.org, joel@jms.id.au,
linux-kernel@vger.kernel.org, andy.shevchenko@gmail.com,
stable@vger.kernel.org, eajames@linux.ibm.com
Subject: [PATCH v8 0/2] iio: pressure: dps310: Reset chip if MEAS_CFG is corrupt
Date: Thu, 15 Sep 2022 14:57:17 -0500 [thread overview]
Message-ID: <20220915195719.136812-1-eajames@linux.ibm.com> (raw)
The DPS310 chip has been observed to get "stuck" such that pressure
and temperature measurements are never indicated as "ready" in the
MEAS_CFG register. The only solution is to reset the device and try
again. In order to avoid continual failures, use a boolean flag to
only try the reset after timeout once if errors persist. Include a
patch to move the startup procedure into a function.
Changes since v7:
- Condense the code a bit by dropping rc2
Changes since v6:
- Use helper instead of the lengthy regmap_read_poll_timeout twice
- Just return dps310_startup in dps310_reset_reinit
Changes since v5:
- Completely rework the second patch to reset and reinit in any
timeout condition, if there haven't been previous timeouts that
failed to recover the chip.
Changes since v4:
- Just check for rc rather than rc < 0 in some cases
- Split declaration and init of rc
Changes since v3:
- Don't check regmap* return codes for < 0
- Fix comment spelling
Changes since v2:
- Add some comments
- Fix the clunky control flow
Changes since v1:
- Separate into two patches
- Rename 'dps310_verify_meas_cfg' to 'dps310_check_reset_meas_cfg'
Eddie James (2):
iio: pressure: dps310: Refactor startup procedure
iio: pressure: dps310: Reset chip after timeout
drivers/iio/pressure/dps310.c | 262 +++++++++++++++++++++-------------
1 file changed, 163 insertions(+), 99 deletions(-)
--
2.31.1
next reply other threads:[~2022-09-15 19:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 19:57 Eddie James [this message]
2022-09-15 19:57 ` [PATCH v8 1/2] iio: pressure: dps310: Refactor startup procedure Eddie James
2022-09-15 19:57 ` [PATCH v8 2/2] iio: pressure: dps310: Reset chip after timeout Eddie James
2022-09-16 5:51 ` Andy Shevchenko
2022-09-16 15:25 ` Jonathan Cameron
2022-09-18 15:52 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220915195719.136812-1-eajames@linux.ibm.com \
--to=eajames@linux.ibm.com \
--cc=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=joel@jms.id.au \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox