From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87313C433FE for ; Tue, 11 Oct 2022 17:34:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229520AbiJKReE (ORCPT ); Tue, 11 Oct 2022 13:34:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230092AbiJKRdW (ORCPT ); Tue, 11 Oct 2022 13:33:22 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E6A24BA5C for ; Tue, 11 Oct 2022 10:30:33 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1oiJ3u-0005d3-H7; Tue, 11 Oct 2022 19:29:02 +0200 Date: Tue, 11 Oct 2022 19:29:02 +0200 From: Florian Westphal To: Vimal Agrawal Cc: stable@vger.kernel.org, fw@strlen.de, Vimal Agrawal Subject: Re: [PATCH 4.14.y] netfilter: nf_queue: fix socket leak Message-ID: <20221011172902.GC19620@breakpoint.cc> References: <20221011172202.3709-1-vimal.agrawal@sophos.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221011172202.3709-1-vimal.agrawal@sophos.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Vimal Agrawal wrote: > Removal of the sock_hold got lost when backporting commit 4d05239203fa > ("netfilter: nf_queue: fix possible use-after-free") to 4.14 > > This was causing a socket leak and was caught by kmemleak. > Tested by running kmemleak again with this fix. Thanks. Reviewed-by: Florian Westphal