From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04FEBC433FE for ; Tue, 11 Oct 2022 21:58:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229487AbiJKV6i (ORCPT ); Tue, 11 Oct 2022 17:58:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229470AbiJKV6h (ORCPT ); Tue, 11 Oct 2022 17:58:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46E1C5A168; Tue, 11 Oct 2022 14:58:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E0222612EA; Tue, 11 Oct 2022 21:58:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B01AEC433C1; Tue, 11 Oct 2022 21:58:33 +0000 (UTC) Date: Tue, 11 Oct 2022 17:58:31 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Andrew Morton , Tom Zanussi , stable@vger.kernel.org Subject: Re: [PATCH 2/2] tracing: Fix reading strings from synthetic events Message-ID: <20221011175831.3dd2d460@rorschach.local.home> In-Reply-To: <20221011212702.220048293@goodmis.org> References: <20221011212501.773319898@goodmis.org> <20221011212702.220048293@goodmis.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, 11 Oct 2022 17:25:03 -0400 Steven Rostedt wrote: > @@ -417,19 +420,28 @@ static unsigned int trace_string(struct synth_trace_event *entry, > data_offset += event->n_u64 * sizeof(u64); > data_offset += data_size; > > - str_field = (char *)entry + data_offset; > - > - len = strlen(str_val) + 1; > - strscpy(str_field, str_val, len); > - > + len = kern_fetch_store_strlen(str_val) + 1; > + if (len == 1) > + len = strlen("fault") + 1; > data_offset |= len << 16; > *(u32 *)&entry->fields[*n_u64] = data_offset; > > + kern_fetch_store_string((unsigned long)str_val, &entry->fields[*n_u64], entry); > + This isn't working quite right on faults. I'll be sending a v2 later. -- Steve