stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Yixuan Cao <caoyixuan2019@email.szu.edu.cn>,
	Chongxi Zhao <zhaochongxi2019@email.szu.edu.cn>,
	Jiajian Ye <yejiajian2018@email.szu.edu.cn>,
	Yuhong Feng <yuhongf@szu.edu.cn>,
	Liam Mark <lmark@codeaurora.org>,
	Georgi Djakov <georgi.djakov@linaro.org>,
	Vlastimil Babka <vbabka@suse.cz>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Sasha Levin <sashal@kernel.org>,
	seanga2@gmail.com, zhangyinan2019@email.szu.edu.cn,
	weizhenliang@huawei.com
Subject: [PATCH AUTOSEL 6.0 09/32] tools/vm/page_owner_sort: fix -f option
Date: Mon, 17 Oct 2022 20:07:06 -0400	[thread overview]
Message-ID: <20221018000729.2730519-9-sashal@kernel.org> (raw)
In-Reply-To: <20221018000729.2730519-1-sashal@kernel.org>

From: Yixuan Cao <caoyixuan2019@email.szu.edu.cn>

[ Upstream commit 57eb60c04d2c7b0de91eac2bc5d0331f8fe72fd7 ]

The -f option is to filter out the information of blocks whose memory has
not been released, I noticed some blocks should not be filtered out.

Commit 9cc7e96aa846 ("mm/page_owner: record timestamp and pid") records
the allocation timestamp (ts_nsec) of all pages.

Commit 866b48526217 ("mm/page_owner: record the timestamp of all pages
during free") records the free timestamp (free_ts_nsec) of all pages.
When the page is allocated for the first time, the initial value of
free_ts_nsec is 0, and the corresponding time will be obtained when the
page is released.  But during reallocation the free_ts_nsec will not reset
to 0 again.  In particular, when page migration occurs, these two
timestamps will be the same.

Now page_owner_sort removes all text blocks whose free_ts_nsec is not 0
when using -f option.  However, this way can only select pages allocated
for the first time.  If a freed page is reallocated, free_ts_nsec will be
less than ts_nsec; if page migration occurs, the two timestamps will be
equal.  These cases should be considered as pages are not released.

So I fix the function is_need() to keep text blocks that meet the above
two conditions when using -f option.

Link: https://lkml.kernel.org/r/20220812155515.30846-1-caoyixuan2019@email.szu.edu.cn
Signed-off-by: Yixuan Cao <caoyixuan2019@email.szu.edu.cn>
Cc: Chongxi Zhao <zhaochongxi2019@email.szu.edu.cn>
Cc: Jiajian Ye <yejiajian2018@email.szu.edu.cn>
Cc: Yuhong Feng <yuhongf@szu.edu.cn>
Cc: Liam Mark <lmark@codeaurora.org>
Cc: Georgi Djakov <georgi.djakov@linaro.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 tools/vm/page_owner_sort.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tools/vm/page_owner_sort.c b/tools/vm/page_owner_sort.c
index ec2e67c85b84..ce860ab94162 100644
--- a/tools/vm/page_owner_sort.c
+++ b/tools/vm/page_owner_sort.c
@@ -470,7 +470,12 @@ static bool match_str_list(const char *str, char **list, int list_size)
 
 static bool is_need(char *buf)
 {
-	if ((filter & FILTER_UNRELEASE) && get_free_ts_nsec(buf) != 0)
+	__u64 ts_nsec, free_ts_nsec;
+
+	ts_nsec = get_ts_nsec(buf);
+	free_ts_nsec = get_free_ts_nsec(buf);
+
+	if ((filter & FILTER_UNRELEASE) && free_ts_nsec != 0 && ts_nsec < free_ts_nsec)
 		return false;
 	if ((filter & FILTER_PID) && !match_num_list(get_pid(buf), fc.pids, fc.pids_size))
 		return false;
-- 
2.35.1


  parent reply	other threads:[~2022-10-18  0:08 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-18  0:06 [PATCH AUTOSEL 6.0 01/32] crypto: qcom-rng - Fix qcom_rng_of_match unused warning Sasha Levin
2022-10-18  0:06 ` [PATCH AUTOSEL 6.0 02/32] crypto: ccp - Add a quirk to firmware update Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 03/32] crypto: ccp - Initialize PSP when reading psp data file failed Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 04/32] gfs2: Switch from strlcpy to strscpy Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 05/32] powerpc/hw_breakpoint: Avoid relying on caller synchronization Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 06/32] cgroup: Remove data-race around cgrp_dfl_visible Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 07/32] iommu/vt-d: Handle race between registration and device probe Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 08/32] of/fdt: Don't calculate initrd size from DT if start > end Sasha Levin
2022-10-18  0:07 ` Sasha Levin [this message]
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 10/32] objtool,x86: Teach decode about LOOP* instructions Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 11/32] locking/rwsem: Disable preemption while trying for rwsem lock Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 12/32] swiotlb: don't panic! Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 13/32] gfs2: Check sb_bsize_shift after reading superblock Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 14/32] powerpc/64: don't refer nr_cpu_ids in asm code when it's undefined Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 15/32] m68knommu: fix non-specific 68328 choice interrupt build failure Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 16/32] m68knommu: fix non-mmu classic 68000 legacy timer tick selection Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 17/32] kbuild: take into account DT_SCHEMA_FILES changes while checking dtbs Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 18/32] tracing/user_events: Use WRITE instead of READ for io vector import Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 19/32] tracing/user_events: Ensure user provided strings are safely formatted Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 20/32] of: Fix "dma-ranges" handling for bus controllers Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 21/32] x86/hyperv: Replace kmap() with kmap_local_page() Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 22/32] kmsan: disable instrumentation of unsupported common kernel code Sasha Levin
2022-10-18  1:00   ` Marco Elver
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 23/32] kmsan: disable physical page merging in biovec Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 24/32] f2fs: fix wrong dirty page count when race between mmap and fallocate Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 25/32] f2fs: code clean and fix a type error Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 26/32] f2fs: fix to detect corrupted meta ino Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 27/32] 9p: trans_fd/p9_conn_cancel: drop client lock earlier Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 28/32] nfsd: fix nfsd_file_unhash_and_dispose Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 29/32] 9p/trans_fd: always use O_NONBLOCK read/write Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 30/32] net/9p: use a dedicated spinlock for trans_fd Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 31/32] virtio_pci: don't try to use intxif pin is zero Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 32/32] cifs: replace kfree() with kfree_sensitive() for sensitive data Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221018000729.2730519-9-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=caoyixuan2019@email.szu.edu.cn \
    --cc=georgi.djakov@linaro.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lmark@codeaurora.org \
    --cc=seanga2@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=vbabka@suse.cz \
    --cc=weizhenliang@huawei.com \
    --cc=yejiajian2018@email.szu.edu.cn \
    --cc=yuhongf@szu.edu.cn \
    --cc=zhangyinan2019@email.szu.edu.cn \
    --cc=zhaochongxi2019@email.szu.edu.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).