public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Dumazet <ndumazet@google.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jean-Francois Le Fillatre <jflf_kernel@gmx.com>
Cc: Petar Kostic <petar@kostic.dev>, Oliver Neukum <oneukum@suse.com>,
	Ole Ernst <olebowle@gmx.com>, Hannu Hartikainen <hannu@hrtk.in>,
	Jimmy Wang <wangjm221@gmail.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Nicolas Dumazet <ndumazet@google.com>,
	stable@vger.kernel.org
Subject: [PATCH v2] usb: add NO_LPM quirk for Realforce 87U Keyboard
Date: Thu, 27 Oct 2022 11:03:42 +0200	[thread overview]
Message-ID: <20221027090342.38928-1-ndumazet@google.com> (raw)

Before adding this quirk, this (mechanical keyboard) device would not be
recognized, logging:

  new full-speed USB device number 56 using xhci_hcd
  unable to read config index 0 descriptor/start: -32
  chopping to 0 config(s)

It would take dozens of plugging/unpuggling cycles for the keyboard to
be recognized. Keyboard seems to simply work after applying this quirk.

This issue had been reported by users in two places already ([1], [2])
but nobody tried upstreaming a patch yet. After testing I believe their
suggested fix (DELAY_INIT + NO_LPM + DEVICE_QUALIFIER) was probably a
little overkill. I assume this particular combination was tested because
it had been previously suggested in [3], but only NO_LPM seems
sufficient for this device.

[1]: https://qiita.com/float168/items/fed43d540c8e2201b543
[2]: https://blog.kostic.dev/posts/making-the-realforce-87ub-work-with-usb30-on-Ubuntu/
[3]: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1678477

---
Changes in v2:
  - add the entry to the right location (sorting entries by
    vendor/device id).

Cc: stable@vger.kernel.org
Signed-off-by: Nicolas Dumazet <ndumazet@google.com>
---
 drivers/usb/core/quirks.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 0722d2131305..079e183cf3bf 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -362,6 +362,9 @@ static const struct usb_device_id usb_quirk_list[] = {
 	{ USB_DEVICE(0x0781, 0x5583), .driver_info = USB_QUIRK_NO_LPM },
 	{ USB_DEVICE(0x0781, 0x5591), .driver_info = USB_QUIRK_NO_LPM },
 
+	/* Realforce 87U Keyboard */
+	{ USB_DEVICE(0x0853, 0x011b), .driver_info = USB_QUIRK_NO_LPM },
+
 	/* M-Systems Flash Disk Pioneers */
 	{ USB_DEVICE(0x08ec, 0x1000), .driver_info = USB_QUIRK_RESET_RESUME },
 
-- 
2.38.0.135.g90850a2211-goog


             reply	other threads:[~2022-10-27  9:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-27  9:03 Nicolas Dumazet [this message]
2022-11-09 11:29 ` [PATCH v2] usb: add NO_LPM quirk for Realforce 87U Keyboard Greg Kroah-Hartman
2022-11-09 12:31   ` Nicolas Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221027090342.38928-1-ndumazet@google.com \
    --to=ndumazet@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hannu@hrtk.in \
    --cc=jflf_kernel@gmx.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=olebowle@gmx.com \
    --cc=oneukum@suse.com \
    --cc=petar@kostic.dev \
    --cc=stable@vger.kernel.org \
    --cc=wangjm221@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox