From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A93E5C4332F for ; Wed, 2 Nov 2022 03:18:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229826AbiKBDSj (ORCPT ); Tue, 1 Nov 2022 23:18:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229932AbiKBDSh (ORCPT ); Tue, 1 Nov 2022 23:18:37 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B111DE8A for ; Tue, 1 Nov 2022 20:18:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 15748B8206F for ; Wed, 2 Nov 2022 03:18:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E28D9C433D6; Wed, 2 Nov 2022 03:18:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1667359110; bh=BC9llXGMgYJL2UJGeItO5ja0G+0kITW83xkY1uXo+8A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=o7t+B4d9rZ6IWRQlt5sWfp47Y+9CyeAyjsiBqhgxRUfoO7jPkHaNLOF7m2zMdY5ny iKgOHCVU3/CefxR8+MJ6519HUJlhKYpkx2M/LqnzaDN0IeAsOxeBHOYzk5r4GyXhol wlOlP4amAkf1+6cb8wWA8PNobjg7EgF+M3yxUpS0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+31cde0bef4bbf8ba2d86@syzkaller.appspotmail.com, Thomas Graf , Aaron Conole , Ilya Maximets , Paolo Abeni , Sasha Levin Subject: [PATCH 5.10 78/91] openvswitch: switch from WARN to pr_warn Date: Wed, 2 Nov 2022 03:34:01 +0100 Message-Id: <20221102022057.270704515@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221102022055.039689234@linuxfoundation.org> References: <20221102022055.039689234@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Aaron Conole [ Upstream commit fd954cc1919e35cb92f78671cab6e42d661945a3 ] As noted by Paolo Abeni, pr_warn doesn't generate any splat and can still preserve the warning to the user that feature downgrade occurred. We likely cannot introduce other kinds of checks / enforcement here because syzbot can generate different genl versions to the datapath. Reported-by: syzbot+31cde0bef4bbf8ba2d86@syzkaller.appspotmail.com Fixes: 44da5ae5fbea ("openvswitch: Drop user features if old user space attempted to create datapath") Cc: Thomas Graf Signed-off-by: Aaron Conole Acked-by: Ilya Maximets Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- net/openvswitch/datapath.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c index 6b5c0abf7f1b..7ed97dc0b561 100644 --- a/net/openvswitch/datapath.c +++ b/net/openvswitch/datapath.c @@ -1592,7 +1592,8 @@ static void ovs_dp_reset_user_features(struct sk_buff *skb, if (IS_ERR(dp)) return; - WARN(dp->user_features, "Dropping previously announced user features\n"); + pr_warn("%s: Dropping previously announced user features\n", + ovs_dp_name(dp)); dp->user_features = 0; } -- 2.35.1