From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0CD0C433FE for ; Wed, 2 Nov 2022 02:44:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230335AbiKBCo4 (ORCPT ); Tue, 1 Nov 2022 22:44:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230333AbiKBCoz (ORCPT ); Tue, 1 Nov 2022 22:44:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 874E520F46 for ; Tue, 1 Nov 2022 19:44:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 255C0617A9 for ; Wed, 2 Nov 2022 02:44:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 624C6C433D6; Wed, 2 Nov 2022 02:44:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1667357093; bh=+ve+K4AgXyLZz7CAjwwNrOJG5NdE6ZTfapjdDQ4q8ss=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RrY7bqrqpW+NqYNfUmMP/h8OIlZRt5zA6Q/MSFOP/48/q4iuOiWrJ3OvOZGyHXAEm G0cFmkarI9f5Tg5Y4TzyH6g6ptMo3Kc3at2nWiW5a7MgS8znegvBZh521trQarleXl O4hWDVcnW3xEpDGug+2YjhjCqSN6iAxvOIkfeJCc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yang Yingliang , =?UTF-8?q?Krzysztof=20Ha=C5=82asa?= , Sakari Ailus , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 6.0 111/240] media: ar0521: fix error return code in ar0521_power_on() Date: Wed, 2 Nov 2022 03:31:26 +0100 Message-Id: <20221102022113.899510510@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221102022111.398283374@linuxfoundation.org> References: <20221102022111.398283374@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Yang Yingliang [ Upstream commit b5f8fa876931c1adfd2c5eca5b189fd2be893238 ] Return error code if ar0521_write_regs() fails in ar0521_power_on(). Fixes: 852b50aeed15 ("media: On Semi AR0521 sensor driver") Signed-off-by: Yang Yingliang Acked-by: Krzysztof Hałasa Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/i2c/ar0521.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/ar0521.c b/drivers/media/i2c/ar0521.c index c7bdfc69b9be..e850c92d847e 100644 --- a/drivers/media/i2c/ar0521.c +++ b/drivers/media/i2c/ar0521.c @@ -757,8 +757,9 @@ static int ar0521_power_on(struct device *dev) usleep_range(4500, 5000); /* min 45000 clocks */ for (cnt = 0; cnt < ARRAY_SIZE(initial_regs); cnt++) - if (ar0521_write_regs(sensor, initial_regs[cnt].data, - initial_regs[cnt].count)) + ret = ar0521_write_regs(sensor, initial_regs[cnt].data, + initial_regs[cnt].count); + if (ret) goto off; ret = ar0521_write_reg(sensor, AR0521_REG_SERIAL_FORMAT, -- 2.35.1