From: Vishal Verma <vishal.l.verma@intel.com>
To: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
linux-kernel@vger.kernel.org,
Chris Piper <chris.d.piper@intel.com>,
nvdimm@lists.linux.dev, linux-acpi@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Liu Shixin <liushixin2@huawei.com>,
stable@vger.kernel.org
Subject: [PATCH v2 1/2] ACPI: HMAT: remove unnecessary variable initialization
Date: Wed, 16 Nov 2022 16:37:36 -0700 [thread overview]
Message-ID: <20221116-acpi_hmat_fix-v2-1-3712569be691@intel.com> (raw)
In-Reply-To: <20221116-acpi_hmat_fix-v2-0-3712569be691@intel.com>
In hmat_register_target_initiators(), the variable 'best' gets
initialized in the outer per-locality-type for loop. The initialization
just before setting up 'Access 1' targets was unnecessary. Remove it.
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Liu Shixin <liushixin2@huawei.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
---
drivers/acpi/numa/hmat.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/acpi/numa/hmat.c b/drivers/acpi/numa/hmat.c
index 23f49a2f4d14..144a84f429ed 100644
--- a/drivers/acpi/numa/hmat.c
+++ b/drivers/acpi/numa/hmat.c
@@ -644,7 +644,6 @@ static void hmat_register_target_initiators(struct memory_target *target)
/* Access 1 ignores Generic Initiators */
bitmap_zero(p_nodes, MAX_NUMNODES);
list_sort(p_nodes, &initiators, initiator_cmp);
- best = 0;
for (i = WRITE_LATENCY; i <= READ_BANDWIDTH; i++) {
loc = localities_types[i];
if (!loc)
--
2.38.1
next prev parent reply other threads:[~2022-11-16 23:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 23:37 [PATCH v2 0/2] ACPI: HMAT: fix single-initiator target registrations Vishal Verma
2022-11-16 23:37 ` Vishal Verma [this message]
2022-11-16 23:42 ` [PATCH v2 1/2] ACPI: HMAT: remove unnecessary variable initialization kernel test robot
2022-11-16 23:37 ` [PATCH v2 2/2] ACPI: HMAT: Fix initiator registration for single-initiator systems Vishal Verma
2022-11-16 23:54 ` Kirill A. Shutemov
2022-11-17 16:20 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221116-acpi_hmat_fix-v2-1-3712569be691@intel.com \
--to=vishal.l.verma@intel.com \
--cc=chris.d.piper@intel.com \
--cc=dan.j.williams@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liushixin2@huawei.com \
--cc=nvdimm@lists.linux.dev \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox