* [PATCH v5] Bluetooth: btintel: Correctly declare all module firmware files
@ 2025-08-26 19:42 DaanDeMeyer
2025-08-26 20:29 ` [PATCH v5 RESEND] " DaanDeMeyer
2025-08-27 5:29 ` Paul Menzel
0 siblings, 2 replies; 4+ messages in thread
From: DaanDeMeyer @ 2025-08-26 19:42 UTC (permalink / raw)
To: daan.j.demeyer; +Cc: Dimitri John Ledkov, stable
From: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
Strictly encode patterns of supported hw_variants of firmware files
the kernel driver supports requesting. This now includes many missing
and previously undeclared module firmware files for 0x07, 0x08,
0x11-0x14, 0x17-0x1b hw_variants.
This especially affects environments that only install firmware files
declared and referenced by the kernel modules. In such environments,
only the declared firmware files are copied resulting in most Intel
Bluetooth devices not working. I.e. host-only dracut-install initrds,
or Ubuntu Core kernel snaps.
BugLink: https://bugs.launchpad.net/bugs/1970819
Cc: stable@vger.kernel.org # 4.15+
Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
---
Notes:
Changes since v4:
- Add missing "intel/" prefix for 0x17+ firmware
- Add Cc stable for v4.15+ kernels
Changes since v3:
- Hopefully pacify trailing whitespace from GitLint in this optional
portion of the commit.
Changes since v2:
- encode patterns for 0x17 0x18 0x19 0x1b hw_variants
- rebase on top of latest rc tag
Changes since v1:
- encode strict patterns of supported firmware files for each of the
supported hw_variant generations.
drivers/bluetooth/btintel.c | 26 ++++++++++++++++++++++----
1 file changed, 22 insertions(+), 4 deletions(-)
diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
index a657e9a3e96a..d0e22fe09567 100644
--- a/drivers/bluetooth/btintel.c
+++ b/drivers/bluetooth/btintel.c
@@ -2656,7 +2656,25 @@ MODULE_AUTHOR("Marcel Holtmann <marcel@holtmann.org>");
MODULE_DESCRIPTION("Bluetooth support for Intel devices ver " VERSION);
MODULE_VERSION(VERSION);
MODULE_LICENSE("GPL");
-MODULE_FIRMWARE("intel/ibt-11-5.sfi");
-MODULE_FIRMWARE("intel/ibt-11-5.ddc");
-MODULE_FIRMWARE("intel/ibt-12-16.sfi");
-MODULE_FIRMWARE("intel/ibt-12-16.ddc");
+/* hw_variant 0x07 0x08 */
+MODULE_FIRMWARE("intel/ibt-hw-37.7.*-fw-*.*.*.*.*.bseq");
+MODULE_FIRMWARE("intel/ibt-hw-37.7.bseq");
+MODULE_FIRMWARE("intel/ibt-hw-37.8.*-fw-*.*.*.*.*.bseq");
+MODULE_FIRMWARE("intel/ibt-hw-37.8.bseq");
+/* hw_variant 0x0b 0x0c */
+MODULE_FIRMWARE("intel/ibt-11-*.sfi");
+MODULE_FIRMWARE("intel/ibt-12-*.sfi");
+MODULE_FIRMWARE("intel/ibt-11-*.ddc");
+MODULE_FIRMWARE("intel/ibt-12-*.ddc");
+/* hw_variant 0x11 0x12 0x13 0x14 */
+MODULE_FIRMWARE("intel/ibt-17-*-*.sfi");
+MODULE_FIRMWARE("intel/ibt-18-*-*.sfi");
+MODULE_FIRMWARE("intel/ibt-19-*-*.sfi");
+MODULE_FIRMWARE("intel/ibt-20-*-*.sfi");
+MODULE_FIRMWARE("intel/ibt-17-*-*.ddc");
+MODULE_FIRMWARE("intel/ibt-18-*-*.ddc");
+MODULE_FIRMWARE("intel/ibt-19-*-*.ddc");
+MODULE_FIRMWARE("intel/ibt-20-*-*.ddc");
+/* hw_variant 0x17 0x18 0x19 0x1b, read and use cnvi/cnvr */
+MODULE_FIRMWARE("intel/ibt-[0-9][0-9][0-9][0-9]-[0-9][0-9][0-9][0-9].sfi");
+MODULE_FIRMWARE("intel/ibt-[0-9][0-9][0-9][0-9]-[0-9][0-9][0-9][0-9].ddc");
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v5 RESEND] Bluetooth: btintel: Correctly declare all module firmware files
2025-08-26 19:42 [PATCH v5] Bluetooth: btintel: Correctly declare all module firmware files DaanDeMeyer
@ 2025-08-26 20:29 ` DaanDeMeyer
2025-08-27 5:29 ` Paul Menzel
1 sibling, 0 replies; 4+ messages in thread
From: DaanDeMeyer @ 2025-08-26 20:29 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Dimitri John Ledkov, stable
From: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
Strictly encode patterns of supported hw_variants of firmware files
the kernel driver supports requesting. This now includes many missing
and previously undeclared module firmware files for 0x07, 0x08,
0x11-0x14, 0x17-0x1b hw_variants.
This especially affects environments that only install firmware files
declared and referenced by the kernel modules. In such environments,
only the declared firmware files are copied resulting in most Intel
Bluetooth devices not working. I.e. host-only dracut-install initrds,
or Ubuntu Core kernel snaps.
BugLink: https://bugs.launchpad.net/bugs/1970819
Cc: stable@vger.kernel.org # 4.15+
Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
---
Notes:
Changes since v4:
- Add missing "intel/" prefix for 0x17+ firmware
- Add Cc stable for v4.15+ kernels
Changes since v3:
- Hopefully pacify trailing whitespace from GitLint in this optional
portion of the commit.
Changes since v2:
- encode patterns for 0x17 0x18 0x19 0x1b hw_variants
- rebase on top of latest rc tag
Changes since v1:
- encode strict patterns of supported firmware files for each of the
supported hw_variant generations.
drivers/bluetooth/btintel.c | 26 ++++++++++++++++++++++----
1 file changed, 22 insertions(+), 4 deletions(-)
diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
index a657e9a3e96a..d0e22fe09567 100644
--- a/drivers/bluetooth/btintel.c
+++ b/drivers/bluetooth/btintel.c
@@ -2656,7 +2656,25 @@ MODULE_AUTHOR("Marcel Holtmann <marcel@holtmann.org>");
MODULE_DESCRIPTION("Bluetooth support for Intel devices ver " VERSION);
MODULE_VERSION(VERSION);
MODULE_LICENSE("GPL");
-MODULE_FIRMWARE("intel/ibt-11-5.sfi");
-MODULE_FIRMWARE("intel/ibt-11-5.ddc");
-MODULE_FIRMWARE("intel/ibt-12-16.sfi");
-MODULE_FIRMWARE("intel/ibt-12-16.ddc");
+/* hw_variant 0x07 0x08 */
+MODULE_FIRMWARE("intel/ibt-hw-37.7.*-fw-*.*.*.*.*.bseq");
+MODULE_FIRMWARE("intel/ibt-hw-37.7.bseq");
+MODULE_FIRMWARE("intel/ibt-hw-37.8.*-fw-*.*.*.*.*.bseq");
+MODULE_FIRMWARE("intel/ibt-hw-37.8.bseq");
+/* hw_variant 0x0b 0x0c */
+MODULE_FIRMWARE("intel/ibt-11-*.sfi");
+MODULE_FIRMWARE("intel/ibt-12-*.sfi");
+MODULE_FIRMWARE("intel/ibt-11-*.ddc");
+MODULE_FIRMWARE("intel/ibt-12-*.ddc");
+/* hw_variant 0x11 0x12 0x13 0x14 */
+MODULE_FIRMWARE("intel/ibt-17-*-*.sfi");
+MODULE_FIRMWARE("intel/ibt-18-*-*.sfi");
+MODULE_FIRMWARE("intel/ibt-19-*-*.sfi");
+MODULE_FIRMWARE("intel/ibt-20-*-*.sfi");
+MODULE_FIRMWARE("intel/ibt-17-*-*.ddc");
+MODULE_FIRMWARE("intel/ibt-18-*-*.ddc");
+MODULE_FIRMWARE("intel/ibt-19-*-*.ddc");
+MODULE_FIRMWARE("intel/ibt-20-*-*.ddc");
+/* hw_variant 0x17 0x18 0x19 0x1b, read and use cnvi/cnvr */
+MODULE_FIRMWARE("intel/ibt-[0-9][0-9][0-9][0-9]-[0-9][0-9][0-9][0-9].sfi");
+MODULE_FIRMWARE("intel/ibt-[0-9][0-9][0-9][0-9]-[0-9][0-9][0-9][0-9].ddc");
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v5 RESEND] Bluetooth: btintel: Correctly declare all module firmware files
2025-08-26 19:42 [PATCH v5] Bluetooth: btintel: Correctly declare all module firmware files DaanDeMeyer
2025-08-26 20:29 ` [PATCH v5 RESEND] " DaanDeMeyer
@ 2025-08-27 5:29 ` Paul Menzel
2025-08-27 5:31 ` Paul Menzel
1 sibling, 1 reply; 4+ messages in thread
From: Paul Menzel @ 2025-08-27 5:29 UTC (permalink / raw)
To: Daan De Meyer
Cc: linux-bluetooth, Dimitri John Ledkov, stable,
Luiz Augusto von Dentz, Marcel Holtmann
Dear Daan,
Thank you for the patch.
Am 26.08.25 um 22:29 schrieb DaanDeMeyer:
> From: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
>
> Strictly encode patterns of supported hw_variants of firmware files
> the kernel driver supports requesting. This now includes many missing
> and previously undeclared module firmware files for 0x07, 0x08,
> 0x11-0x14, 0x17-0x1b hw_variants.
>
> This especially affects environments that only install firmware files
> declared and referenced by the kernel modules. In such environments,
> only the declared firmware files are copied resulting in most Intel
> Bluetooth devices not working. I.e. host-only dracut-install initrds,
> or Ubuntu Core kernel snaps.
>
> BugLink: https://bugs.launchpad.net/bugs/1970819
> Cc: stable@vger.kernel.org # 4.15+
> Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
> ---
> Notes:
> Changes since v4:
> - Add missing "intel/" prefix for 0x17+ firmware
> - Add Cc stable for v4.15+ kernels
>
> Changes since v3:
> - Hopefully pacify trailing whitespace from GitLint in this optional
> portion of the commit.
>
> Changes since v2:
> - encode patterns for 0x17 0x18 0x19 0x1b hw_variants
> - rebase on top of latest rc tag
>
> Changes since v1:
> - encode strict patterns of supported firmware files for each of the
> supported hw_variant generations.
>
> drivers/bluetooth/btintel.c | 26 ++++++++++++++++++++++----
> 1 file changed, 22 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> index a657e9a3e96a..d0e22fe09567 100644
> --- a/drivers/bluetooth/btintel.c
> +++ b/drivers/bluetooth/btintel.c
> @@ -2656,7 +2656,25 @@ MODULE_AUTHOR("Marcel Holtmann <marcel@holtmann.org>");
> MODULE_DESCRIPTION("Bluetooth support for Intel devices ver " VERSION);
> MODULE_VERSION(VERSION);
> MODULE_LICENSE("GPL");
> -MODULE_FIRMWARE("intel/ibt-11-5.sfi");
> -MODULE_FIRMWARE("intel/ibt-11-5.ddc");
> -MODULE_FIRMWARE("intel/ibt-12-16.sfi");
> -MODULE_FIRMWARE("intel/ibt-12-16.ddc");
> +/* hw_variant 0x07 0x08 */
> +MODULE_FIRMWARE("intel/ibt-hw-37.7.*-fw-*.*.*.*.*.bseq");
> +MODULE_FIRMWARE("intel/ibt-hw-37.7.bseq");
> +MODULE_FIRMWARE("intel/ibt-hw-37.8.*-fw-*.*.*.*.*.bseq");
> +MODULE_FIRMWARE("intel/ibt-hw-37.8.bseq");
> +/* hw_variant 0x0b 0x0c */
> +MODULE_FIRMWARE("intel/ibt-11-*.sfi");
> +MODULE_FIRMWARE("intel/ibt-12-*.sfi");
> +MODULE_FIRMWARE("intel/ibt-11-*.ddc");
> +MODULE_FIRMWARE("intel/ibt-12-*.ddc");
> +/* hw_variant 0x11 0x12 0x13 0x14 */
> +MODULE_FIRMWARE("intel/ibt-17-*-*.sfi");
> +MODULE_FIRMWARE("intel/ibt-18-*-*.sfi");
> +MODULE_FIRMWARE("intel/ibt-19-*-*.sfi");
> +MODULE_FIRMWARE("intel/ibt-20-*-*.sfi");
> +MODULE_FIRMWARE("intel/ibt-17-*-*.ddc");
> +MODULE_FIRMWARE("intel/ibt-18-*-*.ddc");
> +MODULE_FIRMWARE("intel/ibt-19-*-*.ddc");
> +MODULE_FIRMWARE("intel/ibt-20-*-*.ddc");
> +/* hw_variant 0x17 0x18 0x19 0x1b, read and use cnvi/cnvr */
> +MODULE_FIRMWARE("intel/ibt-[0-9][0-9][0-9][0-9]-[0-9][0-9][0-9][0-9].sfi");
> +MODULE_FIRMWARE("intel/ibt-[0-9][0-9][0-9][0-9]-[0-9][0-9][0-9][0-9].ddc");
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Kind regards,
Pul
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v5 RESEND] Bluetooth: btintel: Correctly declare all module firmware files
2025-08-27 5:29 ` Paul Menzel
@ 2025-08-27 5:31 ` Paul Menzel
0 siblings, 0 replies; 4+ messages in thread
From: Paul Menzel @ 2025-08-27 5:31 UTC (permalink / raw)
To: Daan De Meyer
Cc: linux-bluetooth, stable, Luiz Augusto von Dentz, Marcel Holtmann
[Cc: Remove Dimitri’s bouncing address]
Am 27.08.25 um 07:29 schrieb Paul Menzel:
> Dear Daan,
>
>
> Thank you for the patch.
>
> Am 26.08.25 um 22:29 schrieb DaanDeMeyer:
>> From: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
>>
>> Strictly encode patterns of supported hw_variants of firmware files
>> the kernel driver supports requesting. This now includes many missing
>> and previously undeclared module firmware files for 0x07, 0x08,
>> 0x11-0x14, 0x17-0x1b hw_variants.
>>
>> This especially affects environments that only install firmware files
>> declared and referenced by the kernel modules. In such environments,
>> only the declared firmware files are copied resulting in most Intel
>> Bluetooth devices not working. I.e. host-only dracut-install initrds,
>> or Ubuntu Core kernel snaps.
>>
>> BugLink: https://bugs.launchpad.net/bugs/1970819
>> Cc: stable@vger.kernel.org # 4.15+
>> Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
>> ---
>> Notes:
>> Changes since v4:
>> - Add missing "intel/" prefix for 0x17+ firmware
>> - Add Cc stable for v4.15+ kernels
>> Changes since v3:
>> - Hopefully pacify trailing whitespace from GitLint in this optional
>> portion of the commit.
>> Changes since v2:
>> - encode patterns for 0x17 0x18 0x19 0x1b hw_variants
>> - rebase on top of latest rc tag
>> Changes since v1:
>> - encode strict patterns of supported firmware files for each of the
>> supported hw_variant generations.
>>
>> drivers/bluetooth/btintel.c | 26 ++++++++++++++++++++++----
>> 1 file changed, 22 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
>> index a657e9a3e96a..d0e22fe09567 100644
>> --- a/drivers/bluetooth/btintel.c
>> +++ b/drivers/bluetooth/btintel.c
>> @@ -2656,7 +2656,25 @@ MODULE_AUTHOR("Marcel Holtmann
>> <marcel@holtmann.org>");
>> MODULE_DESCRIPTION("Bluetooth support for Intel devices ver " VERSION);
>> MODULE_VERSION(VERSION);
>> MODULE_LICENSE("GPL");
>> -MODULE_FIRMWARE("intel/ibt-11-5.sfi");
>> -MODULE_FIRMWARE("intel/ibt-11-5.ddc");
>> -MODULE_FIRMWARE("intel/ibt-12-16.sfi");
>> -MODULE_FIRMWARE("intel/ibt-12-16.ddc");
>> +/* hw_variant 0x07 0x08 */
>> +MODULE_FIRMWARE("intel/ibt-hw-37.7.*-fw-*.*.*.*.*.bseq");
>> +MODULE_FIRMWARE("intel/ibt-hw-37.7.bseq");
>> +MODULE_FIRMWARE("intel/ibt-hw-37.8.*-fw-*.*.*.*.*.bseq");
>> +MODULE_FIRMWARE("intel/ibt-hw-37.8.bseq");
>> +/* hw_variant 0x0b 0x0c */
>> +MODULE_FIRMWARE("intel/ibt-11-*.sfi");
>> +MODULE_FIRMWARE("intel/ibt-12-*.sfi");
>> +MODULE_FIRMWARE("intel/ibt-11-*.ddc");
>> +MODULE_FIRMWARE("intel/ibt-12-*.ddc");
>> +/* hw_variant 0x11 0x12 0x13 0x14 */
>> +MODULE_FIRMWARE("intel/ibt-17-*-*.sfi");
>> +MODULE_FIRMWARE("intel/ibt-18-*-*.sfi");
>> +MODULE_FIRMWARE("intel/ibt-19-*-*.sfi");
>> +MODULE_FIRMWARE("intel/ibt-20-*-*.sfi");
>> +MODULE_FIRMWARE("intel/ibt-17-*-*.ddc");
>> +MODULE_FIRMWARE("intel/ibt-18-*-*.ddc");
>> +MODULE_FIRMWARE("intel/ibt-19-*-*.ddc");
>> +MODULE_FIRMWARE("intel/ibt-20-*-*.ddc");
>> +/* hw_variant 0x17 0x18 0x19 0x1b, read and use cnvi/cnvr */
>> +MODULE_FIRMWARE("intel/ibt-[0-9][0-9][0-9][0-9]-[0-9][0-9][0-9][0-9].sfi");
>> +MODULE_FIRMWARE("intel/ibt-[0-9][0-9][0-9][0-9]-[0-9][0-9][0-9][0-9].ddc");
>
> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
>
>
> Kind regards,
>
> Paul
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-08-27 5:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-26 19:42 [PATCH v5] Bluetooth: btintel: Correctly declare all module firmware files DaanDeMeyer
2025-08-26 20:29 ` [PATCH v5 RESEND] " DaanDeMeyer
2025-08-27 5:29 ` Paul Menzel
2025-08-27 5:31 ` Paul Menzel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).