Re: [PATCH 5.15 000/120] 5.15.82-rc1 review

Daniel Díaz
2022-12-06T00:04:53Z

Hello!

On Mon, 5 Dec 2022 at 13:33, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> This is the start of the stable review cycle for the 5.15.82 release.
> There are 120 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 07 Dec 2022 19:07:46 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.82-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
> -------------
> Pseudo-Shortlog of commits:
>
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Linux 5.15.82-rc1
[...]
> Guo Ren <guoren@linux.alibaba.com>
> riscv: kexec: Fixup crash_smp_send_stop without multi cores
[...]

We have found regression with RISC V with GCC 8 and 11:
-----8<----------8<----------8<-----
/builds/linux/arch/riscv/kernel/smp.c: In function 'handle_IPI':
/builds/linux/arch/riscv/kernel/smp.c:195:44: error: 'cpu' undeclared
(first use in this function)
195 | ipi_cpu_crash_stop(cpu, get_irq_regs());
| ^~~
/builds/linux/arch/riscv/kernel/smp.c:195:44: note: each undeclared
identifier is reported only once for each function it appears in
/builds/linux/arch/riscv/kernel/smp.c:217:22: error: 'old_regs'
undeclared (first use in this function)
217 | set_irq_regs(old_regs);
| ^~~~~~~~
make[3]: *** [/builds/linux/scripts/Makefile.build:289:
arch/riscv/kernel/smp.o] Error 1
make[3]: Target '__build' not remade because of errors.
make[2]: *** [/builds/linux/scripts/Makefile.build:552:
arch/riscv/kernel] Error 2
make[2]: Target '__build' not remade because of errors.
make[1]: *** [/builds/linux/Makefile:1900: arch/riscv] Error 2
make[1]: Target '__all' not remade because of errors.
make: *** [Makefile:219: __sub-make] Error 2
----->8---------->8---------->8-----

Bisection points to the above commit ("riscv: kexec: Fixup
crash_smp_send_stop without multi cores"). Reverting it makes the
build pass.

In order to reproduce:
# See https://docs.tuxmake.org/ for complete documentation.
# Original tuxmake command with fragments listed below.
tuxmake --runtime podman --target-arch riscv --toolchain gcc-11
--kconfig defconfig

Greetings!

Daniel Díaz
daniel.diaz@linaro.org