From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49DABC4332F for ; Mon, 12 Dec 2022 13:45:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233018AbiLLNpr (ORCPT ); Mon, 12 Dec 2022 08:45:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233000AbiLLNpX (ORCPT ); Mon, 12 Dec 2022 08:45:23 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 934D714D2E for ; Mon, 12 Dec 2022 05:44:39 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id CB832CE0EFC for ; Mon, 12 Dec 2022 13:44:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 979B1C433EF; Mon, 12 Dec 2022 13:44:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1670852676; bh=a16utpOjsrL6ez7rzp76cnUx7fL7wLkHcVMwLoxXqwA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nzzuFqaA5iJuXBum5UzNoy4lixPFWhN86sgsNSJ4aQWAFpNsylWydfTSbCS98ZWZV O5GkK52CdWyE+8D2d/hTNjeiA8/hD7nYJcxawj06M6IhxJh639wgPy/tPN8FY52mGF /PIacIBxk8W3r+meJnSYX5HHlsdwad9QX0yjoGR0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wang Yufen , Bartosz Golaszewski , Sasha Levin Subject: [PATCH 6.0 130/157] gpio/rockchip: fix refcount leak in rockchip_gpiolib_register() Date: Mon, 12 Dec 2022 14:17:58 +0100 Message-Id: <20221212130940.129172628@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221212130934.337225088@linuxfoundation.org> References: <20221212130934.337225088@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Wang Yufen [ Upstream commit 63ff545af73f759d1bd04198af8ed8577fb739fc ] The node returned by of_get_parent() with refcount incremented, of_node_put() needs be called when finish using it. So add it in the end of of_pinctrl_get(). Fixes: 936ee2675eee ("gpio/rockchip: add driver for rockchip gpio") Signed-off-by: Wang Yufen Signed-off-by: Bartosz Golaszewski Signed-off-by: Sasha Levin --- drivers/gpio/gpio-rockchip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c index 9c976ad7208e..09cfb49ed998 100644 --- a/drivers/gpio/gpio-rockchip.c +++ b/drivers/gpio/gpio-rockchip.c @@ -621,6 +621,7 @@ static int rockchip_gpiolib_register(struct rockchip_pin_bank *bank) return -ENODATA; pctldev = of_pinctrl_get(pctlnp); + of_node_put(pctlnp); if (!pctldev) return -ENODEV; -- 2.35.1