From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74889C3DA7B for ; Sun, 18 Dec 2022 17:07:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231305AbiLRRH4 (ORCPT ); Sun, 18 Dec 2022 12:07:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233426AbiLRRG2 (ORCPT ); Sun, 18 Dec 2022 12:06:28 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A43E13D15; Sun, 18 Dec 2022 08:22:40 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EAF6EB801C0; Sun, 18 Dec 2022 16:22:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27C75C433EF; Sun, 18 Dec 2022 16:22:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671380557; bh=CuB0pMaf5n0eTWneMwo14eXVHXl3th6l6lN7Qux1r1k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NNDL6ZHgHDknVwxFIeaOq89+vTqhs9Y+vCUi4zAk5f4DSkUT6QkOthJutTf1qulUK HB21Dj8bUQunL/9GJ2FnmNJvh0koG/tm22qcDAWGDMSWvHh8dWdxzd7R708qIcYGv6 XJRJ+Y/3QZSyA/1L0rWgQJLLjsK1KCOdOsjMk7fXHBNiJKS+lgKXYfP+1/W25xJl1M QN9t8x6TAw7Df9Xp9XAMxQVsdW5eHsDa4TuNo22SPOt4whtQZ2VVMzaUx6Yt0kqjsY KzEAJb8yS6M5Ol6bo+3mi0L7ZYEesKzqh9FydQhpgiigI3Mjf3GAXMv/62RLpmt9j0 SpgIDgp9E8KYw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yan Lei , Mauro Carvalho Chehab , Sasha Levin , linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 17/23] media: dvb-frontends: fix leak of memory fw Date: Sun, 18 Dec 2022 11:21:43 -0500 Message-Id: <20221218162149.935047-17-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221218162149.935047-1-sashal@kernel.org> References: <20221218162149.935047-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Yan Lei [ Upstream commit a15fe8d9f1bf460a804bcf18a890bfd2cf0d5caa ] Link: https://lore.kernel.org/linux-media/20220410061925.4107-1-chinayanlei2002@163.com Signed-off-by: Yan Lei Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/dvb-frontends/bcm3510.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/dvb-frontends/bcm3510.c b/drivers/media/dvb-frontends/bcm3510.c index ba63ad170d3c..87684610f59e 100644 --- a/drivers/media/dvb-frontends/bcm3510.c +++ b/drivers/media/dvb-frontends/bcm3510.c @@ -649,6 +649,7 @@ static int bcm3510_download_firmware(struct dvb_frontend* fe) deb_info("firmware chunk, addr: 0x%04x, len: 0x%04x, total length: 0x%04zx\n",addr,len,fw->size); if ((ret = bcm3510_write_ram(st,addr,&b[i+4],len)) < 0) { err("firmware download failed: %d\n",ret); + release_firmware(fw); return ret; } i += 4 + len; -- 2.35.1