From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1DFAC4332F for ; Sun, 18 Dec 2022 17:08:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233419AbiLRRIL (ORCPT ); Sun, 18 Dec 2022 12:08:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233385AbiLRRGn (ORCPT ); Sun, 18 Dec 2022 12:06:43 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77D4E12D17; Sun, 18 Dec 2022 08:23:05 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 149BF60C99; Sun, 18 Dec 2022 16:23:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71EB6C433D2; Sun, 18 Dec 2022 16:23:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671380584; bh=3WqGSj+1m0F3VlMTs7183wM7F30z46aKwTvbELsoDwg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Lfkv4nhKVnfLJyaVNLOc+jd/LPq0yZx/6ccKLY7omFdLPLN6k6eWw1tAoz5sTRO0R K9B7FMyFnEp1glErIogjlaE6W9NZpHP3J+12Komppgbwyawtb+FazWb70M6D8V2r0C PDLH+Jl/E07VKmHZtF0RYga7kphW+Nf8Pxi64+RoZGsgtMND/DvcDWZZMhMgG/Bh2R cnV50OXZf5QmNvf7/SOXXv6NEt6eMaL3LijiUbdkqu966NXdJDgMi49Fnc1PuGUTPB bBKfs7JlOvcWW0PqNTNbis2cWsXaUZm8PYtw9gQNPZRxYHWjCvuMxKPwJAuJ4W2MpB z0gwL/oO809Zg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Xiu Jianfeng , Patrice Chotard , Stephen Boyd , Sasha Levin , mturquette@baylibre.com, windhl@126.com, avolmat@me.com, linux-clk@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 23/23] clk: st: Fix memory leak in st_of_quadfs_setup() Date: Sun, 18 Dec 2022 11:21:49 -0500 Message-Id: <20221218162149.935047-23-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221218162149.935047-1-sashal@kernel.org> References: <20221218162149.935047-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Xiu Jianfeng [ Upstream commit cfd3ffb36f0d566846163118651d868e607300ba ] If st_clk_register_quadfs_pll() fails, @lock should be freed before goto @err_exit, otherwise will cause meory leak issue, fix it. Signed-off-by: Xiu Jianfeng Link: https://lore.kernel.org/r/20221122133614.184910-1-xiujianfeng@huawei.com Reviewed-by: Patrice Chotard Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/st/clkgen-fsyn.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/clk/st/clkgen-fsyn.c b/drivers/clk/st/clkgen-fsyn.c index 14819d919df1..715c5d3a5cde 100644 --- a/drivers/clk/st/clkgen-fsyn.c +++ b/drivers/clk/st/clkgen-fsyn.c @@ -948,9 +948,10 @@ static void __init st_of_quadfs_setup(struct device_node *np, clk = st_clk_register_quadfs_pll(pll_name, clk_parent_name, data, reg, lock); - if (IS_ERR(clk)) + if (IS_ERR(clk)) { + kfree(lock); goto err_exit; - else + } else pr_debug("%s: parent %s rate %u\n", __clk_get_name(clk), __clk_get_name(clk_get_parent(clk)), -- 2.35.1