From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD353C46467 for ; Tue, 27 Dec 2022 20:44:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231426AbiL0Unb (ORCPT ); Tue, 27 Dec 2022 15:43:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233108AbiL0UmR (ORCPT ); Tue, 27 Dec 2022 15:42:17 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3649FCD7; Tue, 27 Dec 2022 12:35:48 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DBFE261237; Tue, 27 Dec 2022 20:35:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84BCFC433EF; Tue, 27 Dec 2022 20:35:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672173338; bh=MJeq5eQ4fUfbLkecCB1iu+hdC7ESIAwkHUedRxC6MlI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U16quylvTiSxiAkUpGAtQ28Lp/dH1HTlYPuYWA2wdRhp+w3GM/BUc2LprT137uHIj iYPGl95WYw8k5NQIUdA/xC81304N9dFShtByjpcmxulsfNe0ly+eegaOcHPROJIqgt YnA7GHfR8QSCyvwI3gqiU/DlFo1WDtp3O6u23Dhp15P+hH39nlWvaq2lHjveCKu2nv VkLqO3vmidb9MJNz2l66AZ0FA6Wtcb5wPzajpRZaCGEPFT8BdVdz7avetom7cTtLAF SYOPfvb7x8WNZdmxn7lZq9ogvWca4wHZrtL2KL+SwzZB1mpbFqDH6jv+na4qMlPejU kPb65R0fIQHcQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Christophe Leroy , "Naveen N . Rao" , Josh Poimboeuf , Peter Zijlstra , Michael Ellerman , Sasha Levin Subject: [PATCH AUTOSEL 5.4 2/7] objtool: Fix SEGFAULT Date: Tue, 27 Dec 2022 15:35:27 -0500 Message-Id: <20221227203534.1214640-2-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221227203534.1214640-1-sashal@kernel.org> References: <20221227203534.1214640-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Christophe Leroy [ Upstream commit efb11fdb3e1a9f694fa12b70b21e69e55ec59c36 ] find_insn() will return NULL in case of failure. Check insn in order to avoid a kernel Oops for NULL pointer dereference. Tested-by: Naveen N. Rao Reviewed-by: Naveen N. Rao Acked-by: Josh Poimboeuf Acked-by: Peter Zijlstra (Intel) Signed-off-by: Christophe Leroy Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20221114175754.1131267-9-sv@linux.ibm.com Signed-off-by: Sasha Levin --- tools/objtool/check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index bae6b261481d..ccf5580442d2 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -162,7 +162,7 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func, return false; insn = find_insn(file, func->sec, func->offset); - if (!insn->func) + if (!insn || !insn->func) return false; func_for_each_insn_all(file, func, insn) { -- 2.35.1