From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED788C4167B for ; Wed, 28 Dec 2022 15:56:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234177AbiL1P4l (ORCPT ); Wed, 28 Dec 2022 10:56:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234178AbiL1P4k (ORCPT ); Wed, 28 Dec 2022 10:56:40 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8842E1409F for ; Wed, 28 Dec 2022 07:56:39 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2654961560 for ; Wed, 28 Dec 2022 15:56:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36AEAC433D2; Wed, 28 Dec 2022 15:56:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1672242998; bh=lpQ8B1U73HEGKoTlv0d+gH6ZvNC31CO0SaHYvF7Sh54=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U02PgAeUQCCdF0LCWBazIrTtXGS80nuF0F1bS/Br0cvx3lvoah1+CwPqnGFpV3qSP fzRbgi9aNZ6x+y59Flu9nbXOvgKq/+aUJ+sm0pqwiJWYTdoaF7Ur+Gw0jlUgZl2aQj R+HfVYRzkis0IBWjotLFekDROoJRFdezWSSSA9mg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Miaoqian Lin , Daniel Borkmann , Sasha Levin Subject: [PATCH 6.0 0477/1073] bpftool: Fix memory leak in do_build_table_cb Date: Wed, 28 Dec 2022 15:34:25 +0100 Message-Id: <20221228144340.992943949@linuxfoundation.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20221228144328.162723588@linuxfoundation.org> References: <20221228144328.162723588@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Miaoqian Lin [ Upstream commit fa55ef14ef4fe06198c0ce811b603aec24134bc2 ] strdup() allocates memory for path. We need to release the memory in the following error path. Add free() to avoid memory leak. Fixes: 8f184732b60b ("bpftool: Switch to libbpf's hashmap for pinned paths of BPF objects") Signed-off-by: Miaoqian Lin Signed-off-by: Daniel Borkmann Link: https://lore.kernel.org/bpf/20221206071906.806384-1-linmq006@gmail.com Signed-off-by: Sasha Levin --- tools/bpf/bpftool/common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/bpf/bpftool/common.c b/tools/bpf/bpftool/common.c index 3bdbc0ce75b1..e54487e4005d 100644 --- a/tools/bpf/bpftool/common.c +++ b/tools/bpf/bpftool/common.c @@ -499,6 +499,7 @@ static int do_build_table_cb(const char *fpath, const struct stat *sb, if (err) { p_err("failed to append entry to hashmap for ID %u, path '%s': %s", pinned_info.id, path, strerror(errno)); + free(path); goto out_close; } -- 2.35.1