From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3CF0C54EBF for ; Wed, 28 Dec 2022 16:23:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234679AbiL1QXO (ORCPT ); Wed, 28 Dec 2022 11:23:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234896AbiL1QW2 (ORCPT ); Wed, 28 Dec 2022 11:22:28 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B05D1A223 for ; Wed, 28 Dec 2022 08:20:05 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E08D0B81707 for ; Wed, 28 Dec 2022 16:20:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D130C433F0; Wed, 28 Dec 2022 16:20:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1672244402; bh=ysI6Yb/OMNb8xwQASwMNiKfVXdjs+etqZlgyn2qb+MY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2uVsur+/eMiNP7QqYIa1gU4fU8C0kS/qFVDNVbBiXXda0kRItte+IiZLFcXlDt0Ou RLUL8lskrYYyGJH1/Il9SvpqT/DUZg1kG0PABm4Iig1rZHZi3jsr7lyaaM6bv5acbJ 47VtxYJbNg3oPNSq0o/vrIiGgipIVOOx09Tp+mkE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Beau Belgrave , "Steven Rostedt (Google)" , Sasha Levin Subject: [PATCH 6.0 0704/1073] tracing/user_events: Fix call print_fmt leak Date: Wed, 28 Dec 2022 15:38:12 +0100 Message-Id: <20221228144347.154176363@linuxfoundation.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20221228144328.162723588@linuxfoundation.org> References: <20221228144328.162723588@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Beau Belgrave [ Upstream commit 4bded7af8b9af6e97514b0521004f90267905aef ] If user_event_trace_register() fails within user_event_parse() the call's print_fmt member is not freed. Add kfree call to fix this. Link: https://lkml.kernel.org/r/20221123183248.554-1-beaub@linux.microsoft.com Fixes: aa3b2b4c6692 ("user_events: Add print_fmt generation support for basic types") Signed-off-by: Beau Belgrave Signed-off-by: Steven Rostedt (Google) Signed-off-by: Sasha Levin --- kernel/trace/trace_events_user.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_user.c index a6621c52ce45..b885b6934893 100644 --- a/kernel/trace/trace_events_user.c +++ b/kernel/trace/trace_events_user.c @@ -1127,6 +1127,7 @@ static int user_event_parse(char *name, char *args, char *flags, put_user: user_event_destroy_fields(user); user_event_destroy_validators(user); + kfree(user->call.print_fmt); kfree(user); return ret; } -- 2.35.1