From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E380CC46467 for ; Mon, 16 Jan 2023 17:28:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234762AbjAPR23 (ORCPT ); Mon, 16 Jan 2023 12:28:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234672AbjAPR15 (ORCPT ); Mon, 16 Jan 2023 12:27:57 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FCEC41B73 for ; Mon, 16 Jan 2023 09:04:52 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 37426B810A0 for ; Mon, 16 Jan 2023 17:04:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7AD7AC433D2; Mon, 16 Jan 2023 17:04:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1673888689; bh=OamEo90pKqOyzsGlytq3uZloKmX9IZyH4Cayp8iHaBk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ezM7mcZJ+fd//UPMz7n5Jl0QDfVDQq9WA2GZAZspuqDk5WelckgF4ac0iqooDJcuo 0zqTNrVbpkK3bpR09nLoZEwtEymneWnYjI7mpAHSVvv35WLr5tyO5ksojK525pwKBj P8mGY6+U6hHObWqJit7AsaaUwAEXfB0TWlVfRH/0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wang ShaoBo , Trond Myklebust , Sasha Levin Subject: [PATCH 4.14 101/338] SUNRPC: Fix missing release socket in rpc_sockname() Date: Mon, 16 Jan 2023 16:49:34 +0100 Message-Id: <20230116154825.288168809@linuxfoundation.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230116154820.689115727@linuxfoundation.org> References: <20230116154820.689115727@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Wang ShaoBo [ Upstream commit 50fa355bc0d75911fe9d5072a5ba52cdb803aff7 ] socket dynamically created is not released when getting an unintended address family type in rpc_sockname(), direct to out_release for calling sock_release(). Fixes: 2e738fdce22f ("SUNRPC: Add API to acquire source address") Signed-off-by: Wang ShaoBo Signed-off-by: Trond Myklebust Signed-off-by: Sasha Levin --- net/sunrpc/clnt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c index 9259529e0412..411925b043cc 100644 --- a/net/sunrpc/clnt.c +++ b/net/sunrpc/clnt.c @@ -1267,7 +1267,7 @@ static int rpc_sockname(struct net *net, struct sockaddr *sap, size_t salen, break; default: err = -EAFNOSUPPORT; - goto out; + goto out_release; } if (err < 0) { dprintk("RPC: can't bind UDP socket (%d)\n", err); -- 2.35.1