From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 761C1C54EBE for ; Mon, 16 Jan 2023 17:00:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234146AbjAPRAj (ORCPT ); Mon, 16 Jan 2023 12:00:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234170AbjAPQ7z (ORCPT ); Mon, 16 Jan 2023 11:59:55 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8723B3D09E for ; Mon, 16 Jan 2023 08:42:48 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 312A8B8105D for ; Mon, 16 Jan 2023 16:42:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81B17C433D2; Mon, 16 Jan 2023 16:42:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1673887365; bh=SohpHrGhbc92g3VzqL+5JVAh+8owYOdixOXXxBJu6uU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=StpxHFQ8zobvulBsaqq6qmRI5Cz6hyWU2PfVWJaNYqWWrycK4myYui80YRJtWINq7 oZKDpKYDCIQJgEOzOcy/jyrXLEckfCO4Vr1+vZXIsxldaXZ6HYf7XtXrCwKrzRJpCG +cRvHLBz7ZKwyOhPy4pzWc2T6ddRkISd2PCN8fho= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zhang Zekun , Thierry Reding , Sasha Levin Subject: [PATCH 4.19 121/521] drm/tegra: Add missing clk_disable_unprepare() in tegra_dc_probe() Date: Mon, 16 Jan 2023 16:46:23 +0100 Message-Id: <20230116154852.674523156@linuxfoundation.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230116154847.246743274@linuxfoundation.org> References: <20230116154847.246743274@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Zhang Zekun [ Upstream commit 7ad4384d53c67672a8720cdc2ef638d7d1710ab8 ] Add the missing clk_disable_unprepare() before return from tegra_dc_probe() in the error handling path. Fixes: f68ba6912bd2 ("drm/tegra: dc: Link DC1 to DC0 on Tegra20") Signed-off-by: Zhang Zekun Signed-off-by: Thierry Reding Signed-off-by: Sasha Levin --- drivers/gpu/drm/tegra/dc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c index 03adb4cf325b..6c8b59a26675 100644 --- a/drivers/gpu/drm/tegra/dc.c +++ b/drivers/gpu/drm/tegra/dc.c @@ -2376,8 +2376,10 @@ static int tegra_dc_probe(struct platform_device *pdev) usleep_range(2000, 4000); err = reset_control_assert(dc->rst); - if (err < 0) + if (err < 0) { + clk_disable_unprepare(dc->clk); return err; + } usleep_range(2000, 4000); -- 2.35.1