From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2444C46467 for ; Mon, 16 Jan 2023 16:40:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233703AbjAPQkv (ORCPT ); Mon, 16 Jan 2023 11:40:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233487AbjAPQk2 (ORCPT ); Mon, 16 Jan 2023 11:40:28 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC02036B08 for ; Mon, 16 Jan 2023 08:28:37 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 15D18B8107A for ; Mon, 16 Jan 2023 16:28:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6EDD3C433EF; Mon, 16 Jan 2023 16:28:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1673886514; bh=MJeq5eQ4fUfbLkecCB1iu+hdC7ESIAwkHUedRxC6MlI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UrFiv8gLF9hmqmUD86mKxMvfrys0XAVaMHqsIzNRmdQjhaaa1W/apWmKIidNDVVV+ uIbvNz8l9E3Qcsqsx/WMuegEI42YeEb+ij4ttSJYHajgq5zipB0+AOsiAWSJ1qLrUP 2ehlTZBp0E4WWJqDjfm/HJqHalSom5pOQF4aHczE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, "Naveen N. Rao" , Josh Poimboeuf , "Peter Zijlstra (Intel)" , Christophe Leroy , Michael Ellerman , Sasha Levin Subject: [PATCH 5.4 460/658] objtool: Fix SEGFAULT Date: Mon, 16 Jan 2023 16:49:08 +0100 Message-Id: <20230116154930.544647940@linuxfoundation.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230116154909.645460653@linuxfoundation.org> References: <20230116154909.645460653@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Christophe Leroy [ Upstream commit efb11fdb3e1a9f694fa12b70b21e69e55ec59c36 ] find_insn() will return NULL in case of failure. Check insn in order to avoid a kernel Oops for NULL pointer dereference. Tested-by: Naveen N. Rao Reviewed-by: Naveen N. Rao Acked-by: Josh Poimboeuf Acked-by: Peter Zijlstra (Intel) Signed-off-by: Christophe Leroy Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20221114175754.1131267-9-sv@linux.ibm.com Signed-off-by: Sasha Levin --- tools/objtool/check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index bae6b261481d..ccf5580442d2 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -162,7 +162,7 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func, return false; insn = find_insn(file, func->sec, func->offset); - if (!insn->func) + if (!insn || !insn->func) return false; func_for_each_insn_all(file, func, insn) { -- 2.35.1