From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A327CC38147 for ; Wed, 18 Jan 2023 16:03:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231226AbjARQD4 (ORCPT ); Wed, 18 Jan 2023 11:03:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229881AbjARQDg (ORCPT ); Wed, 18 Jan 2023 11:03:36 -0500 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9658C577EB for ; Wed, 18 Jan 2023 07:59:29 -0800 (PST) Received: by mail-pg1-x533.google.com with SMTP id v3so24831648pgh.4 for ; Wed, 18 Jan 2023 07:59:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=TkK91UFziEYA9a0PZy5wDygMUGAdbCISJG9fWIp70W4=; b=B3LhbX+uC9VzWniTeiFC79j4cyksKvOBeF4ERJMLzjJAJ0kBEKMPqSqRjrT/PPOBoE ki9tKLE3N6oMuvkXouwydXttMR+4yu7mmc6xcUF7WUSNjprswDMU8YQMaTaV4C7gfcYg NW8z8gOLN9N748d7ZTV73rnDaILNR13zUo13778t0tYnUz/dsVTjywUqPRcCI6BiW+mP kvmxVQXOdOFUATNJTmHZjTdUK59QSwidGlSvz29HDI02oR2C9i9v7v9vBYMvFke9dgis NPPEe/vGhaXRoxy2WsWSCENrwZIj3rZU8NlD2AJ41cgl1FjCoqLGBN1ESYJNX4whhMY+ V8LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TkK91UFziEYA9a0PZy5wDygMUGAdbCISJG9fWIp70W4=; b=hAfr5pRoPhpGZNg7eLZsOIRMQ2MZhOuoXOM5gKD5PnfXPjhoALKDyKa9DT1IE8Zxgk IcnXuWgesnwH4iOeMoC9sbweG+XofLLT4pSl0KzFTS8Xb50wtp0gjKalJQnRe4Pt8U6g Bcu18F85vfR1F9zKW/rLMcUfMWheSRbqHlROSsPNpGT/NaG15FqL5WqZ/+Gv5Jj4ZhAw 2nPRpORQl8f1mjVQd35bgnn7yChdJxchIzeT3NrRjfZetMWAMAA9k/qCz16Cg0aU9nul K9hUyspkpR+iKBPQ6ih9PueRetfPTdkdi/QfQDmBXOOQSsJGsHMwfJHI6NNNWIR/HH6X gPYQ== X-Gm-Message-State: AFqh2koZfwphLC+vT2/jh0Cmz5i+TbaZ57+L3zjucWIYMphamFifLvY6 T0WIDxguz3pkhNfdpk7N9g7w X-Google-Smtp-Source: AMrXdXs1YhdyWPpUeoWW8QBJn7XDi2Fy1FHiKv4FDAWn2Ny4J26ydTlpU1GMFDCzrstItkpN1RREqQ== X-Received: by 2002:aa7:9614:0:b0:58b:b9cc:5724 with SMTP id q20-20020aa79614000000b0058bb9cc5724mr21956409pfg.15.1674057568997; Wed, 18 Jan 2023 07:59:28 -0800 (PST) Received: from thinkpad ([27.111.75.61]) by smtp.gmail.com with ESMTPSA id s2-20020a625e02000000b0057ef155103asm20699260pfb.155.2023.01.18.07.59.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Jan 2023 07:59:28 -0800 (PST) Date: Wed, 18 Jan 2023 21:29:19 +0530 From: Manivannan Sadhasivam To: Krzysztof Kozlowski Cc: andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, bp@alien8.de, tony.luck@intel.com, quic_saipraka@quicinc.com, konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, james.morse@arm.com, mchehab@kernel.org, rric@kernel.org, linux-edac@vger.kernel.org, quic_ppareek@quicinc.com, luca.weiss@fairphone.com, ahalaney@redhat.com, steev@kali.org, stable@vger.kernel.org Subject: Re: [PATCH v6 17/17] soc: qcom: llcc: Do not create EDAC platform device on SDM845 Message-ID: <20230118155919.GD4690@thinkpad> References: <20230118150904.26913-1-manivannan.sadhasivam@linaro.org> <20230118150904.26913-18-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Jan 18, 2023 at 04:37:29PM +0100, Krzysztof Kozlowski wrote: > On 18/01/2023 16:09, Manivannan Sadhasivam wrote: > > The platforms based on SDM845 SoC locks the access to EDAC registers in the > > bootloader. So probing the EDAC driver will result in a crash. Hence, > > disable the creation of EDAC platform device on all SDM845 devices. > > > > The issue has been observed on Lenovo Yoga C630 and DB845c. > > > > Cc: # 5.10 > > Reported-by: Steev Klimaszewski > > Signed-off-by: Manivannan Sadhasivam > > --- > > drivers/soc/qcom/llcc-qcom.c | 17 ++++++++++++----- > > 1 file changed, 12 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c > > index 7b7c5a38bac6..8d840702df50 100644 > > --- a/drivers/soc/qcom/llcc-qcom.c > > +++ b/drivers/soc/qcom/llcc-qcom.c > > @@ -1012,11 +1012,18 @@ static int qcom_llcc_probe(struct platform_device *pdev) > > > > drv_data->ecc_irq = platform_get_irq_optional(pdev, 0); > > > > - llcc_edac = platform_device_register_data(&pdev->dev, > > - "qcom_llcc_edac", -1, drv_data, > > - sizeof(*drv_data)); > > - if (IS_ERR(llcc_edac)) > > - dev_err(dev, "Failed to register llcc edac driver\n"); > > + /* > > + * The platforms based on SDM845 SoC locks the access to EDAC registers > > + * in bootloader. So probing the EDAC driver will result in a crash. > > + * Hence, disable the creation of EDAC platform device on SDM845. > > + */ > > + if (!of_device_is_compatible(dev->of_node, "qcom,sdm845-llcc")) { > > Don't spread of_device_is_compatible() in driver code. You have driver > data for this. > Yeah, but there is no ID to in the driver data to identify an SoC. I could add one but is that really worth doing so? Is using of_device_is_compatible() in drivers discouraged nowadays? Thanks, Mani > Best regards, > Krzysztof > -- மணிவண்ணன் சதாசிவம்