From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C248AC7EE30 for ; Fri, 3 Mar 2023 21:47:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232356AbjCCVrO (ORCPT ); Fri, 3 Mar 2023 16:47:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232314AbjCCVqa (ORCPT ); Fri, 3 Mar 2023 16:46:30 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA5E76421E; Fri, 3 Mar 2023 13:44:33 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0D76F6194C; Fri, 3 Mar 2023 21:44:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A81EC4339C; Fri, 3 Mar 2023 21:44:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677879872; bh=KRBEIVoE9JmHAOpRSWS3UjsvllJYFulQOA9LVXLoDQc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BU7fNcWAW8uEKI9IHrjVqgPCXU1Pi3BioPYmRh6XYaeHZsRGHFT+MGXAlVIElN6S0 Qfv9eHbGbyWU5joyXkx6Ilr8qZBi/2HTY/RLlo8Nx8ix9r143NmdnVOBlUjuoWc4Kz 8mKPA/p6o4A1vdhBfPqLpWtBZLehsAccAEQznmMJBQV/oMeEQqsr6zRDjyni5RXq7f JTu42wC+BWSC7V+ueZVemzYZd3GCXBBxbPJZDl+KScweVhVXZ5jpnNoLIjm8uKM85S G0EiZrps9/RLRq7gDu4u2UNsHhQkNcqw15WGSsYi4yv38h2EfDQZmwMG1dJ87ivX6q k9FvFFI4Bgy3Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Greg Kroah-Hartman , Kevin Cernekee , Sasha Levin , linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 6.1 35/60] USB: gadget: bcm63xx_udc: fix memory leak with using debugfs_lookup() Date: Fri, 3 Mar 2023 16:42:49 -0500 Message-Id: <20230303214315.1447666-35-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230303214315.1447666-1-sashal@kernel.org> References: <20230303214315.1447666-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Greg Kroah-Hartman [ Upstream commit a91c99b1fe5c6f7e52fb932ad9e57ec7cfe913ec ] When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time. To make things simpler, just call debugfs_lookup_and_remove() instead which handles all of the logic at once. Cc: Kevin Cernekee Link: https://lore.kernel.org/r/20230202153235.2412790-9-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/gadget/udc/bcm63xx_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/bcm63xx_udc.c b/drivers/usb/gadget/udc/bcm63xx_udc.c index d04d72f5816e6..8d58928913007 100644 --- a/drivers/usb/gadget/udc/bcm63xx_udc.c +++ b/drivers/usb/gadget/udc/bcm63xx_udc.c @@ -2258,7 +2258,7 @@ static void bcm63xx_udc_init_debugfs(struct bcm63xx_udc *udc) */ static void bcm63xx_udc_cleanup_debugfs(struct bcm63xx_udc *udc) { - debugfs_remove(debugfs_lookup(udc->gadget.name, usb_debug_root)); + debugfs_lookup_and_remove(udc->gadget.name, usb_debug_root); } /*********************************************************************** -- 2.39.2