From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FEF6C7EE33 for ; Fri, 3 Mar 2023 21:56:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233134AbjCCV4B (ORCPT ); Fri, 3 Mar 2023 16:56:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233132AbjCCVyq (ORCPT ); Fri, 3 Mar 2023 16:54:46 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CCC869CD6; Fri, 3 Mar 2023 13:48:36 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C94D6B81A06; Fri, 3 Mar 2023 21:46:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB5DCC433A8; Fri, 3 Mar 2023 21:46:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677879988; bh=cLpGKzR9oXYwKmGmS61ejIZhP4XCNmu/Ru+Ow1oZKpg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MByGULrGmqvHGTPAtZc3h+gxdo+Pro2h6I6982+xbIguE9gDssdIdYZR7D4MB+jtU SLkKMoI6g/fuq1za3FRJsFD34H/laLE5R+gqafsLNuIXmHqKSf/vIUr7Ykvyk6cA+G lldRyfpb0fjwdn5jVZmnuoSBC0dpLC65f+aZD3nz5U9HQLb6zd7anzO+WaBgbD9XGR PVyCdEoX2esgxlsjtZ1Y151WErltPWvpVcYRA9tFCBJ2IcWzya4mXQYnxd5ag5Tf/D aJl0cSRrWoli+gtE1EPYic5A/BGUpAnCLSKKx2ViSKYnbg4cxuNcmVmlSTkZam3JBw BRGpoKphR6MEQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Greg Kroah-Hartman , Olav Kongas , Sasha Levin , linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 26/50] USB: isp116x: fix memory leak with using debugfs_lookup() Date: Fri, 3 Mar 2023 16:45:07 -0500 Message-Id: <20230303214531.1450154-26-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230303214531.1450154-1-sashal@kernel.org> References: <20230303214531.1450154-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Greg Kroah-Hartman [ Upstream commit a95f62d5813facbec20ec087472eb313ee5fa8af ] When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time. To make things simpler, just call debugfs_lookup_and_remove() instead which handles all of the logic at once. Cc: Olav Kongas Link: https://lore.kernel.org/r/20230202153235.2412790-6-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/host/isp116x-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/isp116x-hcd.c b/drivers/usb/host/isp116x-hcd.c index 8c7f0991c21b5..9c3e12f2f25d8 100644 --- a/drivers/usb/host/isp116x-hcd.c +++ b/drivers/usb/host/isp116x-hcd.c @@ -1206,7 +1206,7 @@ static void create_debug_file(struct isp116x *isp116x) static void remove_debug_file(struct isp116x *isp116x) { - debugfs_remove(debugfs_lookup(hcd_name, usb_debug_root)); + debugfs_lookup_and_remove(hcd_name, usb_debug_root); } #else -- 2.39.2