From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B61FDC61DA3 for ; Fri, 3 Mar 2023 22:36:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232177AbjCCWgO (ORCPT ); Fri, 3 Mar 2023 17:36:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232342AbjCCWgB (ORCPT ); Fri, 3 Mar 2023 17:36:01 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAEE712583; Fri, 3 Mar 2023 14:33:35 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0BFA361922; Fri, 3 Mar 2023 21:46:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9BAA7C4339C; Fri, 3 Mar 2023 21:46:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677880002; bh=WXPFuf2BUqghGATTpXNUiw35r1ss6M1T+j0ny9/nWz4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LpkK+hno2sDohmEaPdlva50l328M2fF+U0aqo1GW9CegMM+CuFzVvtdXiNeukXBBB CzZmwuPnKmfUtSMxYbUo7oH8WA1YrivaAbNyth9xbJvXsVp1t3zbHpkOJNFE2sjE5P nQgE7bfpgu3b94x1m+FqPWbVD/Bwev85zp2bKOdmunZQ8MTZIX9190mm7HqoPepFGP Smc9bzXIPvSZUWjznEf7wWnM8ty/V++IV2JdBeML7rs6z98JbrZzxIgDpgrwMipjAO DP8Rl7IgcjLaaFsk+GFBLcscrpOg36fuBl3kmoA+HWTPRd+UjtMmgKi4WJ677KqhBv 7sgpVqMcIjDFQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Greg Kroah-Hartman , Jakob Koschel , Miaoqian Lin , Vladimir Zapolskiy , Sasha Levin , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.15 30/50] USB: gadget: lpc32xx_udc: fix memory leak with using debugfs_lookup() Date: Fri, 3 Mar 2023 16:45:11 -0500 Message-Id: <20230303214531.1450154-30-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230303214531.1450154-1-sashal@kernel.org> References: <20230303214531.1450154-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Greg Kroah-Hartman [ Upstream commit e3965acaf3739fde9d74ad82979b46d37c6c208f ] When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time. To make things simpler, just call debugfs_lookup_and_remove() instead which handles all of the logic at once. Cc: Jakob Koschel Cc: Miaoqian Lin Acked-by: Vladimir Zapolskiy Link: https://lore.kernel.org/r/20230202153235.2412790-10-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/gadget/udc/lpc32xx_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c b/drivers/usb/gadget/udc/lpc32xx_udc.c index 865de8db998a9..ec0d3d74d66e2 100644 --- a/drivers/usb/gadget/udc/lpc32xx_udc.c +++ b/drivers/usb/gadget/udc/lpc32xx_udc.c @@ -532,7 +532,7 @@ static void create_debug_file(struct lpc32xx_udc *udc) static void remove_debug_file(struct lpc32xx_udc *udc) { - debugfs_remove(debugfs_lookup(debug_filename, NULL)); + debugfs_lookup_and_remove(debug_filename, NULL); } #else -- 2.39.2