From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D620C61DA3 for ; Fri, 3 Mar 2023 22:03:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233535AbjCCWDW (ORCPT ); Fri, 3 Mar 2023 17:03:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233569AbjCCWDA (ORCPT ); Fri, 3 Mar 2023 17:03:00 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E51E26544B; Fri, 3 Mar 2023 13:53:19 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5451161948; Fri, 3 Mar 2023 21:46:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B674C433A7; Fri, 3 Mar 2023 21:46:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677880018; bh=sI7Vzw2HWyJYJE3HrWAP/Fn2wxh8ry9jE7B8FVmBFxk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=apWDrZNug9/Vecg8/cjesjPY2MnEEJV4eM0kO4hcerMwzQcr0cIb1RUZQQoKuB0BI n3PrNi2FvCmkv3uNh2qIYieH2GsUIsPo29p4lxX26OVuNBq/or1GrzvgKpy8JVo8kG RnLPxZmBpR8Ig4ZEzER4/PmeIGDFMUcPl8rKfhPzIYCdbd1ME+cQxbW7pfNjtop29H nL6QcmNqxUo542q88X8yH0Pk8A1orqjaU/z9m3u5HdNKgEcY05eF88bQ8NlB5cFOg3 jrkn4h9o29gwgtkKP3cii+bmNedYx8vHlY/GKAAirhcYbf063+gqhKi1D0pFGce3fO 0RswyzysnTIqA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Greg Kroah-Hartman , Nadav Amit , VMware PV-Drivers Reviewers , Arnd Bergmann , Sasha Levin Subject: [PATCH AUTOSEL 5.15 40/50] misc: vmw_balloon: fix memory leak with using debugfs_lookup() Date: Fri, 3 Mar 2023 16:45:21 -0500 Message-Id: <20230303214531.1450154-40-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230303214531.1450154-1-sashal@kernel.org> References: <20230303214531.1450154-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Greg Kroah-Hartman [ Upstream commit 209cdbd07cfaa4b7385bad4eeb47e5ec1887d33d ] When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time. To make things simpler, just call debugfs_lookup_and_remove() instead which handles all of the logic at once. Cc: Nadav Amit Cc: VMware PV-Drivers Reviewers Cc: Arnd Bergmann Link: https://lore.kernel.org/r/20230202141100.2291188-1-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/misc/vmw_balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c index f1d8ba6d48574..dab8ad9fed6b3 100644 --- a/drivers/misc/vmw_balloon.c +++ b/drivers/misc/vmw_balloon.c @@ -1711,7 +1711,7 @@ static void __init vmballoon_debugfs_init(struct vmballoon *b) static void __exit vmballoon_debugfs_exit(struct vmballoon *b) { static_key_disable(&balloon_stat_enabled.key); - debugfs_remove(debugfs_lookup("vmmemctl", NULL)); + debugfs_lookup_and_remove("vmmemctl", NULL); kfree(b->stats); b->stats = NULL; } -- 2.39.2