From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F361DC61DA3 for ; Fri, 3 Mar 2023 22:02:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233499AbjCCWCr (ORCPT ); Fri, 3 Mar 2023 17:02:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233500AbjCCWCC (ORCPT ); Fri, 3 Mar 2023 17:02:02 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BD496921A; Fri, 3 Mar 2023 13:52:46 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 14A9CB81A29; Fri, 3 Mar 2023 21:49:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E29CEC433D2; Fri, 3 Mar 2023 21:49:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677880180; bh=K320IATZViZ6p2z8opWgQ4B3i0XStvbTQyf1uRhNInQ=; h=From:To:Cc:Subject:Date:From; b=ra8vMEGrgZklv37vNMiitK7KRsQ/j7IQ+cXQZpyU5EyEcjiYGX4StjHdtYij37uO3 l7bMCNQQQT3gMWWBDWS1fzxkahowj7jBejafrA8uIyMwKEiMydzPlmEz8lUqPszII7 B5xwsFmPnFzTQNh8T5AnU3cwFyQst/Ty7bhUPUTF6OFS7YccvmWn6B/yGLYdqtNfGc oQ2wyzozBPFiR1K9+SH2Orpv82xRSKhkPmFkEup6GP3Cq5RmCIZKgxMJYvUxQWctSq GwwOpkAAAx3C+gdHczZiO0Rwc9LEikYJxMo9ZiLUEmNWvtiNzAiMJjuNAzTQlMlU84 H2oMnHS94MNEg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ricardo Ribalda , syzbot , Laurent Pinchart , Sasha Levin , mchehab@kernel.org, linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 01/11] media: uvcvideo: Handle cameras with invalid descriptors Date: Fri, 3 Mar 2023 16:49:27 -0500 Message-Id: <20230303214938.1454767-1-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Ricardo Ribalda [ Upstream commit 41ddb251c68ac75c101d3a50a68c4629c9055e4c ] If the source entity does not contain any pads, do not create a link. Reported-by: syzbot Signed-off-by: Ricardo Ribalda Reviewed-by: Laurent Pinchart Signed-off-by: Laurent Pinchart Signed-off-by: Sasha Levin --- drivers/media/usb/uvc/uvc_entity.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvc_entity.c b/drivers/media/usb/uvc/uvc_entity.c index f2457953f27c6..0d5aaaa7e2d96 100644 --- a/drivers/media/usb/uvc/uvc_entity.c +++ b/drivers/media/usb/uvc/uvc_entity.c @@ -42,7 +42,7 @@ static int uvc_mc_create_links(struct uvc_video_chain *chain, continue; remote = uvc_entity_by_id(chain->dev, entity->baSourceID[i]); - if (remote == NULL) + if (remote == NULL || remote->num_pads == 0) return -EINVAL; source = (UVC_ENTITY_TYPE(remote) == UVC_TT_STREAMING) -- 2.39.2