From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E2BCC6FD1F for ; Fri, 10 Mar 2023 14:15:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231877AbjCJOPg (ORCPT ); Fri, 10 Mar 2023 09:15:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231923AbjCJOPS (ORCPT ); Fri, 10 Mar 2023 09:15:18 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C401911882A for ; Fri, 10 Mar 2023 06:14:07 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 37184B822AD for ; Fri, 10 Mar 2023 14:14:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FB39C433EF; Fri, 10 Mar 2023 14:14:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1678457645; bh=ffMgLeMZxDkNnGYwZMvypKQsh+X1eRoZhnC21OD2I+8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=t9MnSyZIR7Ifno77EddKIUoShbled/NtlWTDMm5/kCZ3+NSQEt+5XEY7qSD6RHW/p BjW7Zf3wlBfAIokH2QYT8AoI1K+gjiLL8F6yzMnJ12O9QpNjwDDiFVLcp1zTbJg+ZU 3OrIF9bQNvCUwqGdlfl09zZdvLcQHI9AKRJrJdvI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Luke D Jones , Jiri Kosina , Stefan Ghinea Subject: [PATCH 4.19 001/252] HID: asus: Remove check for same LED brightness on set Date: Fri, 10 Mar 2023 14:36:11 +0100 Message-Id: <20230310133718.855723224@linuxfoundation.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230310133718.803482157@linuxfoundation.org> References: <20230310133718.803482157@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Luke D. Jones commit 3fdcf7cdfc229346d028242e73562704ad644dd0 upstream. Remove the early return on LED brightness set so that any controller application, daemon, or desktop may set the same brightness at any stage. This is required because many ASUS ROG keyboards will default to max brightness on laptop resume if the LEDs were set to off before sleep. Signed-off-by: Luke D Jones Signed-off-by: Jiri Kosina Signed-off-by: Stefan Ghinea Signed-off-by: Greg Kroah-Hartman --- drivers/hid/hid-asus.c | 3 --- 1 file changed, 3 deletions(-) --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -318,9 +318,6 @@ static void asus_kbd_backlight_set(struc { struct asus_kbd_leds *led = container_of(led_cdev, struct asus_kbd_leds, cdev); - if (led->brightness == brightness) - return; - led->brightness = brightness; schedule_work(&led->work); }