From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97967C64EC4 for ; Fri, 10 Mar 2023 14:34:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232569AbjCJOeB (ORCPT ); Fri, 10 Mar 2023 09:34:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232630AbjCJOdl (ORCPT ); Fri, 10 Mar 2023 09:33:41 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06CA91353F for ; Fri, 10 Mar 2023 06:33:33 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9DB5AB822BB for ; Fri, 10 Mar 2023 14:33:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4261C433EF; Fri, 10 Mar 2023 14:33:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1678458810; bh=SIQjfbK/VPjSfRPCYTyYi/yXepEm4KYKcTmVziNAguU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZjuLZ0UFXLSLs25X7BYLkbN3UaHtJUNgRDf11I55dLT3ppk7UE+ZjrC4Hupk3Yb2h IkjpOO+3deGDtSXzD/+dMtBQj/WIzZ3TaD2QDQ2g9B61V01+T7H9OAn7NAr93dIOA4 2vHAD+0dR5HBoWQI/pOGDCc7bcVgdEBfs13RskVA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jonathan Cormier , Guenter Roeck , Sasha Levin Subject: [PATCH 5.4 122/357] hwmon: (ltc2945) Handle error case in ltc2945_value_store Date: Fri, 10 Mar 2023 14:36:51 +0100 Message-Id: <20230310133740.046283839@linuxfoundation.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230310133733.973883071@linuxfoundation.org> References: <20230310133733.973883071@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Jonathan Cormier [ Upstream commit 178b01eccfb0b8149682f61388400bd3d903dddc ] ltc2945_val_to_reg errors were not being handled which would have resulted in register being set to 0 (clamped) instead of being left alone. Fixes: 6700ce035f83 ("hwmon: Driver for Linear Technologies LTC2945") Signed-off-by: Jonathan Cormier Signed-off-by: Guenter Roeck Signed-off-by: Sasha Levin --- drivers/hwmon/ltc2945.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/hwmon/ltc2945.c b/drivers/hwmon/ltc2945.c index 2818276ed3d6b..a1dd1ef40b565 100644 --- a/drivers/hwmon/ltc2945.c +++ b/drivers/hwmon/ltc2945.c @@ -248,6 +248,8 @@ static ssize_t ltc2945_value_store(struct device *dev, /* convert to register value, then clamp and write result */ regval = ltc2945_val_to_reg(dev, reg, val); + if (regval < 0) + return regval; if (is_power_reg(reg)) { regval = clamp_val(regval, 0, 0xffffff); regbuf[0] = regval >> 16; -- 2.39.2