* [PATCH] s390: reintroduce expoline dependence to scripts
[not found] <705ce64c-5f73-2ec8-e4bc-dd48c85f0498@kernel.org>
@ 2023-03-16 11:28 ` Jiri Slaby (SUSE)
2023-03-21 21:19 ` Vasily Gorbik
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Slaby (SUSE) @ 2023-03-16 11:28 UTC (permalink / raw)
To: gor
Cc: linux-kernel, Jiri Slaby (SUSE), Joe Lawrence, stable,
Heiko Carstens, Alexander Gordeev, Christian Borntraeger,
Sven Schnelle, linux-s390
Expolines depend on scripts/basic/fixdep. And build of expolines can now
race with the fixdep build:
make[1]: *** Deleting file 'arch/s390/lib/expoline/expoline.o'
/bin/sh: line 1: scripts/basic/fixdep: Permission denied
make[1]: *** [../scripts/Makefile.build:385: arch/s390/lib/expoline/expoline.o] Error 126
make: *** [../arch/s390/Makefile:166: expoline_prepare] Error 2
The dependence was removed in the below Fixes: commit. So reintroduce
the dependence on scripts.
Fixes: a0b0987a7811 ("s390/nospec: remove unneeded header includes")
Cc: Joe Lawrence <joe.lawrence@redhat.com>
Cc: stable@vger.kernel.org
Cc: Heiko Carstens <hca@linux.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>
Cc: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: Christian Borntraeger <borntraeger@linux.ibm.com>
Cc: Sven Schnelle <svens@linux.ibm.com>
Cc: linux-s390@vger.kernel.org
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
---
arch/s390/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/s390/Makefile b/arch/s390/Makefile
index b3235ab0ace8..ed646c583e4f 100644
--- a/arch/s390/Makefile
+++ b/arch/s390/Makefile
@@ -162,7 +162,7 @@ vdso_prepare: prepare0
ifdef CONFIG_EXPOLINE_EXTERN
modules_prepare: expoline_prepare
-expoline_prepare:
+expoline_prepare: scripts
$(Q)$(MAKE) $(build)=arch/s390/lib/expoline arch/s390/lib/expoline/expoline.o
endif
endif
--
2.40.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] s390: reintroduce expoline dependence to scripts
2023-03-16 11:28 ` [PATCH] s390: reintroduce expoline dependence to scripts Jiri Slaby (SUSE)
@ 2023-03-21 21:19 ` Vasily Gorbik
0 siblings, 0 replies; 2+ messages in thread
From: Vasily Gorbik @ 2023-03-21 21:19 UTC (permalink / raw)
To: Jiri Slaby (SUSE)
Cc: linux-kernel, Joe Lawrence, stable, Heiko Carstens,
Alexander Gordeev, Christian Borntraeger, Sven Schnelle,
linux-s390
On Thu, Mar 16, 2023 at 12:28:09PM +0100, Jiri Slaby (SUSE) wrote:
> Expolines depend on scripts/basic/fixdep. And build of expolines can now
> race with the fixdep build:
>
> make[1]: *** Deleting file 'arch/s390/lib/expoline/expoline.o'
> /bin/sh: line 1: scripts/basic/fixdep: Permission denied
> make[1]: *** [../scripts/Makefile.build:385: arch/s390/lib/expoline/expoline.o] Error 126
> make: *** [../arch/s390/Makefile:166: expoline_prepare] Error 2
>
> The dependence was removed in the below Fixes: commit. So reintroduce
> the dependence on scripts.
>
> Fixes: a0b0987a7811 ("s390/nospec: remove unneeded header includes")
> Cc: Joe Lawrence <joe.lawrence@redhat.com>
> Cc: stable@vger.kernel.org
> Cc: Heiko Carstens <hca@linux.ibm.com>
> Cc: Vasily Gorbik <gor@linux.ibm.com>
> Cc: Alexander Gordeev <agordeev@linux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@linux.ibm.com>
> Cc: Sven Schnelle <svens@linux.ibm.com>
> Cc: linux-s390@vger.kernel.org
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> ---
> arch/s390/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/Makefile b/arch/s390/Makefile
> index b3235ab0ace8..ed646c583e4f 100644
> --- a/arch/s390/Makefile
> +++ b/arch/s390/Makefile
> @@ -162,7 +162,7 @@ vdso_prepare: prepare0
>
> ifdef CONFIG_EXPOLINE_EXTERN
> modules_prepare: expoline_prepare
> -expoline_prepare:
> +expoline_prepare: scripts
> $(Q)$(MAKE) $(build)=arch/s390/lib/expoline arch/s390/lib/expoline/expoline.o
> endif
> endif
> --
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-21 21:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <705ce64c-5f73-2ec8-e4bc-dd48c85f0498@kernel.org>
2023-03-16 11:28 ` [PATCH] s390: reintroduce expoline dependence to scripts Jiri Slaby (SUSE)
2023-03-21 21:19 ` Vasily Gorbik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).