From: Christoph Hellwig <hch@lst.de>
To: Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
"# v4 . 16+" <stable@vger.kernel.org>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Sagi Grimberg <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM173X
Date: Fri, 17 Mar 2023 08:33:33 +0100 [thread overview]
Message-ID: <20230317073333.GA14827@lst.de> (raw)
In-Reply-To: <930CF361-37C2-4625-B5FA-245248544F92@oracle.com>
On Thu, Mar 16, 2023 at 09:31:38PM +0000, Saeed Mirzamohammadi wrote:
>
> eui64 values are not unique. Here is an example:
> namespace1
> nguid : 36554630529000710025384500000001
> eui64 : 002538191100104a
> namespace2
> nguid : 36554630529000710025384500000002
> eui64 : 002538191100104a
> namespace3
> nguid : 36554630529000710025384500000003
> eui64 : 002538191100104a
> namespace4
> nguid : 36554630529000710025384500000004
> eui64 : 002538191100104a
Eww, that's really a grave bug. Interestingly enough the nguid
works, so I wonder if we should just quirk the EUI so that we have
a least some uniqueue identifier.
> I haven’t yet contacted Samsung. Do you recommend any one to reach out to?
We have plenty of Samsung folks here on the list, maybe someone can
reply?
next prev parent reply other threads:[~2023-03-17 7:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 22:34 [PATCH 1/1] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM173X Saeed Mirzamohammadi
2023-03-15 22:38 ` Chaitanya Kulkarni
2023-03-16 5:15 ` Christoph Hellwig
2023-03-16 21:31 ` Saeed Mirzamohammadi
2023-03-17 7:33 ` Christoph Hellwig [this message]
2023-03-17 11:10 ` Pankaj Raghav
2023-03-17 16:26 ` Saeed Mirzamohammadi
2023-03-20 13:21 ` Pankaj Raghav
2023-03-21 13:26 ` Christoph Hellwig
2023-04-14 5:12 ` Christoph Hellwig
2023-04-27 7:37 ` Pankaj Raghav
2024-08-27 19:08 ` Saeed Mirzamohammadi
2024-08-28 10:27 ` Pankaj Raghav (Samsung)
2024-08-28 11:02 ` javier.gonz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230317073333.GA14827@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=saeed.mirzamohammadi@oracle.com \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).