From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Fedor Pchelkin <pchelkin@ispras.ru>
Cc: stable@vger.kernel.org, Andreas Gruenbacher <agruenba@redhat.com>,
cluster-devel@redhat.com, linux-kernel@vger.kernel.org,
Alexey Khoroshilov <khoroshilov@ispras.ru>,
lvc-project@linuxtesting.org,
syzbot+7bb81dfa9cda07d9cd9d@syzkaller.appspotmail.com
Subject: Re: [PATCH v2 4.19/5.4/5.10 1/1] gfs2: Always check inode size of inline inodes
Date: Mon, 3 Apr 2023 15:27:11 +0200 [thread overview]
Message-ID: <2023040302-surface-thwarting-037f@gregkh> (raw)
In-Reply-To: <20230324202615.330615-1-pchelkin@ispras.ru>
On Fri, Mar 24, 2023 at 11:26:15PM +0300, Fedor Pchelkin wrote:
> From: Andreas Gruenbacher <agruenba@redhat.com>
>
> commit 70376c7ff31221f1d21db5611d8209e677781d3a upstream.
>
> Check if the inode size of stuffed (inline) inodes is within the allowed
> range when reading inodes from disk (gfs2_dinode_in()). This prevents
> us from on-disk corruption.
>
> The two checks in stuffed_readpage() and gfs2_unstuffer_page() that just
> truncate inline data to the maximum allowed size don't actually make
> sense, and they can be removed now as well.
>
> Reported-by: syzbot+7bb81dfa9cda07d9cd9d@syzkaller.appspotmail.com
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
> [pchelkin@ispras.ru: adjust the inode variable inside gfs2_dinode_in with
> the format used before upstream commit 7db354444ad8 ("gfs2: Cosmetic
> gfs2_dinode_{in,out} cleanup")]
> Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
> ---
> v2: add missed From: tag
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2023-04-03 13:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 20:19 [PATCH 4.19/5.4/5.10 0/1] gfs2: Always check inode size of inline inodes Fedor Pchelkin
2023-03-24 20:19 ` [PATCH 4.19/5.4/5.10 1/1] " Fedor Pchelkin
2023-03-24 20:26 ` [PATCH v2 " Fedor Pchelkin
2023-04-03 13:27 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023040302-surface-thwarting-037f@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=agruenba@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=khoroshilov@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=pchelkin@ispras.ru \
--cc=stable@vger.kernel.org \
--cc=syzbot+7bb81dfa9cda07d9cd9d@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox