From: Greg KH <greg@kroah.com>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH 5.10.y] zonefs: Fix error message in zonefs_file_dio_append()
Date: Mon, 3 Apr 2023 15:13:22 +0200 [thread overview]
Message-ID: <2023040317-starter-coeditor-d7c8@gregkh> (raw)
In-Reply-To: <20230329102542.1757470-1-damien.lemoal@opensource.wdc.com>
On Wed, Mar 29, 2023 at 07:25:42PM +0900, Damien Le Moal wrote:
> commit 88b170088ad2c3e27086fe35769aa49f8a512564 upstream.
>
> Since the expected write location in a sequential file is always at the
> end of the file (append write), when an invalid write append location is
> detected in zonefs_file_dio_append(), print the invalid written location
> instead of the expected write location.
>
> Fixes: a608da3bd730 ("zonefs: Detect append writes at invalid locations")
> Cc: stable@vger.kernel.org
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
> ---
> fs/zonefs/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c
> index 66a089a62c39..b9522eee1257 100644
> --- a/fs/zonefs/super.c
> +++ b/fs/zonefs/super.c
> @@ -789,7 +789,7 @@ static ssize_t zonefs_file_dio_append(struct kiocb *iocb, struct iov_iter *from)
> if (bio->bi_iter.bi_sector != wpsector) {
> zonefs_warn(inode->i_sb,
> "Corrupted write pointer %llu for zone at %llu\n",
> - wpsector, zi->i_zsector);
> + bio->bi_iter.bi_sector, zi->i_zsector);
> ret = -EIO;
> }
> }
> --
> 2.39.2
>
All now queued up, thanks.
greg k-h
prev parent reply other threads:[~2023-04-03 13:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 11:40 FAILED: patch "[PATCH] zonefs: Fix error message in zonefs_file_dio_append()" failed to apply to 5.10-stable tree gregkh
2023-03-29 10:25 ` [PATCH 5.10.y] zonefs: Fix error message in zonefs_file_dio_append() Damien Le Moal
2023-04-03 13:13 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023040317-starter-coeditor-d7c8@gregkh \
--to=greg@kroah.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox