From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9798C6FD1D for ; Tue, 4 Apr 2023 18:32:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236494AbjDDScJ (ORCPT ); Tue, 4 Apr 2023 14:32:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236460AbjDDSbp (ORCPT ); Tue, 4 Apr 2023 14:31:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CEE52D7F for ; Tue, 4 Apr 2023 11:28:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 11B4D63557 for ; Tue, 4 Apr 2023 18:28:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3274C433EF; Tue, 4 Apr 2023 18:28:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1680632927; bh=BxxKJL+9mFS9yoZHZ1LpQC3nM6iq9Y/UD6VyFBiIDoQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tk15h++eFvtm+c1Kp2fI0QjVX4ShF3sZIvjyP74dkZhqLe+ZLZGDdKIdAW4x9uHGz DlWRXuik9vA/jkHqkjK5s6ZalF+Zw2HNqZyfueri6PEco3/grLqwxe4f8DuS5mSyAc SBD7n4zhxcK0Rpetw2ZplDyBS8jaQ4Q+WSUm4Y+c= Date: Tue, 4 Apr 2023 20:28:44 +0200 From: Greg Kroah-Hartman To: Sasha Levin Cc: Pascal Ernster , Ming Lei , stable@vger.kernel.org, patches@lists.linux.dev, Christoph Hellwig , Keith Busch , Chao Leng , Sagi Grimberg , Hannes Reinecke , Chaitanya Kulkarni , Jens Axboe Subject: Re: [PATCH 6.1 021/181] blk-mq: move the srcu_struct used for quiescing to the tagset Message-ID: <2023040433-festival-bonehead-3b24@gregkh> References: <20230403140415.090615502@linuxfoundation.org> <20230403140415.825266522@linuxfoundation.org> <401a5df3-b13b-fb56-a305-9c82f5f0ca77@0.smtp.remotehost.it> <2f2bcc75-e46b-6849-734c-2e646d9bb382@0.smtp.remotehost.it> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Apr 04, 2023 at 11:19:30AM -0400, Sasha Levin wrote: > On Tue, Apr 04, 2023 at 07:56:10AM +0200, Pascal Ernster wrote: > > [2023-04-04 03:17] Ming Lei: > > > On Mon, Apr 03, 2023 at 11:06:53PM +0200, Pascal Ernster wrote: > > > > On systems with their (btrfs) root filesystem residing on an LVM volume, > > > > this patch is reproducibly causing a complete freeze during shutdowns and > > > > reboots. > > > > > > > > I had previously replied with the same message to patch 022/181 instead of > > > > this one, but had gotten the subject mixed up actually meant this patch. > > > > > > That is because the dependency patch is missed: > > > > > > commit 8537380bb988 ("blk-mq: skip non-mq queues in blk_mq_quiesce_queue") > > > > > > https://lore.kernel.org/linux-block/Y6qpwYaPOxgsZjp9@T590/ > > > > > > Thanks a lot Ming, this does indeed fix the issue for me. :) > > Perfect, thanks for the report and the fix. > > I've dropped these two patches from the 6.1 tree for now with plans to > re-do it along with the missing dependency for the next release. Thanks for this, I'll go push out a -rc2 for this branch now. greg k-h