From: Greg KH <gregkh@linuxfoundation.org>
To: Pratyush Yadav <ptyadav@amazon.de>
Cc: kernel test robot <lkp@intel.com>,
stable@vger.kernel.org, oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH 5.4] cifs/smb3: Fix NULL pointer dereference in smb2_query_info_compound()
Date: Wed, 5 Apr 2023 16:22:58 +0200 [thread overview]
Message-ID: <2023040502-shortcut-curtly-cc96@gregkh> (raw)
In-Reply-To: <mafs0jzyqh2sf.fsf_-_@amazon.de>
On Wed, Apr 05, 2023 at 03:33:20PM +0200, Pratyush Yadav wrote:
> On Wed, Apr 05 2023, Greg KH wrote:
>
> > On Wed, Apr 05, 2023 at 02:26:04PM +0200, Greg KH wrote:
> >> On Wed, Apr 05, 2023 at 01:47:52PM +0200, Pratyush Yadav wrote:
> >> > On Wed, Apr 05 2023, kernel test robot wrote:
> >> >
> >> > > Hi,
> >> > >
> >> > > Thanks for your patch.
> >> > >
> >> > > FYI: kernel test robot notices the stable kernel rule is not satisfied.
> >> > >
> >> > > Rule: 'Cc: stable@vger.kernel.org' or 'commit <sha1> upstream.'
> >> >
> >> > I think the robot should also learn to look at the 'To:' header :-)
> >>
> >> Nope, the robot is correct, you submitted this incorrectly.
> >
> > Wait, maybe, I can't tell.
>
> My point is that it does not matter much if stable@vger.kernel.org is in
> Cc or To. It gets the email regardless. In fact, that seems quite a
> common practice to me [0][1]. So I'd say it would be nice if the robot
> did not needlessly complain about this.
The robot replaces my bot (well, aguments this), and it rightfully flags
many patches that are sent to stable that are not done so correctly, so
that the submitter can then fix them up. The number of "false
positives" like this is pretty low, as hey, even I got it wrong when
reading this "by hand".
thanks,
greg k-h
next prev parent reply other threads:[~2023-04-05 14:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 11:42 [PATCH 5.4] cifs/smb3: Fix NULL pointer dereference in smb2_query_info_compound() Pratyush Yadav
2023-04-05 11:44 ` kernel test robot
2023-04-05 11:47 ` Pratyush Yadav
2023-04-05 12:26 ` Greg KH
2023-04-05 12:26 ` Greg KH
2023-04-05 13:33 ` Pratyush Yadav
2023-04-05 14:22 ` Greg KH [this message]
2023-04-12 7:47 ` Yujie Liu
2023-04-12 13:21 ` Pratyush Yadav
2023-04-13 5:49 ` Yujie Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023040502-shortcut-curtly-cc96@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=ptyadav@amazon.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox