From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9B55C7619A for ; Wed, 12 Apr 2023 06:50:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229523AbjDLGui (ORCPT ); Wed, 12 Apr 2023 02:50:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229830AbjDLGuh (ORCPT ); Wed, 12 Apr 2023 02:50:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 944C45FDE for ; Tue, 11 Apr 2023 23:50:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3009C62A3C for ; Wed, 12 Apr 2023 06:50:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4280BC433A0; Wed, 12 Apr 2023 06:50:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1681282233; bh=Kp4/GQVaOXhVIhcBj3MV50JSrG4W/6+Q/akSueMD+GI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TOfxO/kxkJ6o4XoZtt3CbirmrT3+TRC9RfrAyvqc60dAINyxH2nfKPpOjanpxy6fy uaCMyqdE/z/CkdLKGv8RwjbqEHu4ewV5t/hVeZsHxtuZwuhJoTzoOhRiV4GTVCGBLq sQakT1v2mwLYAzhU9yZpZ2C+f2Cjrtx2lAi2OVQE= Date: Wed, 12 Apr 2023 08:50:30 +0200 From: Greg KH To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: stable@vger.kernel.org, Manasi Navare , Drew Davenport , Imre Deak , Jouni =?iso-8859-1?Q?H=F6gander?= Subject: Re: [PATCH 6.1.y 1/3] drm/i915: Split icl_color_commit_noarm() from skl_color_commit_noarm() Message-ID: <2023041254-transfer-citizen-de43@gregkh> References: <2023040313-periscope-celery-403f@gregkh> <20230403162618.18469-1-ville.syrjala@linux.intel.com> <2023041117-cannot-sensuous-6f62@gregkh> <2023041226-zoology-smoking-5d9c@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Apr 12, 2023 at 09:40:57AM +0300, Ville Syrjälä wrote: > On Wed, Apr 12, 2023 at 08:17:57AM +0200, Greg KH wrote: > > On Tue, Apr 11, 2023 at 06:51:52PM +0300, Ville Syrjälä wrote: > > > On Tue, Apr 11, 2023 at 03:58:49PM +0200, Greg KH wrote: > > > > On Mon, Apr 03, 2023 at 07:26:16PM +0300, Ville Syrjala wrote: > > > > > From: Ville Syrjälä > > > > > > > > > > We're going to want different behavior for skl/glk vs. icl > > > > > in .color_commit_noarm(), so split the hook into two. Arguably > > > > > we already had slightly different behaviour since > > > > > csc_enable/gamma_enable are never set on icl+, so the old > > > > > code was perhaps a bit confusing as well. > > > > > > > > > > Cc: #v5.19+ > > > > > Cc: # 05ca98523481: drm/i915: Use _MMIO_PIPE() for SKL_BOTTOM_COLOR > > > > > Cc: Manasi Navare > > > > > Cc: Drew Davenport > > > > > Cc: Imre Deak > > > > > Cc: Jouni Högander > > > > > Signed-off-by: Ville Syrjälä > > > > > Link: https://patchwork.freedesktop.org/patch/msgid/20230320095438.17328-2-ville.syrjala@linux.intel.com > > > > > Reviewed-by: Imre Deak > > > > > (cherry picked from commit f161eb01f50ab31f2084975b43bce54b7b671e17) > > > > > Signed-off-by: Jani Nikula > > > > > (cherry picked from commit 76b767d4d1cd052e455cf18e06929e8b2b70101d) > > > > > --- > > > > > drivers/gpu/drm/i915/display/intel_color.c | 21 ++++++++++++++++++++- > > > > > 1 file changed, 20 insertions(+), 1 deletion(-) > > > > > > > > This commit breaks the build. > > > > > > You did cherry pick all the dependencies I listed? > > > > Nope! When you send a patch series, I had assumed that it was > > self-contained :( > > I can do that in the future if it's preferred. But that does > seem to imply that there's no point in even listing the > dependencies. Not at all, I missed the dependency list the first time, so a simple "hey you forgot the dependency!" would have sufficied :) thanks, greg k-h